https://github.com/torvalds/linux
Revision 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC, committed by Alex Deucher on 01 July 2019, 14:15:00 UTC
I'm not entirely sure why this is, but for some reason:

921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")

Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the
pre-production laptops I have. The issue manifests as the following
messages in dmesg:

[drm] UVD and UVD ENC initialized successfully.
amdgpu 0000:3b:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce1 test failed (-110)
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <vce_v3_0> failed -110
[drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-110).

And happens after about 6-10 runtime PM suspend/resume cycles (sometimes
sooner, if you're lucky!). Unfortunately I can't seem to pin down
precisely which part in psm_adjust_power_state_dynamic that is causing
the issue, but not skipping the display setting setup seems to fix it.
Hopefully if there is a better fix for this, this patch will spark
discussion around it.

Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Rex Zhu <Rex.Zhu@amd.com>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f78c581
History
Tip revision: 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC
drm/amdgpu: Don't skip display settings in hwmgr_resume()
Tip revision: 688f3d1
File Mode Size
auth_gss
xprtrdma
Kconfig -rw-r--r-- 2.4 KB
Makefile -rw-r--r-- 628 bytes
addr.c -rw-r--r-- 8.7 KB
auth.c -rw-r--r-- 21.8 KB
auth_null.c -rw-r--r-- 2.7 KB
auth_unix.c -rw-r--r-- 5.3 KB
backchannel_rqst.c -rw-r--r-- 10.9 KB
cache.c -rw-r--r-- 45.5 KB
clnt.c -rw-r--r-- 70.3 KB
debugfs.c -rw-r--r-- 7.7 KB
netns.h -rw-r--r-- 976 bytes
rpc_pipe.c -rw-r--r-- 35.4 KB
rpcb_clnt.c -rw-r--r-- 30.5 KB
sched.c -rw-r--r-- 33.3 KB
socklib.c -rw-r--r-- 4.5 KB
stats.c -rw-r--r-- 8.4 KB
sunrpc.h -rw-r--r-- 1.9 KB
sunrpc_syms.c -rw-r--r-- 2.8 KB
svc.c -rw-r--r-- 40.5 KB
svc_xprt.c -rw-r--r-- 38.0 KB
svcauth.c -rw-r--r-- 4.5 KB
svcauth_unix.c -rw-r--r-- 21.5 KB
svcsock.c -rw-r--r-- 38.6 KB
sysctl.c -rw-r--r-- 3.6 KB
timer.c -rw-r--r-- 2.9 KB
xdr.c -rw-r--r-- 41.8 KB
xprt.c -rw-r--r-- 50.4 KB
xprtmultipath.c -rw-r--r-- 12.2 KB
xprtsock.c -rw-r--r-- 83.4 KB

back to top