https://github.com/torvalds/linux
Revision 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC, committed by Alex Deucher on 01 July 2019, 14:15:00 UTC
I'm not entirely sure why this is, but for some reason:

921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")

Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the
pre-production laptops I have. The issue manifests as the following
messages in dmesg:

[drm] UVD and UVD ENC initialized successfully.
amdgpu 0000:3b:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce1 test failed (-110)
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <vce_v3_0> failed -110
[drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-110).

And happens after about 6-10 runtime PM suspend/resume cycles (sometimes
sooner, if you're lucky!). Unfortunately I can't seem to pin down
precisely which part in psm_adjust_power_state_dynamic that is causing
the issue, but not skipping the display setting setup seems to fix it.
Hopefully if there is a better fix for this, this patch will spark
discussion around it.

Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Rex Zhu <Rex.Zhu@amd.com>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f78c581
History
Tip revision: 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC
drm/amdgpu: Don't skip display settings in hwmgr_resume()
Tip revision: 688f3d1
File Mode Size
certs
.gitignore -rw-r--r-- 30 bytes
Kconfig -rw-r--r-- 7.5 KB
Makefile -rw-r--r-- 2.1 KB
ap.c -rw-r--r-- 1.3 KB
chan.c -rw-r--r-- 26.5 KB
core.c -rw-r--r-- 38.0 KB
core.h -rw-r--r-- 17.3 KB
debugfs.c -rw-r--r-- 2.9 KB
debugfs.h -rw-r--r-- 339 bytes
ethtool.c -rw-r--r-- 733 bytes
ibss.c -rw-r--r-- 12.1 KB
lib80211.c -rw-r--r-- 6.6 KB
lib80211_crypt_ccmp.c -rw-r--r-- 11.4 KB
lib80211_crypt_tkip.c -rw-r--r-- 19.7 KB
lib80211_crypt_wep.c -rw-r--r-- 6.6 KB
mesh.c -rw-r--r-- 8.0 KB
mlme.c -rw-r--r-- 23.7 KB
nl80211.c -rw-r--r-- 449.0 KB
nl80211.h -rw-r--r-- 4.8 KB
ocb.c -rw-r--r-- 1.8 KB
of.c -rw-r--r-- 3.4 KB
pmsr.c -rw-r--r-- 15.7 KB
radiotap.c -rw-r--r-- 11.8 KB
rdev-ops.h -rw-r--r-- 37.4 KB
reg.c -rw-r--r-- 102.8 KB
reg.h -rw-r--r-- 7.5 KB
scan.c -rw-r--r-- 65.2 KB
sme.c -rw-r--r-- 34.5 KB
sysfs.c -rw-r--r-- 4.0 KB
sysfs.h -rw-r--r-- 222 bytes
trace.c -rw-r--r-- 102 bytes
trace.h -rw-r--r-- 94.1 KB
util.c -rw-r--r-- 48.6 KB
wext-compat.c -rw-r--r-- 38.7 KB
wext-compat.h -rw-r--r-- 2.3 KB
wext-core.c -rw-r--r-- 31.5 KB
wext-priv.c -rw-r--r-- 6.9 KB
wext-proc.c -rw-r--r-- 3.6 KB
wext-sme.c -rw-r--r-- 8.6 KB
wext-spy.c -rw-r--r-- 6.6 KB

back to top