Revision 6a146f3a5894b751cef16feb3d7903e45e3c445c authored by Guilherme G. Piccoli on 10 July 2017, 13:55:46 UTC, committed by David S. Miller on 11 July 2017, 20:40:22 UTC
Since the introduction of ULD (Upper-Layer Drivers), the MSI-X deallocating path changed in cxgb4: the driver frees the interrupts of ULD when unregistering it or on shutdown PCI handler. Problem is that if a MSI-X is not freed before deallocated in the PCI layer, it will trigger a BUG() due to still "alive" interrupt being tentatively quiesced. The below trace was observed when doing a simple unbind of Chelsio's adapter PCI function, like: "echo 001e:80:00.4 > /sys/bus/pci/drivers/cxgb4/unbind" Trace: kernel BUG at drivers/pci/msi.c:352! Oops: Exception in kernel mode, sig: 5 [#1] ... NIP [c0000000005a5e60] free_msi_irqs+0xa0/0x250 LR [c0000000005a5e50] free_msi_irqs+0x90/0x250 Call Trace: [c0000000005a5e50] free_msi_irqs+0x90/0x250 (unreliable) [c0000000005a72c4] pci_disable_msix+0x124/0x180 [d000000011e06708] disable_msi+0x88/0xb0 [cxgb4] [d000000011e06948] free_some_resources+0xa8/0x160 [cxgb4] [d000000011e06d60] remove_one+0x170/0x3c0 [cxgb4] [c00000000058a910] pci_device_remove+0x70/0x110 [c00000000064ef04] device_release_driver_internal+0x1f4/0x2c0 ... This patch fixes the issue by refactoring the shutdown path of ULD on cxgb4 driver, by properly freeing and disabling interrupts on PCI remove handler too. Fixes: 0fbc81b3ad51 ("Allocate resources dynamically for all cxgb4 ULD's") Reported-by: Harsha Thyagaraja <hathyaga@in.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 91d1ae4
File | Mode | Size |
---|---|---|
netfilter | ||
Kconfig | -rw-r--r-- | 2.0 KB |
Makefile | -rw-r--r-- | 771 bytes |
br.c | -rw-r--r-- | 6.1 KB |
br_device.c | -rw-r--r-- | 9.9 KB |
br_fdb.c | -rw-r--r-- | 27.2 KB |
br_forward.c | -rw-r--r-- | 7.3 KB |
br_if.c | -rw-r--r-- | 14.5 KB |
br_input.c | -rw-r--r-- | 8.7 KB |
br_ioctl.c | -rw-r--r-- | 9.0 KB |
br_mdb.c | -rw-r--r-- | 16.7 KB |
br_multicast.c | -rw-r--r-- | 60.7 KB |
br_netfilter_hooks.c | -rw-r--r-- | 28.9 KB |
br_netfilter_ipv6.c | -rw-r--r-- | 5.8 KB |
br_netlink.c | -rw-r--r-- | 43.7 KB |
br_netlink_tunnel.c | -rw-r--r-- | 6.9 KB |
br_nf_core.c | -rw-r--r-- | 2.2 KB |
br_private.h | -rw-r--r-- | 30.9 KB |
br_private_stp.h | -rw-r--r-- | 1.9 KB |
br_private_tunnel.h | -rw-r--r-- | 2.3 KB |
br_stp.c | -rw-r--r-- | 15.4 KB |
br_stp_bpdu.c | -rw-r--r-- | 5.8 KB |
br_stp_if.c | -rw-r--r-- | 8.4 KB |
br_stp_timer.c | -rw-r--r-- | 4.5 KB |
br_switchdev.c | -rw-r--r-- | 3.1 KB |
br_sysfs_br.c | -rw-r--r-- | 25.7 KB |
br_sysfs_if.c | -rw-r--r-- | 8.8 KB |
br_vlan.c | -rw-r--r-- | 24.9 KB |
br_vlan_tunnel.c | -rw-r--r-- | 4.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...