Revision 6af773e786ad617b0264ebe06ba60675c01f3e51 authored by Nishank Trivedi on 12 September 2012, 13:32:49 UTC, committed by David S. Miller on 13 September 2012, 21:10:00 UTC
If vlan option is being specified in the pktgen and packet size being requested is less than 46 bytes, despite being illogical request, pktgen should not crash the kernel. BUG: unable to handle kernel paging request at ffff88021fb82000 Process kpktgend_0 (pid: 1184, threadinfo ffff880215f1a000, task ffff880218544530) Call Trace: [<ffffffffa0637cd2>] ? pktgen_finalize_skb+0x222/0x300 [pktgen] [<ffffffff814f0084>] ? build_skb+0x34/0x1c0 [<ffffffffa0639b11>] pktgen_thread_worker+0x5d1/0x1790 [pktgen] [<ffffffffa03ffb10>] ? igb_xmit_frame_ring+0xa30/0xa30 [igb] [<ffffffff8107ba20>] ? wake_up_bit+0x40/0x40 [<ffffffff8107ba20>] ? wake_up_bit+0x40/0x40 [<ffffffffa0639540>] ? spin+0x240/0x240 [pktgen] [<ffffffff8107b4e3>] kthread+0x93/0xa0 [<ffffffff81615de4>] kernel_thread_helper+0x4/0x10 [<ffffffff8107b450>] ? flush_kthread_worker+0x80/0x80 [<ffffffff81615de0>] ? gs_change+0x13/0x13 The root cause of why pktgen is not able to handle this case is due to comparison of signed (datalen) and unsigned data (sizeof), which eventually passes a huge number to skb_put(). Signed-off-by: Nishank Trivedi <nistrive@cisco.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7b5342d
File | Mode | Size |
---|---|---|
amiga | ||
apollo | ||
atari | ||
bvme6000 | ||
configs | ||
emu | ||
fpsp040 | ||
hp300 | ||
ifpsp060 | ||
include | ||
kernel | ||
lib | ||
mac | ||
math-emu | ||
mm | ||
mvme147 | ||
mvme16x | ||
platform | ||
q40 | ||
sun3 | ||
sun3x | ||
tools | ||
Kconfig | -rw-r--r-- | 1.9 KB |
Kconfig.bus | -rw-r--r-- | 1.7 KB |
Kconfig.cpu | -rw-r--r-- | 12.1 KB |
Kconfig.debug | -rw-r--r-- | 1.1 KB |
Kconfig.devices | -rw-r--r-- | 3.6 KB |
Kconfig.machine | -rw-r--r-- | 14.9 KB |
Makefile | -rw-r--r-- | 5.3 KB |
install.sh | -rw-r--r-- | 1.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...