Revision - 6bfd513 - [LayoutNG] Don't allow line height quirk inside list items. - origin: https://github.com/web-platform-tests/wpt

visit type:

https://github.com/web-platform-tests/wpt

26 December 2018, 22:31:15 UTC

Revision 6bfd51316130abc1d6b648ba281792fb34e4ee82 authored by Morten Stenshorne on 20 December 2018, 20:09:59 UTC, committed by Blink WPT Bot on 20 December 2018, 20:16:03 UTC

[LayoutNG] Don't allow line height quirk inside list items.

This makes us match legacy engine behavior more closely, and both Edge
and Firefox have something similar, although Firefox triggers based on
element type (LI), and not display type (list-item). There's currently
nothing in the spec [1] that suggests such special behavior for list
items.

[1] https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk

This fix makes the line height differences go away in the test
tables/mozilla/bugs/bug23235.html (but note that it will still require
a rebaseline, because of minor text rendering differences between
legacy and NG).

See https://github.com/whatwg/quirks/issues/38 for spec discussion.

Change-Id: I396c0c85454feeaa45a0a5953b9e6b7c475d131e
Reviewed-on: https://chromium-review.googlesource.com/c/1379897
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618304}

1 parent a2448c2

Files
Changes

Permalinks

Tip revision: 6bfd51316130abc1d6b648ba281792fb34e4ee82 authored by Morten Stenshorne on 20 December 2018, 20:09:59 UTC
[LayoutNG] Don't allow line height quirk inside list items.

Tip revision: 6bfd513

File	Mode	Size
.well-known
2dcontext
BackgroundSync
FileAPI
IndexedDB
WebCryptoAPI
WebIDL
accelerometer
accname
acid
ambient-light
animation-worklet
annotation-model
annotation-protocol
annotation-vocab
apng
appmanifest
async-local-storage
audio-output
background-fetch
battery-status
beacon
bluetooth
clear-site-data
client-hints
clipboard-apis
common
compat
conformance-checkers
console
content-security-policy
cookie-store
cookies
core-aam
cors
credential-management
css
custom-elements
device-memory
docs
dom
domparsing
domxpath
dpub-aam
dpub-aria
editing
encoding
encrypted-media
entries-api
event-timing
eventsource
feature-policy
fetch
fonts
fullscreen
gamepad
generic-sensor
geolocation-API
geolocation-sensor
graphics-aam
gyroscope
hr-time
html
html-longdesc
html-media-capture
imagebitmap-renderingcontext
images
inert
infrastructure
input-device-capabilities
input-events
interfaces
intersection-observer
js
keyboard-lock
keyboard-map
lifecycle
loading
longtask-timing
magnetometer
mathml
media
media-capabilities
media-source
mediacapture-depth
mediacapture-fromelement
mediacapture-image
mediacapture-record
mediacapture-streams
mediasession
mimesniff
mixed-content
mst-content-hint
navigation-timing
netinfo
network-error-logging
notifications
offscreen-canvas
old-tests
orientation-event
orientation-sensor
origin-policy
page-visibility
paint-timing
payment-handler
payment-method-basic-card
payment-method-id
payment-request
performance-timeline
permissions
picture-in-picture
pointerevents
pointerlock
portals
preload
presentation-api
priority-hints
proximity
push-api
quirks
referrer-policy
remote-playback
reporting
requestidlecallback
resize-observer
resource-timing
resources
screen-capture
screen-orientation
scroll-animations
secure-contexts
selection
server-timing
service-workers
shadow-dom
shape-detection
signed-exchange
speech-api
storage
streams
subresource-integrity
svg
svg-aam
tools
touch-events
trusted-types
uievents
upgrade-insecure-requests
url
user-timing
vibration
visual-viewport
wai-aria
wake-lock
wasm
web-animations
web-locks
web-nfc
web-share
webaudio
webauthn
webdriver
webgl
webmessaging
webmidi
webrtc
webrtc-identity
webrtc-quic
webrtc-stats
websockets
webstorage
webusb
webvr
webvtt
webxr
workers
worklets
x-frame-options
xhr
.azure-pipelines.yml	-rw-r--r--	4.9 KB
.codecov.yml	-rw-r--r--	66 bytes
.gitignore	-rw-r--r--	374 bytes
.gitmodules	-rw-r--r--	138 bytes
.pyup.yml	-rw-r--r--	1.1 KB
.taskcluster.yml	-rw-r--r--	6.9 KB
.travis.yml	-rw-r--r--	3.1 KB
CODEOWNERS	-rw-r--r--	98 bytes
CONTRIBUTING.md	-rw-r--r--	1.6 KB
LICENSE.md	-rw-r--r--	5.1 KB
README.md	-rw-r--r--	17.3 KB
check_stability.ini	-rw-r--r--	419 bytes
lint.whitelist	-rw-r--r--	46.1 KB
serve.py	-rw-r--r--	263 bytes
server-side.md	-rw-r--r--	8.1 KB
testharness_runner.html	-rw-r--r--	95 bytes
update-built-tests.sh	-rwxr-xr-x	208 bytes
wpt	-rwxr-xr-x	95 bytes
wpt.py	-rw-r--r--	15 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/web-platform-tests/wpt

[LayoutNG] Don't allow line height quirk inside list items.

README.md