Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision 6c0544e255dd6582a9899572e120fb55d9f672a4 authored by majianpeng on 12 June 2012, 00:31:10 UTC, committed by NeilBrown on 03 July 2012, 02:09:57 UTC 
md/raid5: Do not add data_offset before call to is_badblock
 
In chunk_aligned_read() we are adding data_offset before calling
is_badblock.  But is_badblock also adds data_offset, so that is bad.

So move the addition of data_offset to after the call to
is_badblock.

This bug was introduced by commit 31c176ecdf3563140e639
     md/raid5: avoid reading from known bad blocks.
which first appeared in 3.0.  So that patch is suitable for any
-stable kernel from 3.0.y onwards.  However it will need minor
revision for most of those (as the comment didn't appear until
recently).

Cc: stable@vger.kernel.org
Signed-off-by: majianpeng <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
1 parent 5cfb22a
History
Tip revision: 6c0544e255dd6582a9899572e120fb55d9f672a4 authored by majianpeng on 12 June 2012, 00:31:10 UTC
md/raid5: Do not add data_offset before call to is_badblock
Tip revision: 6c0544e
File Mode Size
Kconfig -rw-r--r-- 50.7 KB
Makefile -rw-r--r-- 1.1 KB
calibrate.c -rw-r--r-- 8.3 KB
do_mounts.c -rw-r--r-- 12.8 KB
do_mounts.h -rw-r--r-- 1.4 KB
do_mounts_initrd.c -rw-r--r-- 3.4 KB
do_mounts_md.c -rw-r--r-- 8.2 KB
do_mounts_rd.c -rw-r--r-- 8.4 KB
init_task.c -rw-r--r-- 668 bytes
initramfs.c -rw-r--r-- 12.9 KB
main.c -rw-r--r-- 21.4 KB
noinitramfs.c -rw-r--r-- 1.5 KB
version.c -rw-r--r-- 1.1 KB
back to top