Revision 6cf11ee6300f38b7cfc43af9b7be2afaa5e05869 authored by Hans Verkuil on 19 January 2015, 09:16:18 UTC, committed by Mauro Carvalho Chehab on 21 January 2015, 23:07:26 UTC
The locking scheme inside the vb2 thread is unsafe when stopping the thread. In particular kthread_stop was called *after* internal data structures were cleaned up instead of doing that before. In addition, internal vb2 functions were called after threadio->stop was set to true and vb2_internal_streamoff was called. This is also not allowed. All this led to a variety of race conditions and kernel warnings and/or oopses. Fixed by moving the kthread_stop call up before the cleanup takes place, and by checking threadio->stop before calling internal vb2 queuing operations. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Cc: <stable@vger.kernel.org> # for v3.16 and up Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
1 parent 42d74e4
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.7 KB |
| Makefile | -rw-r--r-- | 312 bytes |
| fmc-chardev.c | -rw-r--r-- | 4.1 KB |
| fmc-core.c | -rw-r--r-- | 7.0 KB |
| fmc-dump.c | -rw-r--r-- | 2.6 KB |
| fmc-fakedev.c | -rw-r--r-- | 10.5 KB |
| fmc-match.c | -rw-r--r-- | 3.1 KB |
| fmc-sdb.c | -rw-r--r-- | 7.3 KB |
| fmc-trivial.c | -rw-r--r-- | 2.4 KB |
| fmc-write-eeprom.c | -rw-r--r-- | 4.1 KB |
| fru-parse.c | -rw-r--r-- | 1.8 KB |
Computing file changes ...
