Revision 6cf11ee6300f38b7cfc43af9b7be2afaa5e05869 authored by Hans Verkuil on 19 January 2015, 09:16:18 UTC, committed by Mauro Carvalho Chehab on 21 January 2015, 23:07:26 UTC
The locking scheme inside the vb2 thread is unsafe when stopping the thread. In particular kthread_stop was called *after* internal data structures were cleaned up instead of doing that before. In addition, internal vb2 functions were called after threadio->stop was set to true and vb2_internal_streamoff was called. This is also not allowed. All this led to a variety of race conditions and kernel warnings and/or oopses. Fixed by moving the kthread_stop call up before the cleanup takes place, and by checking threadio->stop before calling internal vb2 queuing operations. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Cc: <stable@vger.kernel.org> # for v3.16 and up Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
1 parent 42d74e4
File | Mode | Size |
---|---|---|
whci | ||
Kconfig | -rw-r--r-- | 25.4 KB |
Makefile | -rw-r--r-- | 2.8 KB |
bcma-hcd.c | -rw-r--r-- | 7.8 KB |
ehci-atmel.c | -rw-r--r-- | 5.1 KB |
ehci-dbg.c | -rw-r--r-- | 28.0 KB |
ehci-exynos.c | -rw-r--r-- | 8.2 KB |
ehci-fsl.c | -rw-r--r-- | 18.9 KB |
ehci-fsl.h | -rw-r--r-- | 2.5 KB |
ehci-grlib.c | -rw-r--r-- | 4.5 KB |
ehci-hcd.c | -rw-r--r-- | 38.3 KB |
ehci-hub.c | -rw-r--r-- | 35.1 KB |
ehci-mem.c | -rw-r--r-- | 6.5 KB |
ehci-msm.c | -rw-r--r-- | 5.4 KB |
ehci-mv.c | -rw-r--r-- | 7.4 KB |
ehci-mxc.c | -rw-r--r-- | 5.7 KB |
ehci-octeon.c | -rw-r--r-- | 4.0 KB |
ehci-omap.c | -rw-r--r-- | 8.5 KB |
ehci-orion.c | -rw-r--r-- | 8.0 KB |
ehci-pci.c | -rw-r--r-- | 11.6 KB |
ehci-platform.c | -rw-r--r-- | 9.4 KB |
ehci-pmcmsp.c | -rw-r--r-- | 7.5 KB |
ehci-ppc-of.c | -rw-r--r-- | 5.2 KB |
ehci-ps3.c | -rw-r--r-- | 6.8 KB |
ehci-q.c | -rw-r--r-- | 41.3 KB |
ehci-sched.c | -rw-r--r-- | 64.9 KB |
ehci-sead3.c | -rw-r--r-- | 4.2 KB |
ehci-sh.c | -rw-r--r-- | 4.4 KB |
ehci-spear.c | -rw-r--r-- | 4.4 KB |
ehci-st.c | -rw-r--r-- | 8.5 KB |
ehci-sysfs.c | -rw-r--r-- | 5.1 KB |
ehci-tegra.c | -rw-r--r-- | 16.4 KB |
ehci-tilegx.c | -rw-r--r-- | 5.1 KB |
ehci-timer.c | -rw-r--r-- | 13.3 KB |
ehci-w90x900.c | -rw-r--r-- | 3.3 KB |
ehci-xilinx-of.c | -rw-r--r-- | 6.5 KB |
ehci.h | -rw-r--r-- | 28.0 KB |
fhci-dbg.c | -rw-r--r-- | 3.6 KB |
fhci-hcd.c | -rw-r--r-- | 19.1 KB |
fhci-hub.c | -rw-r--r-- | 8.8 KB |
fhci-mem.c | -rw-r--r-- | 2.6 KB |
fhci-q.c | -rw-r--r-- | 6.9 KB |
fhci-sched.c | -rw-r--r-- | 23.8 KB |
fhci-tds.c | -rw-r--r-- | 16.5 KB |
fhci.h | -rw-r--r-- | 18.5 KB |
fotg210-hcd.c | -rw-r--r-- | 161.8 KB |
fotg210.h | -rw-r--r-- | 23.6 KB |
fsl-mph-dr-of.c | -rw-r--r-- | 8.7 KB |
fusbh200-hcd.c | -rw-r--r-- | 164.6 KB |
fusbh200.h | -rw-r--r-- | 23.9 KB |
hwa-hc.c | -rw-r--r-- | 26.7 KB |
imx21-dbg.c | -rw-r--r-- | 12.6 KB |
imx21-hcd.c | -rw-r--r-- | 47.8 KB |
imx21-hcd.h | -rw-r--r-- | 12.3 KB |
isp116x-hcd.c | -rw-r--r-- | 43.3 KB |
isp116x.h | -rw-r--r-- | 17.6 KB |
isp1362-hcd.c | -rw-r--r-- | 84.7 KB |
isp1362.h | -rw-r--r-- | 30.4 KB |
isp1760-hcd.c | -rw-r--r-- | 57.3 KB |
isp1760-hcd.h | -rw-r--r-- | 5.8 KB |
isp1760-if.c | -rw-r--r-- | 11.0 KB |
max3421-hcd.c | -rw-r--r-- | 50.1 KB |
octeon2-common.c | -rw-r--r-- | 4.9 KB |
ohci-at91.c | -rw-r--r-- | 16.4 KB |
ohci-da8xx.c | -rw-r--r-- | 10.1 KB |
ohci-dbg.c | -rw-r--r-- | 20.0 KB |
ohci-exynos.c | -rw-r--r-- | 7.2 KB |
ohci-hcd.c | -rw-r--r-- | 36.3 KB |
ohci-hub.c | -rw-r--r-- | 20.6 KB |
ohci-jz4740.c | -rw-r--r-- | 5.5 KB |
ohci-mem.c | -rw-r--r-- | 3.4 KB |
ohci-nxp.c | -rw-r--r-- | 9.1 KB |
ohci-octeon.c | -rw-r--r-- | 3.9 KB |
ohci-omap.c | -rw-r--r-- | 12.6 KB |
ohci-omap3.c | -rw-r--r-- | 5.3 KB |
ohci-pci.c | -rw-r--r-- | 7.7 KB |
ohci-platform.c | -rw-r--r-- | 9.1 KB |
ohci-ppc-of.c | -rw-r--r-- | 5.2 KB |
ohci-ps3.c | -rw-r--r-- | 6.4 KB |
ohci-pxa27x.c | -rw-r--r-- | 17.4 KB |
ohci-q.c | -rw-r--r-- | 33.5 KB |
ohci-s3c2410.c | -rw-r--r-- | 11.3 KB |
ohci-sa1111.c | -rw-r--r-- | 6.2 KB |
ohci-sm501.c | -rw-r--r-- | 6.8 KB |
ohci-spear.c | -rw-r--r-- | 4.9 KB |
ohci-st.c | -rw-r--r-- | 7.8 KB |
ohci-tilegx.c | -rw-r--r-- | 4.6 KB |
ohci-tmio.c | -rw-r--r-- | 9.6 KB |
ohci.h | -rw-r--r-- | 23.4 KB |
oxu210hp-hcd.c | -rw-r--r-- | 98.2 KB |
oxu210hp.h | -rw-r--r-- | 14.4 KB |
pci-quirks.c | -rw-r--r-- | 29.7 KB |
pci-quirks.h | -rw-r--r-- | 1.0 KB |
r8a66597-hcd.c | -rw-r--r-- | 63.0 KB |
r8a66597.h | -rw-r--r-- | 8.5 KB |
sl811-hcd.c | -rw-r--r-- | 45.9 KB |
sl811.h | -rw-r--r-- | 6.3 KB |
sl811_cs.c | -rw-r--r-- | 4.7 KB |
ssb-hcd.c | -rw-r--r-- | 6.7 KB |
u132-hcd.c | -rw-r--r-- | 90.8 KB |
uhci-debug.c | -rw-r--r-- | 15.8 KB |
uhci-grlib.c | -rw-r--r-- | 5.1 KB |
uhci-hcd.c | -rw-r--r-- | 25.3 KB |
uhci-hcd.h | -rw-r--r-- | 20.9 KB |
uhci-hub.c | -rw-r--r-- | 11.1 KB |
uhci-pci.c | -rw-r--r-- | 8.3 KB |
uhci-platform.c | -rw-r--r-- | 3.8 KB |
uhci-q.c | -rw-r--r-- | 46.2 KB |
xhci-dbg.c | -rw-r--r-- | 17.3 KB |
xhci-ext-caps.h | -rw-r--r-- | 5.3 KB |
xhci-hub.c | -rw-r--r-- | 35.5 KB |
xhci-mem.c | -rw-r--r-- | 75.2 KB |
xhci-mvebu.c | -rw-r--r-- | 1.8 KB |
xhci-mvebu.h | -rw-r--r-- | 583 bytes |
xhci-pci.c | -rw-r--r-- | 10.7 KB |
xhci-plat.c | -rw-r--r-- | 6.4 KB |
xhci-rcar.c | -rw-r--r-- | 4.2 KB |
xhci-rcar.h | -rw-r--r-- | 632 bytes |
xhci-ring.c | -rw-r--r-- | 121.5 KB |
xhci-trace.c | -rw-r--r-- | 435 bytes |
xhci-trace.h | -rw-r--r-- | 3.8 KB |
xhci.c | -rw-r--r-- | 148.1 KB |
xhci.h | -rw-r--r-- | 64.3 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...