Skip to main content

Browse the archive

Revision 6d09bb627d2470299dfb1af0e6d27fb4aece9196 authored by Trond Myklebust on 04 June 2006, 09:51:37 UTC, committed by Linus Torvalds on 05 June 2006, 19:29:16 UTC 
[PATCH] fs/namei.c: Call to file_permission() under a spinlock in do_lookup_path()
 
From: Trond Myklebust <Trond.Myklebust@netapp.com>

We're presently running lock_kernel() under fs_lock via nfs's ->permission
handler.  That's a ranking bug and sometimes a sleep-in-spinlock bug.  This
problem was introduced in the openat() patchset.

We should not need to hold the current->fs->lock for a codepath that doesn't
use current->fs.

[vsu@altlinux.ru: fix error path]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Al Viro <viro@ftp.linux.org.uk>
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent c7d2d28
History
File Mode Size
Makefile -rw-r--r-- 119 bytes
bin.c -rw-r--r-- 4.3 KB
dir.c -rw-r--r-- 11.2 KB
file.c -rw-r--r-- 14.0 KB
group.c -rw-r--r-- 1.7 KB
inode.c -rw-r--r-- 5.9 KB
mount.c -rw-r--r-- 2.4 KB
symlink.c -rw-r--r-- 3.9 KB
sysfs.h -rw-r--r-- 2.9 KB
back to top