Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 11:00:25 UTC
Revision 6ddd9769db4fc11a98bd7e58be1764e47fdb8384 authored by Emily Deng on 28 August 2018, 12:52:40 UTC, committed by Alex Deucher on 28 August 2018, 17:42:48 UTC 
drm/amdgpu: Need to set moved to true when evict bo
 
Fix the VMC page fault when the running sequence is as below:
1.amdgpu_gem_create_ioctl
2.ttm_bo_swapout->amdgpu_vm_bo_invalidate, as not called
amdgpu_vm_bo_base_init, so won't called
list_add_tail(&base->bo_list, &bo->va). Even the bo was evicted,
it won't set the bo_base->moved.
3.drm_gem_open_ioctl->amdgpu_vm_bo_base_init, here only called
list_move_tail(&base->vm_status, &vm->evicted), but not set the
bo_base->moved.
4.amdgpu_vm_bo_map->amdgpu_vm_bo_insert_map, as the bo_base->moved is
not set true, the function amdgpu_vm_bo_insert_map will call
list_move(&bo_va->base.vm_status, &vm->moved)
5.amdgpu_cs_ioctl won't validate the swapout bo, as it is only in the
moved list, not in the evict list. So VMC page fault occurs.

Signed-off-by: Emily Deng <Emily.Deng@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 2f4e7db
History
Tip revision: 6ddd9769db4fc11a98bd7e58be1764e47fdb8384 authored by Emily Deng on 28 August 2018, 12:52:40 UTC
drm/amdgpu: Need to set moved to true when evict bo
Tip revision: 6ddd976
File Mode Size
draw_functrace.py -rwxr-xr-x 3.5 KB
ftrace-bisect.sh -rwxr-xr-x 3.1 KB
back to top