Revision - 6e37c93 - fix(ngcc): support alternate UMD layout when adding new imports [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

19 April 2024, 08:24:33 UTC

Revision 6e37c938e29b2ab5c45ce391c775e5a83ac07b36 authored by George Kalpakas on 23 October 2021, 09:41:42 UTC, committed by Jessica Janiuk on 25 October 2021, 17:56:26 UTC

fix(ngcc): support alternate UMD layout when adding new imports (#43931)

In #43879, `UmdReflectionHost` was updated to deal with the new UMD
format used by Rollup, where the parenthesis is around the wrapper
function and not the wrapper function call.
For reference, this caused failures in the `ngcc-validation` repo
([example 1][1], [example 2][2]).

This commit updates `UmdRenderingFormatter` to also handle both UMD
formats. In order to validate the change, this commit also updates the
`UmdRenderingFormatter` tests to run against both UMD formats.

[1]: https://circleci.com/gh/angular/ngcc-validation/65916
[2]: https://circleci.com/gh/angular/ngcc-validation/65758

PR Close #43931

1 parent 786f02b

Files
Changes

Permalinks

Tip revision: 6e37c938e29b2ab5c45ce391c775e5a83ac07b36 authored by George Kalpakas on 23 October 2021, 09:41:42 UTC
fix(ngcc): support alternate UMD layout when adding new imports (#43931)

Tip revision: 6e37c93

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
aio
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	4.2 KB
.bazelrc	-rw-r--r--	6.4 KB
.bazelversion	-rw-r--r--	6 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	240 bytes
.gitignore	-rw-r--r--	797 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.prettierrc	-rw-r--r--	157 bytes
.pullapprove.yml	-rw-r--r--	46.9 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.0 KB
CHANGELOG.md	-rw-r--r--	968.7 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	15.8 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.7 KB
WORKSPACE	-rw-r--r--	2.6 KB
browser-providers.conf.js	-rw-r--r--	6.9 KB
gulpfile.js	-rw-r--r--	631 bytes
karma-js.conf.js	-rw-r--r--	7.3 KB
package.json	-rw-r--r--	8.6 KB
renovate.json	-rw-r--r--	2.3 KB
test-events.js	-rw-r--r--	259 bytes
test-main.js	-rw-r--r--	9.4 KB
tsconfig-tslint.json	-rw-r--r--	149 bytes
tslint.json	-rw-r--r--	4.9 KB
yarn.lock	-rw-r--r--	641.6 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(ngcc): support alternate UMD layout when adding new imports (#43931)

README.md