Skip to main content

Browse the archive

https://github.com/web-platform-tests/wpt
26 December 2018, 22:31:15 UTC
Revision 6e5bb4a67960776ca6514452283eed77e09edc62 authored by Makoto Shimazu on 10 April 2018, 01:23:59 UTC, committed by Philip Jägenstedt on 10 April 2018, 13:56:53 UTC 
Revert "Enable ConsumeGestureOnNavigation by default"
 
This reverts commit 2ca250d409adfa73a666daabd3ba19b94d6443a7.

Reason for revert: A leak bot complains navigation-consumes-user-activation.tentative.sub.html is leaking.
Sample build:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/17509

Original change's description:
> Enable ConsumeGestureOnNavigation by default
>
> See blink-dev thread:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kPli8ZCUeok
>
> A browser test is moved to be a tentative WPT due to this change.
>
> Bug: 772515
> Change-Id: Icf99c8c303c5055dcbcdace6ae94e3fcd1a01921
> Reviewed-on: https://chromium-review.googlesource.com/980599
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
> Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549293}

TBR=nasko@chromium.org,mustaq@chromium.org,csharrison@chromium.org,kereliuk@chromium.org

Change-Id: I0c998798d1367be61c633db76429c18ac554e4ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 772515
Reviewed-on: https://chromium-review.googlesource.com/1003437
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549363}
1 parent 0dcc6f1
Raw File
Tip revision: 6e5bb4a67960776ca6514452283eed77e09edc62 authored by Makoto Shimazu on 10 April 2018, 01:23:59 UTC
Revert "Enable ConsumeGestureOnNavigation by default"
Tip revision: 6e5bb4a
idlharness.https.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset=utf-8>
    <title>WebUSB IDL test</title>
    <link rel="help" href="https://wicg.github.io/webusb/">
    <script src=/resources/testharness.js></script>
    <script src=/resources/testharnessreport.js></script>
    <script src=/resources/WebIDLParser.js></script>
    <script src=/resources/idlharness.js></script>
    <script src=resources/fake-devices.js></script>
    <script src=resources/usb-helpers.js></script>
  </head>
  <body>
    <script>
      'use strict';

      // Object instances used by the IDL test.
      var usbDevice;
      var usbConfiguration;
      var usbInterface;
      var usbAlternateInterface;
      var usbEndpoint;
      var usbConnectionEvent;

      usb_test(async () => {
        let response = await fetch('/interfaces/webusb.idl');
        let idl_text = await response.text();
        let idl_array = new IdlArray();
        idl_array.add_idls(idl_text);

        // Untested IDL interfaces
        idl_array.add_untested_idls('interface Event {};');
        idl_array.add_untested_idls('interface EventHandler {};');
        idl_array.add_untested_idls('dictionary EventInit {};');
        idl_array.add_untested_idls('interface EventTarget {};');
        idl_array.add_untested_idls('interface Navigator {};');

        let {device} = await getFakeDevice();

        usbDevice = device;
        usbConfiguration = usbDevice.configurations[0];
        usbInterface = usbConfiguration.interfaces[0];
        usbAlternateInterface = usbInterface.alternates[0];
        usbEndpoint = usbAlternateInterface.endpoints[0];
        usbConnectionEvent =
            new USBConnectionEvent('connect', { device: usbDevice })

        idl_array.add_objects({
          Navigator: ['navigator'],
          USB: ['navigator.usb'],
          USBAlternateInterface: ['usbAlternateInterface'],
          USBConfiguration: ['usbConfiguration'],
          USBConnectionEvent: ['usbConnectionEvent'],
          USBDevice: ['usbDevice'],
          USBEndpoint: ['usbEndpoint'],
          USBInterface: ['usbInterface'],
          USBInTransferResult: ['new USBInTransferResult("ok")'],
          USBOutTransferResult: ['new USBOutTransferResult("ok")'],
          USBIsochronousInTransferResult: ['new USBIsochronousInTransferResult([])'],
          USBIsochronousOutTransferResult: ['new USBIsochronousOutTransferResult([])'],
          USBIsochronousInTransferPacket: ['new USBIsochronousInTransferPacket("ok")'],
          USBIsochronousOutTransferPacket: ['new USBIsochronousOutTransferPacket("ok")'],
        });

        idl_array.test();
      }, 'WebUSB IDL test');
    </script>
  </body>
</html>
back to top