Revision 6f1b228529ae49b0f85ab89bcdb6c365df401558 authored by Gautham Ananthakrishna on 28 October 2021, 21:36:17 UTC, committed by Linus Torvalds on 29 October 2021, 00:18:55 UTC
Encountered a race between ocfs2_test_bg_bit_allocatable() and jbd2_journal_put_journal_head() resulting in the below vmcore. PID: 106879 TASK: ffff880244ba9c00 CPU: 2 COMMAND: "loop3" Call trace: panic oops_end no_context __bad_area_nosemaphore bad_area_nosemaphore __do_page_fault do_page_fault page_fault [exception RIP: ocfs2_block_group_find_clear_bits+316] ocfs2_block_group_find_clear_bits [ocfs2] ocfs2_cluster_group_search [ocfs2] ocfs2_search_chain [ocfs2] ocfs2_claim_suballoc_bits [ocfs2] __ocfs2_claim_clusters [ocfs2] ocfs2_claim_clusters [ocfs2] ocfs2_local_alloc_slide_window [ocfs2] ocfs2_reserve_local_alloc_bits [ocfs2] ocfs2_reserve_clusters_with_limit [ocfs2] ocfs2_reserve_clusters [ocfs2] ocfs2_lock_refcount_allocators [ocfs2] ocfs2_make_clusters_writable [ocfs2] ocfs2_replace_cow [ocfs2] ocfs2_refcount_cow [ocfs2] ocfs2_file_write_iter [ocfs2] lo_rw_aio loop_queue_work kthread_worker_fn kthread ret_from_fork When ocfs2_test_bg_bit_allocatable() called bh2jh(bg_bh), the bg_bh->b_private NULL as jbd2_journal_put_journal_head() raced and released the jounal head from the buffer head. Needed to take bit lock for the bit 'BH_JournalHead' to fix this race. Link: https://lkml.kernel.org/r/1634820718-6043-1-git-send-email-gautham.ananthakrishna@oracle.com Signed-off-by: Gautham Ananthakrishna <gautham.ananthakrishna@oracle.com> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: <rajesh.sivaramasubramaniom@oracle.com> Cc: Mark Fasheh <mark@fasheh.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Changwei Ge <gechangwei@live.cn> Cc: Gang He <ghe@suse.com> Cc: Jun Piao <piaojun@huawei.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 337546e
File | Mode | Size |
---|---|---|
busses | ||
muxes | ||
dev-interface.rst | -rw-r--r-- | 8.8 KB |
dma-considerations.rst | -rw-r--r-- | 3.6 KB |
fault-codes.rst | -rw-r--r-- | 5.1 KB |
functionality.rst | -rw-r--r-- | 6.4 KB |
gpio-fault-injection.rst | -rw-r--r-- | 6.0 KB |
i2c-protocol.rst | -rw-r--r-- | 3.3 KB |
i2c-stub.rst | -rw-r--r-- | 2.3 KB |
i2c-sysfs.rst | -rw-r--r-- | 15.7 KB |
i2c-topology.rst | -rw-r--r-- | 15.8 KB |
i2c_bus.svg | -rw-r--r-- | 54.7 KB |
index.rst | -rw-r--r-- | 930 bytes |
instantiating-devices.rst | -rw-r--r-- | 10.0 KB |
old-module-parameters.rst | -rw-r--r-- | 2.2 KB |
slave-eeprom-backend.rst | -rw-r--r-- | 1005 bytes |
slave-interface.rst | -rw-r--r-- | 7.7 KB |
slave-testunit-backend.rst | -rw-r--r-- | 3.8 KB |
smbus-protocol.rst | -rw-r--r-- | 9.7 KB |
summary.rst | -rw-r--r-- | 2.6 KB |
ten-bit-addresses.rst | -rw-r--r-- | 1.6 KB |
writing-clients.rst | -rw-r--r-- | 15.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...