https://github.com/Kitware/CMake
Revision 6f5e4a53bca7ce5c15b1d030ef99bb2b3a1b0d2e authored by Brad King on 31 January 2019, 13:59:37 UTC, committed by Brad King on 31 January 2019, 15:59:25 UTC
Since commit 192a9182f8 (FindLAPACK: MKL clean up and fix for windows, 2013-10-08, v3.0.0-rc1~538^2), FindLAPACK accidentally used FindBLAS's `BLAS_` prefix for some of its check results. Since commit 5b8f69ebe9 (FindBLAS: Detect implicitly linked BLAS library, 2018-08-28, v3.13.0-rc1~150^2~2), FindBLAS stores a check result in a plain `BLAS_WORKS` variable. The typo in FindLAPACK happens to cause a collision with that name. The typo was already fixed in post-3.13 development as part of other work in commit 8b63265ea5 (FindLAPACK: Unify internal variables related to MKL, 2018-11-18). Fix the typo in the 3.13 version of FindLAPACK to avoid the collision. Otherwise it could cause FindLAPACK to incorrectly determine that a certain library combination does not work (or incrrectly that it works). Fixes: #18860
1 parent 8887ebc
Tip revision: 6f5e4a53bca7ce5c15b1d030ef99bb2b3a1b0d2e authored by Brad King on 31 January 2019, 13:59:37 UTC
FindLAPACK: Distinguish check result variable name from FindBLAS
FindLAPACK: Distinguish check result variable name from FindBLAS
Tip revision: 6f5e4a5
| File | Mode | Size |
|---|---|---|
| .github | ||
| Auxiliary | ||
| Help | ||
| Licenses | ||
| Modules | ||
| Packaging | ||
| Source | ||
| Templates | ||
| Tests | ||
| Utilities | ||
| .clang-format | -rw-r--r-- | 551 bytes |
| .clang-tidy | -rw-r--r-- | 969 bytes |
| .gitattributes | -rw-r--r-- | 1.1 KB |
| .gitignore | -rw-r--r-- | 132 bytes |
| .hooks-config | -rw-r--r-- | 418 bytes |
| CMakeCPack.cmake | -rw-r--r-- | 9.8 KB |
| CMakeCPackOptions.cmake.in | -rw-r--r-- | 12.4 KB |
| CMakeGraphVizOptions.cmake | -rw-r--r-- | 153 bytes |
| CMakeLists.txt | -rw-r--r-- | 30.7 KB |
| CMakeLogo.gif | -rw-r--r-- | 4.4 KB |
| CONTRIBUTING.rst | -rw-r--r-- | 2.9 KB |
| CTestConfig.cmake | -rw-r--r-- | 440 bytes |
| CTestCustom.cmake.in | -rw-r--r-- | 6.4 KB |
| CompileFlags.cmake | -rw-r--r-- | 3.6 KB |
| Copyright.txt | -rw-r--r-- | 5.0 KB |
| DartConfig.cmake | -rw-r--r-- | 374 bytes |
| README.rst | -rw-r--r-- | 3.1 KB |
| bootstrap | -rwxr-xr-x | 48.8 KB |
| cmake_uninstall.cmake.in | -rw-r--r-- | 790 bytes |
| configure | -rwxr-xr-x | 99 bytes |
| doxygen.config | -rw-r--r-- | 27.4 KB |
Computing file changes ...
