Skip to main content

Browse the archive

Revision 7004e454899490f16e0a2e5fd2e26f10d01ef091 authored by Andrew Kryczka on 26 April 2018, 21:33:02 UTC, committed by Facebook Github Bot on 26 April 2018, 21:43:11 UTC 
Remove block-based table assertion for non-empty filter block
 
Summary:
7a6353bd1c516fe3f7118248c77035697c5ac247 prevents empty filter blocks from being written for SST files containing range deletions only. However the assertion this PR removes is still a problem as we could be reading from a DB generated by a RocksDB build without the 7a6353bd1c516fe3f7118248c77035697c5ac247 patch. So remove the assertion. We already don't do this check when `cache_index_and_filter_blocks=false`, so it should be safe.
Closes https://github.com/facebook/rocksdb/pull/3773

Differential Revision: D7769964

Pulled By: ajkr

fbshipit-source-id: 7285762446f2cd2ccf16efd7a988a106fbb0d8d3
1 parent 63c965c
Raw File
CODE_OF_CONDUCT.md 
# Code of Conduct

Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please [read the full text](https://code.facebook.com/codeofconduct) so that you can understand what actions will and will not be tolerated.
back to top