Revision - 7030661 - sched/fair: Null terminate buffer when updating tunable_scaling - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

05 April 2024, 19:05:47 UTC

Revision 703066188f63d66cc6b9d678e5b5ef1213c5938e authored by Mel Gorman on 27 September 2021, 11:46:35 UTC, committed by Peter Zijlstra on 01 October 2021, 11:57:57 UTC

sched/fair: Null terminate buffer when updating tunable_scaling

This patch null-terminates the temporary buffer in sched_scaling_write()
so kstrtouint() does not return failure and checks the value is valid.

Before:
  $ cat /sys/kernel/debug/sched/tunable_scaling
  1
  $ echo 0 > /sys/kernel/debug/sched/tunable_scaling
  -bash: echo: write error: Invalid argument
  $ cat /sys/kernel/debug/sched/tunable_scaling
  1

After:
  $ cat /sys/kernel/debug/sched/tunable_scaling
  1
  $ echo 0 > /sys/kernel/debug/sched/tunable_scaling
  $ cat /sys/kernel/debug/sched/tunable_scaling
  0
  $ echo 3 > /sys/kernel/debug/sched/tunable_scaling
  -bash: echo: write error: Invalid argument

Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs")
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Vincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/20210927114635.GH3959@techsingularity.net

1 parent 2630cde

Files
Changes

Permalinks

Tip revision: 703066188f63d66cc6b9d678e5b5ef1213c5938e authored by Mel Gorman on 27 September 2021, 11:46:35 UTC
sched/fair: Null terminate buffer when updating tunable_scaling

Tip revision: 7030661

File	Mode	Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.clang-format	-rw-r--r--	16.6 KB
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	71 bytes
.gitattributes	-rw-r--r--	62 bytes
.gitignore	-rw-r--r--	1.9 KB
.mailmap	-rw-r--r--	19.8 KB
COPYING	-rw-r--r--	496 bytes
CREDITS	-rw-r--r--	98.6 KB
Kbuild	-rw-r--r--	1.3 KB
Kconfig	-rw-r--r--	555 bytes
MAINTAINERS	-rw-r--r--	605.7 KB
Makefile	-rw-r--r--	64.0 KB
README	-rw-r--r--	727 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

sched/fair: Null terminate buffer when updating tunable_scaling

README