Revision 710411aea6a2c74f7ca912988878d79aeffcefce authored by Andrew Kryczka on 28 July 2017, 03:16:25 UTC, committed by Facebook Github Bot on 28 July 2017, 03:28:04 UTC
Summary: Breaking commit: d12691b86fb788f0ee7180db626c4ea2445fa976 In the above commit, I moved the `TableCache` cleanup logic from `Version` destructor into `PurgeObsoleteFiles`. I missed cleaning up `TableCache` entries for the current `Version` during DB destruction. This PR adds that logic to `VersionSet` destructor. One unfortunate side effect is now we're potentially deleting `TableReader`s after `column_family_set_.reset()`, which means we can't call `BlockBasedTableReader::Close` a second time as the block cache might already be destroyed. Closes https://github.com/facebook/rocksdb/pull/2662 Differential Revision: D5515108 Pulled By: ajkr fbshipit-source-id: 2cb820e19aa813e0d258d17f76b2d7b6b7ee0b18
1 parent 3a3fb00
| File | Mode | Size |
|---|---|---|
| arcanist_util | ||
| buckifier | ||
| build_tools | ||
| cache | ||
| cmake | ||
| coverage | ||
| db | ||
| docs | ||
| env | ||
| examples | ||
| hdfs | ||
| include | ||
| java | ||
| memtable | ||
| monitoring | ||
| options | ||
| port | ||
| table | ||
| third-party | ||
| tools | ||
| util | ||
| utilities | ||
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 726 bytes |
| .travis.yml | -rw-r--r-- | 2.4 KB |
| AUTHORS | -rw-r--r-- | 247 bytes |
| CMakeLists.txt | -rw-r--r-- | 28.5 KB |
| CONTRIBUTING.md | -rw-r--r-- | 607 bytes |
| COPYING | -rw-r--r-- | 17.7 KB |
| DEFAULT_OPTIONS_HISTORY.md | -rw-r--r-- | 1.5 KB |
| DUMP_FORMAT.md | -rw-r--r-- | 763 bytes |
| HISTORY.md | -rw-r--r-- | 46.2 KB |
| INSTALL.md | -rw-r--r-- | 5.8 KB |
| LANGUAGE-BINDINGS.md | -rw-r--r-- | 712 bytes |
| LICENSE.Apache | -rw-r--r-- | 11.1 KB |
| LICENSE.leveldb | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 58.1 KB |
| README.md | -rw-r--r-- | 1.4 KB |
| ROCKSDB_LITE.md | -rw-r--r-- | 1.0 KB |
| TARGETS | -rw-r--r-- | 20.0 KB |
| USERS.md | -rw-r--r-- | 4.9 KB |
| Vagrantfile | -rw-r--r-- | 877 bytes |
| WINDOWS_PORT.md | -rw-r--r-- | 12.5 KB |
| appveyor.yml | -rw-r--r-- | 416 bytes |
| src.mk | -rw-r--r-- | 25.9 KB |
| thirdparty.inc | -rw-r--r-- | 7.8 KB |
Computing file changes ...
