Revision 712d361d59efa6349a9538f4fd9a49073f0e8127 authored by Eric Sandeen on 28 November 2017, 02:23:33 UTC, committed by Darrick J. Wong on 28 November 2017, 16:57:11 UTC
It's only used for tracepoints so it's relatively harmless, but the offset is calculated incorrectly in xfs_scrub_quota_item. qi_dqperchunk is the nr. of dquots per "chunk" which we have conveniently *cough* defined to always be 1 FSB. Therefore block_offset * qi_dqperchunk == first id in that chunk, and so offset = id / qi_dqperchunk id * dqperchunk is ... meaningless. Fixes-coverity-id: 1423965 Fixes: c2fc338c ("xfs: scrub quota information") Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
1 parent eda6bc2
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.3 KB |
Makefile | -rw-r--r-- | 285 bytes |
awacs.c | -rw-r--r-- | 31.8 KB |
awacs.h | -rw-r--r-- | 8.0 KB |
beep.c | -rw-r--r-- | 7.7 KB |
burgundy.c | -rw-r--r-- | 24.3 KB |
burgundy.h | -rw-r--r-- | 4.0 KB |
daca.c | -rw-r--r-- | 6.9 KB |
keywest.c | -rw-r--r-- | 4.3 KB |
pmac.c | -rw-r--r-- | 37.2 KB |
pmac.h | -rw-r--r-- | 5.1 KB |
powermac.c | -rw-r--r-- | 5.1 KB |
snd_ps3.c | -rw-r--r-- | 28.6 KB |
snd_ps3.h | -rw-r--r-- | 3.5 KB |
snd_ps3_reg.h | -rw-r--r-- | 33.2 KB |
tumbler.c | -rw-r--r-- | 38.3 KB |
tumbler_volume.h | -rw-r--r-- | 6.6 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...