https://github.com/torvalds/linux
Revision 713a98d90c5ea072c1bb00ef40617aee2cef2232 authored by Jason Wang on 28 June 2017, 01:51:03 UTC, committed by David S. Miller on 29 June 2017, 16:51:59 UTC
We don't hold any tx lock when trying to disable TX during reset, this
would lead a use after free since ndo_start_xmit() tries to access
the virtqueue which has already been freed. Fix this by using
netif_tx_disable() before freeing the vqs, this could make sure no tx
after vq freeing.

Reported-by: Jean-Philippe Menil <jpmenil@gmail.com>
Tested-by: Jean-Philippe Menil <jpmenil@gmail.com>
Fixes commit f600b6905015 ("virtio_net: Add XDP support")
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Robert McCabe <robert.mccabe@rockwellcollins.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent e20bd60
History
Tip revision: 713a98d90c5ea072c1bb00ef40617aee2cef2232 authored by Jason Wang on 28 June 2017, 01:51:03 UTC
virtio-net: serialize tx routine during reset
Tip revision: 713a98d

back to top