https://github.com/torvalds/linux
Revision 719df469cb51199316ae2a11c75a8046be34b899 authored by Roman Kagan on 05 May 2005, 20:55:56 UTC, committed by Greg KH on 03 June 2005, 07:04:30 UTC
On Wed, May 04, 2005 at 01:37:30PM -0700, David Brownell wrote: > On Wednesday 04 May 2005 12:19 pm, Roman Kagan wrote: > > struct urb { > > /* private, usb core and host controller only fields in the urb */ > > ... > > struct list_head urb_list; /* list pointer to all active urbs */ > > ... > > }; > > > > Is it safe to use it for driver's purposes when the driver owns the urb, > > that is, starting from the completion routine until the urb is submitted > > with usb_submit_urb()? > > Right now, it should be. Great! FWIW I've briefly tested a modified version of usbatm using the list head in struct urb instead of creating a wrapper struct, and I haven't seen any failures yet. So I tend to believe that your "should be" actually means "is" :) > > If it is, can it be guaranteed in future, e.g. > > by moving the list head into the public section of struct urb? > > In fact I'm not sure why it ever got called "private" to usbcore/hcds. > I thought the idea was that it should be like urb->status, reserved for > whoever controls the URB. OK then how about the following (essentially documentation) patch? Signed-off-by: Roman Kagan <rkagan@mail.ru> Acked-by: David Brownell <david-b@pacbell.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
1 parent 1724757
Tip revision: 719df469cb51199316ae2a11c75a8046be34b899 authored by Roman Kagan on 05 May 2005, 20:55:56 UTC
[PATCH] USB: update urb documentation
[PATCH] USB: update urb documentation
Tip revision: 719df46
File | Mode | Size |
---|---|---|
Documentation | ||
arch | ||
crypto | ||
drivers | ||
fs | ||
include | ||
init | ||
ipc | ||
kernel | ||
lib | ||
mm | ||
net | ||
scripts | ||
security | ||
sound | ||
usr | ||
COPYING | -rw-r--r-- | 18.3 KB |
CREDITS | -rw-r--r-- | 87.1 KB |
MAINTAINERS | -rw-r--r-- | 55.9 KB |
Makefile | -rw-r--r-- | 43.2 KB |
README | -rw-r--r-- | 13.6 KB |
REPORTING-BUGS | -rw-r--r-- | 2.9 KB |
Computing file changes ...