Skip to main content

Browse the archive

Revision 71f5bcb73012f38fe3499089bd5d332e07d32c40 authored by Andrew Kryczka on 23 June 2017, 02:30:39 UTC, committed by Facebook Github Bot on 23 June 2017, 02:41:50 UTC 
Introduce OnBackgroundError callback
 
Summary:
Some users want to prevent rocksdb from entering read-only mode in certain error cases. This diff gives them a callback, `OnBackgroundError`, that they can use to achieve it.

- call `OnBackgroundError` every time we consider setting `bg_error_`. Use its result to assign `bg_error_` but not to change the function's return status.
- classified calls using `BackgroundErrorReason` to give the callback some info about where the error happened
- renamed `ParanoidCheck` to something more specific so we can provide a clear `BackgroundErrorReason`
- unit tests for the most common cases: flush or compaction errors
Closes https://github.com/facebook/rocksdb/pull/2477

Differential Revision: D5300190

Pulled By: ajkr

fbshipit-source-id: a0ea4564249719b83428e3f4c6ca2c49e366e9b3
1 parent 88cd2d9
Raw File
.deprecated_arcconfig 
{
  "project_id" : "rocksdb",
  "conduit_uri" : "https://phabricator.fb.com/api/",
  "copyright_holder" : "Facebook",
  "load" : [
    "arcanist_util"
  ],
  "lint.engine" : "FacebookFbcodeLintEngine",
  "lint.engine.single.linter" : "FbcodeCppLinter",
  "unit.engine" : "FacebookFbcodeUnitTestEngine",
  "arcanist_configuration" : "FacebookArcanistConfiguration",
  "base" : "git:HEAD^, hg:.^",
  "git.default-relative-commit" : "HEAD^",
  "git:arc.feature.start.default" : "origin/master",
  "arc.feature.start.default" : "master",
  "history.immutable" : false
}
back to top