Revision 71f5bcb73012f38fe3499089bd5d332e07d32c40 authored by Andrew Kryczka on 23 June 2017, 02:30:39 UTC, committed by Facebook Github Bot on 23 June 2017, 02:41:50 UTC
Summary:
Some users want to prevent rocksdb from entering read-only mode in certain error cases. This diff gives them a callback, `OnBackgroundError`, that they can use to achieve it.

- call `OnBackgroundError` every time we consider setting `bg_error_`. Use its result to assign `bg_error_` but not to change the function's return status.
- classified calls using `BackgroundErrorReason` to give the callback some info about where the error happened
- renamed `ParanoidCheck` to something more specific so we can provide a clear `BackgroundErrorReason`
- unit tests for the most common cases: flush or compaction errors
Closes https://github.com/facebook/rocksdb/pull/2477

Differential Revision: D5300190

Pulled By: ajkr

fbshipit-source-id: a0ea4564249719b83428e3f4c6ca2c49e366e9b3
1 parent 88cd2d9
Raw File
CONTRIBUTING.md
# Contributing to RocksDB

## Contributor License Agreement ("CLA")

In order to accept your pull request, we need you to submit a CLA. You
only need to do this once, so if you've done this for another Facebook
open source project, you're good to go. If you are submitting a pull
request for the first time, just let us know that you have completed
the CLA and we can cross-check with your GitHub username.

Complete your CLA here: <https://code.facebook.com/cla>

If you prefer to sign a paper copy, we can send you a PDF.  Send us an 
e-mail or create a new github issue to request the CLA in PDF format.

## License

By contributing to RocksDB, you agree that your contributions will be
licensed under the [BSD License](LICENSE).
back to top