Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC, committed by Ingo Molnar on 26 April 2012, 11:51:31 UTC 
perf: Fix perf_event_for_each() to use sibling
 
In perf_event_for_each() we call a function on an event, and then
iterate over the siblings of the event.

However we don't call the function on the siblings, we call it
repeatedly on the original event - it seems "obvious" that we should
be calling it with sibling as the argument.

It looks like this broke in commit 75f937f24bd9 ("Fix ctx->mutex
vs counter->mutex inversion").

The only effect of the bug is that the PERF_IOC_FLAG_GROUP parameter
to the ioctls doesn't work.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1334109253-31329-1-git-send-email-michael@ellerman.id.au
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent c716ef5
History
Tip revision: 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC
perf: Fix perf_event_for_each() to use sibling
Tip revision: 724b6da
File Mode Size
Kconfig -rw-r--r-- 68 bytes
Makefile -rw-r--r-- 464 bytes
fc.c -rw-r--r-- 3.3 KB
fddi.c -rw-r--r-- 5.7 KB
garp.c -rw-r--r-- 17.7 KB
hippi.c -rw-r--r-- 5.9 KB
p8022.c -rw-r--r-- 1.9 KB
p8023.c -rw-r--r-- 1.6 KB
psnap.c -rw-r--r-- 3.5 KB
stp.c -rw-r--r-- 2.6 KB
tr.c -rw-r--r-- 15.1 KB
back to top