https://github.com/torvalds/linux
Revision 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC, committed by Ingo Molnar on 26 April 2012, 11:51:31 UTC
In perf_event_for_each() we call a function on an event, and then
iterate over the siblings of the event.
However we don't call the function on the siblings, we call it
repeatedly on the original event - it seems "obvious" that we should
be calling it with sibling as the argument.
It looks like this broke in commit 75f937f24bd9 ("Fix ctx->mutex
vs counter->mutex inversion").
The only effect of the bug is that the PERF_IOC_FLAG_GROUP parameter
to the ioctls doesn't work.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1334109253-31329-1-git-send-email-michael@ellerman.id.au
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent c716ef5
Tip revision: 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC
perf: Fix perf_event_for_each() to use sibling
perf: Fix perf_event_for_each() to use sibling
Tip revision: 724b6da
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 765 bytes |
| Makefile | -rw-r--r-- | 1.3 KB |
| bat_algo.h | -rw-r--r-- | 883 bytes |
| bat_debugfs.c | -rw-r--r-- | 8.8 KB |
| bat_debugfs.h | -rw-r--r-- | 1.0 KB |
| bat_iv_ogm.c | -rw-r--r-- | 35.4 KB |
| bat_sysfs.c | -rw-r--r-- | 17.6 KB |
| bat_sysfs.h | -rw-r--r-- | 1.4 KB |
| bitarray.c | -rw-r--r-- | 5.3 KB |
| bitarray.h | -rw-r--r-- | 1.6 KB |
| gateway_client.c | -rw-r--r-- | 17.0 KB |
| gateway_client.h | -rw-r--r-- | 1.5 KB |
| gateway_common.c | -rw-r--r-- | 4.1 KB |
| gateway_common.h | -rw-r--r-- | 1.2 KB |
| hard-interface.c | -rw-r--r-- | 16.9 KB |
| hard-interface.h | -rw-r--r-- | 2.0 KB |
| hash.c | -rw-r--r-- | 1.7 KB |
| hash.h | -rw-r--r-- | 4.4 KB |
| icmp_socket.c | -rw-r--r-- | 8.5 KB |
| icmp_socket.h | -rw-r--r-- | 1.0 KB |
| main.c | -rw-r--r-- | 6.8 KB |
| main.h | -rw-r--r-- | 7.3 KB |
| originator.c | -rw-r--r-- | 16.5 KB |
| originator.h | -rw-r--r-- | 2.7 KB |
| packet.h | -rw-r--r-- | 5.0 KB |
| ring_buffer.c | -rw-r--r-- | 1.2 KB |
| ring_buffer.h | -rw-r--r-- | 994 bytes |
| routing.c | -rw-r--r-- | 29.3 KB |
| routing.h | -rw-r--r-- | 2.2 KB |
| send.c | -rw-r--r-- | 11.4 KB |
| send.h | -rw-r--r-- | 1.3 KB |
| soft-interface.c | -rw-r--r-- | 24.3 KB |
| soft-interface.h | -rw-r--r-- | 1.3 KB |
| translation-table.c | -rw-r--r-- | 51.2 KB |
| translation-table.h | -rw-r--r-- | 2.9 KB |
| types.h | -rw-r--r-- | 10.6 KB |
| unicast.c | -rw-r--r-- | 8.8 KB |
| unicast.h | -rw-r--r-- | 1.9 KB |
| vis.c | -rw-r--r-- | 24.9 KB |
| vis.h | -rw-r--r-- | 1.3 KB |
Computing file changes ...
