Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC, committed by Ingo Molnar on 26 April 2012, 11:51:31 UTC 
perf: Fix perf_event_for_each() to use sibling
 
In perf_event_for_each() we call a function on an event, and then
iterate over the siblings of the event.

However we don't call the function on the siblings, we call it
repeatedly on the original event - it seems "obvious" that we should
be calling it with sibling as the argument.

It looks like this broke in commit 75f937f24bd9 ("Fix ctx->mutex
vs counter->mutex inversion").

The only effect of the bug is that the PERF_IOC_FLAG_GROUP parameter
to the ioctls doesn't work.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1334109253-31329-1-git-send-email-michael@ellerman.id.au
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent c716ef5
History
Tip revision: 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC
perf: Fix perf_event_for_each() to use sibling
Tip revision: 724b6da
File Mode Size
ircomm
irlan
irnet
Kconfig -rw-r--r-- 3.3 KB
Makefile -rw-r--r-- 503 bytes
af_irda.c -rw-r--r-- 67.4 KB
discovery.c -rw-r--r-- 12.5 KB
irda_device.c -rw-r--r-- 8.0 KB
iriap.c -rw-r--r-- 26.4 KB
iriap_event.c -rw-r--r-- 12.5 KB
irias_object.c -rw-r--r-- 13.4 KB
irlap.c -rw-r--r-- 33.7 KB
irlap_event.c -rw-r--r-- 65.0 KB
irlap_frame.c -rw-r--r-- 35.9 KB
irlmp.c -rw-r--r-- 54.3 KB
irlmp_event.c -rw-r--r-- 26.0 KB
irlmp_frame.c -rw-r--r-- 14.0 KB
irmod.c -rw-r--r-- 5.4 KB
irnetlink.c -rw-r--r-- 3.2 KB
irproc.c -rw-r--r-- 2.5 KB
irqueue.c -rw-r--r-- 22.7 KB
irsysctl.c -rw-r--r-- 7.1 KB
irttp.c -rw-r--r-- 50.6 KB
parameters.c -rw-r--r-- 15.4 KB
qos.c -rw-r--r-- 22.4 KB
timer.c -rw-r--r-- 6.3 KB
wrapper.c -rw-r--r-- 13.0 KB
back to top