https://github.com/torvalds/linux
Revision 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC, committed by Ingo Molnar on 26 April 2012, 11:51:31 UTC
In perf_event_for_each() we call a function on an event, and then
iterate over the siblings of the event.

However we don't call the function on the siblings, we call it
repeatedly on the original event - it seems "obvious" that we should
be calling it with sibling as the argument.

It looks like this broke in commit 75f937f24bd9 ("Fix ctx->mutex
vs counter->mutex inversion").

The only effect of the bug is that the PERF_IOC_FLAG_GROUP parameter
to the ioctls doesn't work.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1334109253-31329-1-git-send-email-michael@ellerman.id.au
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent c716ef5
History
Tip revision: 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC
perf: Fix perf_event_for_each() to use sibling
Tip revision: 724b6da
File Mode Size
Kconfig -rw-r--r-- 248 bytes
Makefile -rw-r--r-- 992 bytes
af_llc.c -rw-r--r-- 31.1 KB
llc_c_ac.c -rw-r--r-- 35.4 KB
llc_c_ev.c -rw-r--r-- 21.3 KB
llc_c_st.c -rw-r--r-- 149.8 KB
llc_conn.c -rw-r--r-- 27.2 KB
llc_core.c -rw-r--r-- 4.2 KB
llc_if.c -rw-r--r-- 4.4 KB
llc_input.c -rw-r--r-- 5.5 KB
llc_output.c -rw-r--r-- 2.4 KB
llc_pdu.c -rw-r--r-- 10.6 KB
llc_proc.c -rw-r--r-- 6.6 KB
llc_s_ac.c -rw-r--r-- 5.9 KB
llc_s_ev.c -rw-r--r-- 3.5 KB
llc_s_st.c -rw-r--r-- 5.7 KB
llc_sap.c -rw-r--r-- 11.4 KB
llc_station.c -rw-r--r-- 20.7 KB
sysctl_net_llc.c -rw-r--r-- 2.0 KB

back to top