https://github.com/torvalds/linux
Revision 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC, committed by Ingo Molnar on 26 April 2012, 11:51:31 UTC
In perf_event_for_each() we call a function on an event, and then
iterate over the siblings of the event.

However we don't call the function on the siblings, we call it
repeatedly on the original event - it seems "obvious" that we should
be calling it with sibling as the argument.

It looks like this broke in commit 75f937f24bd9 ("Fix ctx->mutex
vs counter->mutex inversion").

The only effect of the bug is that the PERF_IOC_FLAG_GROUP parameter
to the ioctls doesn't work.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1334109253-31329-1-git-send-email-michael@ellerman.id.au
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent c716ef5
History
Tip revision: 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC
perf: Fix perf_event_for_each() to use sibling
Tip revision: 724b6da
File Mode Size
Makefile -rw-r--r-- 254 bytes
af_rose.c -rw-r--r-- 37.7 KB
rose_dev.c -rw-r--r-- 3.6 KB
rose_in.c -rw-r--r-- 7.5 KB
rose_link.c -rw-r--r-- 6.8 KB
rose_loopback.c -rw-r--r-- 2.7 KB
rose_out.c -rw-r--r-- 2.8 KB
rose_route.c -rw-r--r-- 31.3 KB
rose_subr.c -rw-r--r-- 12.3 KB
rose_timer.c -rw-r--r-- 4.9 KB
sysctl_net_rose.c -rw-r--r-- 3.3 KB

back to top