Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC, committed by Ingo Molnar on 26 April 2012, 11:51:31 UTC 
perf: Fix perf_event_for_each() to use sibling
 
In perf_event_for_each() we call a function on an event, and then
iterate over the siblings of the event.

However we don't call the function on the siblings, we call it
repeatedly on the original event - it seems "obvious" that we should
be calling it with sibling as the argument.

It looks like this broke in commit 75f937f24bd9 ("Fix ctx->mutex
vs counter->mutex inversion").

The only effect of the bug is that the PERF_IOC_FLAG_GROUP parameter
to the ioctls doesn't work.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1334109253-31329-1-git-send-email-michael@ellerman.id.au
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent c716ef5
History
Tip revision: 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC
perf: Fix perf_event_for_each() to use sibling
Tip revision: 724b6da
File Mode Size
Kconfig -rw-r--r-- 1.0 KB
Makefile -rw-r--r-- 420 bytes
af_rxrpc.c -rw-r--r-- 20.5 KB
ar-accept.c -rw-r--r-- 12.2 KB
ar-ack.c -rw-r--r-- 32.5 KB
ar-call.c -rw-r--r-- 21.2 KB
ar-connection.c -rw-r--r-- 22.9 KB
ar-connevent.c -rw-r--r-- 9.0 KB
ar-error.c -rw-r--r-- 5.8 KB
ar-input.c -rw-r--r-- 20.0 KB
ar-internal.h -rw-r--r-- 27.6 KB
ar-key.c -rw-r--r-- 28.3 KB
ar-local.c -rw-r--r-- 7.5 KB
ar-output.c -rw-r--r-- 18.0 KB
ar-peer.c -rw-r--r-- 7.2 KB
ar-proc.c -rw-r--r-- 5.0 KB
ar-recvmsg.c -rw-r--r-- 10.8 KB
ar-security.c -rw-r--r-- 5.6 KB
ar-skbuff.c -rw-r--r-- 3.4 KB
ar-transport.c -rw-r--r-- 7.1 KB
rxkad.c -rw-r--r-- 27.3 KB
back to top