https://github.com/torvalds/linux
Revision 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC, committed by Ingo Molnar on 26 April 2012, 11:51:31 UTC
In perf_event_for_each() we call a function on an event, and then
iterate over the siblings of the event.
However we don't call the function on the siblings, we call it
repeatedly on the original event - it seems "obvious" that we should
be calling it with sibling as the argument.
It looks like this broke in commit 75f937f24bd9 ("Fix ctx->mutex
vs counter->mutex inversion").
The only effect of the bug is that the PERF_IOC_FLAG_GROUP parameter
to the ioctls doesn't work.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1334109253-31329-1-git-send-email-michael@ellerman.id.au
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent c716ef5
Tip revision: 724b6daa13e100067c30cfc4d1ad06629609dc4e authored by Michael Ellerman on 11 April 2012, 01:54:13 UTC
perf: Fix perf_event_for_each() to use sibling
perf: Fix perf_event_for_each() to use sibling
Tip revision: 724b6da
| File | Mode | Size |
|---|---|---|
| .gitignore | -rw-r--r-- | 8 bytes |
| Kconfig | -rw-r--r-- | 4.2 KB |
| Makefile | -rw-r--r-- | 858 bytes |
| chan.c | -rw-r--r-- | 3.2 KB |
| core.c | -rw-r--r-- | 26.2 KB |
| core.h | -rw-r--r-- | 14.9 KB |
| db.txt | -rw-r--r-- | 759 bytes |
| debugfs.c | -rw-r--r-- | 3.0 KB |
| debugfs.h | -rw-r--r-- | 300 bytes |
| ethtool.c | -rw-r--r-- | 2.1 KB |
| ethtool.h | -rw-r--r-- | 148 bytes |
| genregdb.awk | -rw-r--r-- | 3.4 KB |
| ibss.c | -rw-r--r-- | 11.9 KB |
| lib80211.c | -rw-r--r-- | 7.1 KB |
| lib80211_crypt_ccmp.c | -rw-r--r-- | 11.8 KB |
| lib80211_crypt_tkip.c | -rw-r--r-- | 20.7 KB |
| lib80211_crypt_wep.c | -rw-r--r-- | 7.1 KB |
| mesh.c | -rw-r--r-- | 4.4 KB |
| mlme.c | -rw-r--r-- | 25.5 KB |
| nl80211.c | -rw-r--r-- | 209.9 KB |
| nl80211.h | -rw-r--r-- | 5.2 KB |
| radiotap.c | -rw-r--r-- | 11.3 KB |
| reg.c | -rw-r--r-- | 62.1 KB |
| reg.h | -rw-r--r-- | 4.4 KB |
| regdb.h | -rw-r--r-- | 948 bytes |
| scan.c | -rw-r--r-- | 33.3 KB |
| sme.c | -rw-r--r-- | 26.3 KB |
| sysfs.c | -rw-r--r-- | 3.4 KB |
| sysfs.h | -rw-r--r-- | 197 bytes |
| util.c | -rw-r--r-- | 26.0 KB |
| wext-compat.c | -rw-r--r-- | 38.8 KB |
| wext-compat.h | -rw-r--r-- | 2.1 KB |
| wext-core.c | -rw-r--r-- | 28.9 KB |
| wext-priv.c | -rw-r--r-- | 6.9 KB |
| wext-proc.c | -rw-r--r-- | 4.0 KB |
| wext-sme.c | -rw-r--r-- | 9.2 KB |
| wext-spy.c | -rw-r--r-- | 6.6 KB |
Computing file changes ...
