Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 729d70f5dfd663b44bca68a4479c96bde7e535d6 authored by Jan Blunck on 27 August 2005, 18:07:52 UTC, committed by Linus Torvalds on 27 August 2005, 18:22:27 UTC 
[PATCH] sg.c: fix a memory leak in devices seq_file implementation
 
I know that scsi procfs is legacy code but this is a fix for a memory leak.

While reading through sg.c I realized that the implementation of
/proc/scsi/sg/devices with seq_file is leaking memory due to freeing the
pointer returned by the next() iterator method.  Since next() might return
NULL or an error this is wrong.  This patch fixes it through using the
seq_files private field for holding the reference to the iterator object.

Here is a small bash script to trigger the leak. Use slabtop to watch
the size-32 usage grow and grow.

#!/bin/sh

while true; do
	cat /proc/scsi/sg/devices > /dev/null
done

Signed-off-by: Jan Blunck <j.blunck@tu-harburg.de>
Acked-by: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent 8126fdb
History
Tip revision: 729d70f5dfd663b44bca68a4479c96bde7e535d6 authored by Jan Blunck on 27 August 2005, 18:07:52 UTC
[PATCH] sg.c: fix a memory leak in devices seq_file implementation
Tip revision: 729d70f
File Mode Size
Documentation
arch
crypto
drivers
fs
include
init
ipc
kernel
lib
mm
net
scripts
security
sound
usr
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 87.2 KB
MAINTAINERS -rw-r--r-- 57.5 KB
Makefile -rw-r--r-- 43.4 KB
README -rw-r--r-- 14.2 KB
REPORTING-BUGS -rw-r--r-- 3.0 KB

README

back to top