https://github.com/torvalds/linux
Revision 72f9a07b6bfaefdc29fcb75dafa8867a4f6d8317 authored by Eric Biggers on 08 December 2017, 15:13:29 UTC, committed by David Howells on 08 December 2017, 15:13:29 UTC
In public_key_verify_signature(), if akcipher_request_alloc() fails, we return -ENOMEM. But that error code was set 25 lines above, and by accident someone could easily insert new code in between that assigns to 'ret', which would introduce a signature verification bypass. Make the code clearer by moving the -ENOMEM down to where it is used. Additionally, the callers of public_key_verify_signature() only consider a negative return value to be an error. This means that if any positive return value is accidentally introduced deeper in the call stack (e.g. 'return EBADMSG' instead of 'return -EBADMSG' somewhere in RSA), signature verification will be bypassed. Make things more robust by having public_key_verify_signature() warn about positive errors and translate them into -EINVAL. Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: David Howells <dhowells@redhat.com>
1 parent a80745a
Tip revision: 72f9a07b6bfaefdc29fcb75dafa8867a4f6d8317 authored by Eric Biggers on 08 December 2017, 15:13:29 UTC
KEYS: be careful with error codes in public_key_verify_signature()
KEYS: be careful with error codes in public_key_verify_signature()
Tip revision: 72f9a07
| File | Mode | Size |
|---|---|---|
| ABI | ||
| EDID | ||
| PCI | ||
| RCU | ||
| accounting | ||
| acpi | ||
| admin-guide | ||
| aoe | ||
| arm | ||
| arm64 | ||
| auxdisplay | ||
| backlight | ||
| blackfin | ||
| block | ||
| blockdev | ||
| bpf | ||
| bus-devices | ||
| cdrom | ||
| cgroup-v1 | ||
| cma | ||
| connector | ||
| console | ||
| core-api | ||
| cpu-freq | ||
| cpuidle | ||
| cris | ||
| crypto | ||
| dev-tools | ||
| device-mapper | ||
| devicetree | ||
| doc-guide | ||
| driver-api | ||
| driver-model | ||
| early-userspace | ||
| extcon | ||
| fault-injection | ||
| fb | ||
| features | ||
| filesystems | ||
| firmware_class | ||
| fmc | ||
| fpga | ||
| frv | ||
| gpio | ||
| gpu | ||
| hid | ||
| hwmon | ||
| i2c | ||
| ia64 | ||
| ide | ||
| iio | ||
| infiniband | ||
| input | ||
| ioctl | ||
| isdn | ||
| kbuild | ||
| kdump | ||
| kernel-hacking | ||
| laptops | ||
| leds | ||
| lightnvm | ||
| livepatch | ||
| locking | ||
| m68k | ||
| md | ||
| media | ||
| memory-devices | ||
| metag | ||
| mic | ||
| mips | ||
| misc-devices | ||
| mmc | ||
| mn10300 | ||
| mtd | ||
| namespaces | ||
| netlabel | ||
| networking | ||
| nfc | ||
| nios2 | ||
| nvdimm | ||
| nvmem | ||
| openrisc | ||
| parisc | ||
| pcmcia | ||
| perf | ||
| phy | ||
| platform | ||
| power | ||
| powerpc | ||
| pps | ||
| process | ||
| pti | ||
| ptp | ||
| rapidio | ||
| s390 | ||
| scheduler | ||
| scsi | ||
| security | ||
| serial | ||
| sh | ||
| sound | ||
| sparc | ||
| sphinx | ||
| sphinx-static | ||
| spi | ||
| sysctl | ||
| target | ||
| thermal | ||
| timers | ||
| trace | ||
| translations | ||
| usb | ||
| userspace-api | ||
| virtual | ||
| vm | ||
| w1 | ||
| watchdog | ||
| wimax | ||
| x86 | ||
| xtensa | ||
| .gitignore | -rw-r--r-- | 13 bytes |
| 00-INDEX | -rw-r--r-- | 14.9 KB |
| Changes | l--------- | 19 bytes |
| CodingStyle | -rw-r--r-- | 48 bytes |
| DMA-API-HOWTO.txt | -rw-r--r-- | 34.1 KB |
| DMA-API.txt | -rw-r--r-- | 27.6 KB |
| DMA-ISA-LPC.txt | -rw-r--r-- | 5.1 KB |
| DMA-attributes.txt | -rw-r--r-- | 6.9 KB |
| IPMI.txt | -rw-r--r-- | 29.7 KB |
| IRQ-affinity.txt | -rw-r--r-- | 2.5 KB |
| IRQ-domain.txt | -rw-r--r-- | 12.9 KB |
| IRQ.txt | -rw-r--r-- | 994 bytes |
| Intel-IOMMU.txt | -rw-r--r-- | 3.9 KB |
| Makefile | -rw-r--r-- | 4.5 KB |
| SAK.txt | -rw-r--r-- | 3.0 KB |
| SM501.txt | -rw-r--r-- | 2.8 KB |
| SubmittingPatches | -rw-r--r-- | 54 bytes |
| atomic_bitops.txt | -rw-r--r-- | 1.3 KB |
| atomic_t.txt | -rw-r--r-- | 5.5 KB |
| bcache.txt | -rw-r--r-- | 23.7 KB |
| bt8xxgpio.txt | -rw-r--r-- | 4.0 KB |
| btmrvl.txt | -rw-r--r-- | 2.7 KB |
| bus-virt-phys-mapping.txt | -rw-r--r-- | 8.0 KB |
| cachetlb.txt | -rw-r--r-- | 17.2 KB |
| cgroup-v2.txt | -rw-r--r-- | 70.0 KB |
| circular-buffers.txt | -rw-r--r-- | 8.2 KB |
| clearing-warn-once.txt | -rw-r--r-- | 224 bytes |
| clk.txt | -rw-r--r-- | 11.6 KB |
| conf.py | -rw-r--r-- | 19.1 KB |
| cpu-load.txt | -rw-r--r-- | 3.0 KB |
| cputopology.txt | -rw-r--r-- | 5.6 KB |
| crc32.txt | -rw-r--r-- | 8.6 KB |
| dcdbas.txt | -rw-r--r-- | 3.9 KB |
| debugging-modules.txt | -rw-r--r-- | 954 bytes |
| debugging-via-ohci1394.txt | -rw-r--r-- | 7.5 KB |
| dell_rbu.txt | -rw-r--r-- | 5.1 KB |
| digsig.txt | -rw-r--r-- | 3.0 KB |
| docutils.conf | -rw-r--r-- | 158 bytes |
| dontdiff | -rw-r--r-- | 2.5 KB |
| efi-stub.txt | -rw-r--r-- | 3.3 KB |
| eisa.txt | -rw-r--r-- | 7.6 KB |
| errseq.rst | -rw-r--r-- | 6.2 KB |
| flexible-arrays.txt | -rw-r--r-- | 5.6 KB |
| futex-requeue-pi.txt | -rw-r--r-- | 5.1 KB |
| gcc-plugins.txt | -rw-r--r-- | 2.9 KB |
| highuid.txt | -rw-r--r-- | 2.6 KB |
| hw_random.txt | -rw-r--r-- | 3.8 KB |
| hwspinlock.txt | -rw-r--r-- | 12.5 KB |
| index.rst | -rw-r--r-- | 2.7 KB |
| intel_txt.txt | -rw-r--r-- | 10.3 KB |
| io-mapping.txt | -rw-r--r-- | 3.3 KB |
| io_ordering.txt | -rw-r--r-- | 2.0 KB |
| iostats.txt | -rw-r--r-- | 8.1 KB |
| irqflags-tracing.txt | -rw-r--r-- | 2.3 KB |
| isa.txt | -rw-r--r-- | 5.1 KB |
| isapnp.txt | -rw-r--r-- | 492 bytes |
| kernel-doc-nano-HOWTO.txt | -rw-r--r-- | 10.3 KB |
| kernel-per-CPU-kthreads.txt | -rw-r--r-- | 13.3 KB |
| kobject.txt | -rw-r--r-- | 18.3 KB |
| kprobes.txt | -rw-r--r-- | 29.4 KB |
| kref.txt | -rw-r--r-- | 8.9 KB |
| ldm.txt | -rw-r--r-- | 4.6 KB |
| lockup-watchdogs.txt | -rw-r--r-- | 4.1 KB |
| logo.gif | -rw-r--r-- | 16.0 KB |
| logo.txt | -rw-r--r-- | 563 bytes |
| lsm.txt | -rw-r--r-- | 10.5 KB |
| lzo.txt | -rw-r--r-- | 7.9 KB |
| mailbox.txt | -rw-r--r-- | 4.4 KB |
| memory-barriers.txt | -rw-r--r-- | 112.9 KB |
| memory-hotplug.txt | -rw-r--r-- | 18.6 KB |
| men-chameleon-bus.txt | -rw-r--r-- | 5.7 KB |
| nommu-mmap.txt | -rw-r--r-- | 12.4 KB |
| ntb.txt | -rw-r--r-- | 10.8 KB |
| numastat.txt | -rw-r--r-- | 1.0 KB |
| padata.txt | -rw-r--r-- | 7.4 KB |
| parport-lowlevel.txt | -rw-r--r-- | 37.1 KB |
| percpu-rw-semaphore.txt | -rw-r--r-- | 1.1 KB |
| phy.txt | -rw-r--r-- | 7.8 KB |
| pi-futex.txt | -rw-r--r-- | 5.7 KB |
| pnp.txt | -rw-r--r-- | 7.0 KB |
| preempt-locking.txt | -rw-r--r-- | 5.6 KB |
| printk-formats.txt | -rw-r--r-- | 13.4 KB |
| pwm.txt | -rw-r--r-- | 6.2 KB |
| rbtree.txt | -rw-r--r-- | 14.8 KB |
| remoteproc.txt | -rw-r--r-- | 12.6 KB |
| rfkill.txt | -rw-r--r-- | 5.0 KB |
| robust-futex-ABI.txt | -rw-r--r-- | 8.7 KB |
| robust-futexes.txt | -rw-r--r-- | 9.5 KB |
| rpmsg.txt | -rw-r--r-- | 13.1 KB |
| rtc.txt | -rw-r--r-- | 10.6 KB |
| sgi-ioc4.txt | -rw-r--r-- | 2.1 KB |
| siphash.txt | -rw-r--r-- | 6.3 KB |
| smsc_ece1099.txt | -rw-r--r-- | 2.5 KB |
| static-keys.txt | -rw-r--r-- | 13.0 KB |
| svga.txt | -rw-r--r-- | 11.8 KB |
| switchtec.txt | -rw-r--r-- | 3.6 KB |
| sync_file.txt | -rw-r--r-- | 3.1 KB |
| tee.txt | -rw-r--r-- | 5.2 KB |
| this_cpu_ops.txt | -rw-r--r-- | 11.2 KB |
| unaligned-memory-access.txt | -rw-r--r-- | 10.4 KB |
| vfio-mediated-device.txt | -rw-r--r-- | 14.3 KB |
| vfio.txt | -rw-r--r-- | 21.3 KB |
| video-output.txt | -rw-r--r-- | 1.1 KB |
| xillybus.txt | -rw-r--r-- | 17.6 KB |
| xz.txt | -rw-r--r-- | 5.5 KB |
| zorro.txt | -rw-r--r-- | 2.9 KB |
Computing file changes ...
