sort by:
Revision Author Date Message Commit Date
731890e [ntuple] Implement incremental merging This fixes the test case with TBufferMerger. 10 April 2024, 07:58:02 UTC
5e6ba2a [ntuple] Simplify RNTupleMerger::CollectColumns Take an RNTupleDescriptor directly and check columns iff the map is not empty. 10 April 2024, 07:58:02 UTC
f1ab845 [ntuple] Add RPageSink::GetDescriptor() 10 April 2024, 07:58:02 UTC
d21642b [ntuple] Add RPageSink::IsInitialized() Keep track if Init() was called, and throw an error if it is called again. Requires renaming the current Init() method to InitImpl(). 10 April 2024, 07:58:02 UTC
97e57ea [ci] Fetch exactly the PR base sha for clang-format Fixes #15107 10 April 2024, 06:41:36 UTC
7a39d4e Byte swap values read from the protobuf raw data stream on big endian 09 April 2024, 23:41:19 UTC
a561a9f [TMVA] Avoid xgboost-cppyy symbol clashing problem in tmva101_Training XGBoost has to be imported before ROOT to avoid crashes because of clashing std::regexp symbols that are exported by cppyy. See also: https://github.com/wlav/cppyy/issues/227 09 April 2024, 23:14:54 UTC
a4c1482 [TMVA] Disable `rbdt` test Disabled because RBDT doesn't support the imbalanced tree structure of XGBoost models. 09 April 2024, 23:14:54 UTC
53ef28b [TMVA] Fix failing `rbdt_xgboost` test * avoid warnings with opened file that is not closed * don't assume the number of features is in the `_features_count` attribute (that one doesn't exist with xgboost 2.0) * support the `"reg:squarederror"` target, which is the default regression target in xgboost 2.0 09 April 2024, 23:14:54 UTC
27cdc65 [CI] Add `xgboost` and `scikit-learn` to requirements This should be added so we can test RBDT in the CI. 09 April 2024, 23:14:54 UTC
e3aecd6 [PyROOT][RDF] Support conversion of `bool` columns to NumPy arrays The `bool` columns in RDF are special, because the Take action returns a `std::vector<bool>`, which has an implementation-depended memory layout for space optimization. Therefore, I suggest supporting taking `bool` columns as `unsigned char` with `Take()`, such that in `RDataFrameAsNumpy` the values can be directly taken as bytes. This avoids superfluous copying in the code, and keeps the special logic in the pythonization side minimal. Closes #8639. 09 April 2024, 21:06:09 UTC
9093985 [core] 1 missing Undo revert Classdef version Fixes https://its.cern.ch/jira/browse/ROOT-7408 09 April 2024, 16:21:08 UTC
74c9a26 [core] TChain::AddFile clarify that no check is done if nentries>0 * [skip-ci] TChain::AddFile clarify that no check is done if nentries>0 Fixes https://its.cern.ch/jira/browse/ROOT-8129 * [skip-ci] clarify case * [skip-ci] minor fixes by vepadulano, thanks! Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> --------- Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> 09 April 2024, 09:27:30 UTC
99a2f8a Supefluous EnableThreadSafety() `class RBatchGenerator` depends to Internal namespace and EnableThreadSafety() is called in _batchgenerator.py making another call for it redundant 09 April 2024, 07:35:44 UTC
0f2bb47 [tree,io] prevent integer overflow when dealing with cachesize Fixes https://github.com/root-project/root/issues/9292 08 April 2024, 20:41:56 UTC
0f3645e fix file exclusion in format checker 08 April 2024, 19:50:00 UTC
9d695bf [ntuple] style fix in unit test LinkDef 08 April 2024, 19:50:00 UTC
5895545 [tmva] Adapt test to class layout changes 08 April 2024, 15:49:58 UTC
1357a25 [tmva][NFC] Apply clang-format to changed files 08 April 2024, 15:49:58 UTC
28d2f43 [tmva] Cleanup RModel classes layout * Apply rule of five * Use correct `ClassDef` macro only when necessary * Remove relationship to `TObject` from `RModel_Base` * Properly implement virtual hierarchy for `RModel_GNNBase` and derived 08 April 2024, 15:49:58 UTC
ffd0e9f [ntuple] use RTypedDeleter in RField<TObject> 08 April 2024, 13:56:32 UTC
aeafd27 [ntuple] simplify RField<TObject> constructor 08 April 2024, 13:56:32 UTC
afbc84e [ntuple] optimizations to RField<TObject> implementation 08 April 2024, 13:56:32 UTC
abb18cc [ntuple] split TObject unit test into smaller bits 08 April 2024, 13:56:32 UTC
bd5b701 [NFC][ntuple] add clarifying comment 08 April 2024, 13:56:32 UTC
e27553d [NFC][ntuple] add clarifying comment 08 April 2024, 13:56:32 UTC
646d4d4 [ntuple] minor improvement in unit test dictionaries 08 April 2024, 13:56:32 UTC
6aa5f51 [ntuple] remove RField<TObject>::GetClass() 08 April 2024, 13:56:32 UTC
4d00a50 [ntuple] add unit test for TObject inheritance 08 April 2024, 13:56:32 UTC
0a56b24 [ntuple] fix-up unit test for TClass::CanSplit check 08 April 2024, 13:56:32 UTC
dfecfa9 [ntuple] add clarifying comment to unit test 08 April 2024, 13:56:32 UTC
b0aee5f [ntuple] Fix typo in error message Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> 08 April 2024, 13:56:32 UTC
1e1bf77 [ntuple] prevent handling of TObject through RClassField 08 April 2024, 13:56:32 UTC
bf967e6 [ntuple] add unit test for TObject derived class 08 April 2024, 13:56:32 UTC
bd6c8a7 [ntuple] improve RField<TObject>::GetOffsetOfMember() 08 April 2024, 13:56:32 UTC
a4beec8 [ntuple] more efficient RField<TObject>::GetClass() 08 April 2024, 13:56:32 UTC
c2860c9 [ntuple] improve check for TObject class version 08 April 2024, 13:56:32 UTC
93efbd5 [ntuple] improve error message Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> 08 April 2024, 13:56:32 UTC
f66a792 [ntuple] remove unnecessary RTObjectField intermediate class 08 April 2024, 13:56:32 UTC
d21cedf [ntuple] specialize RField for TObject Implement special treatment for fBits. Disable RNTuple I/O for referenced objects. 08 April 2024, 13:56:32 UTC
aa1e0d7 [tmva][sofie] Fix issues with RModel streamer * remove wrong multiplication of type size in `CastPersistentToShared` * restructure `InitializeTensor` to only provide read-only accessors * avoid memory leak of persistified data when reading back from file * reset `fSize` member in `CastSharedToPersistent` to avoid wrong size info when persistifying the same model twice (otherwise, the multiplication with the element size in bytes would happen twice, resulting in overruns when copying the transient data) Extends on #15162. 08 April 2024, 11:13:57 UTC
ab82426 [hist] add bounds and overflow checking See https://root-forum.cern.ch/t/tprincipal-fails-for-a-very-large-number-of-entries/58795 08 April 2024, 07:23:42 UTC
7ea9f99 [skip-ci,hist] improve doc wrt covariance matrix format 08 April 2024, 07:23:42 UTC
764ea81 [CMake] Check Python 3.8 requirement already in `find_package(Python3)` We should put the Python version check at the right place. Right now, the configuration logs tell you that ROOT requires Python 3.0, because there is no minimum version yet, which can be misleading. 08 April 2024, 07:15:27 UTC
37d8dfb [CMake] Don't mention C++17 requirement for `root7` and `webgui` flags ROOT requires C++17 anyway, so this is redundant and can be confusing. 08 April 2024, 07:15:27 UTC
926043c [hist] Use virtual THnBase::CreateIter to generalize Fixes https://github.com/root-project/root/issues/13962 08 April 2024, 01:51:56 UTC
2f55bd9 [core] allow also normal shared libraries without the ACLiC suffix with a main function equal to the shared library name as suggested by pcanal [core] mention user shared lib alternative 08 April 2024, 01:28:12 UTC
422a731 [cling] Allow running named macro from shared library As it was the case with CINT and was documented in users guide. See https://root-forum.cern.ch/t/cannot-run-shared-object-in-batch-mode/58213 Fixes https://github.com/root-project/root/issues/14772 [core] document run-shared-object behavior [core] only handle special sharedLibrary when running, not when loading 08 April 2024, 01:28:12 UTC
d44fa9e [core] Replace sprintf with snprintf which is more secure. 07 April 2024, 11:22:45 UTC
0992621 [CMake] Remove `builtin_libafterimage` option The option was deprecated in ROOT 6.32 and should be removed for the next release, as anticipated by the deprecation warnings in 6.32. 05 April 2024, 19:30:13 UTC
11accb8 Remove the deprecated Pythia 6 interface The Pythia 6 interface was deprecated in ROOT 6.30 and scheduled for removal in 6.32. As we are now in the 6.32 development cycle, everything related to `pythia6` can be removed. 05 April 2024, 15:23:53 UTC
e26d574 [CMake] Fix ordering problem when checking and setting `cuda` flag In the ROOT build system, `CheckCompiler` is included before `RootBuildOptions`. The problem with this is that when building with `-Dall=ON`, the `cuda` flag is only set in `RootBuildOptions`, which is too late to find the CUDA compiler in `CheckCompiler`. This results in issues like #15139: ``` CMake Error in roofit/batchcompute/CMakeLists.txt: Exporting the target "RooBatchCompute_CUDA" is not allowed since its linker language cannot be determined ``` This commit suggests a solution to this problem: just always enable the CUDA language in CMake if it is found, and only set the `cuda` flag with `-Dall=ON` if the CUDA language is enabled. 05 April 2024, 15:20:59 UTC
f409a6f [pyroot] Use raw string to allow escaped character in docstring To avoid warnings such as `_rvec.py:95: SyntaxWarning: invalid escape sequence '\p'` 05 April 2024, 14:08:21 UTC
0bbd8d0 [CMake] CMake dependency on Python: use targets Closes #6753. 05 April 2024, 11:48:40 UTC
ee9e3f9 [core] Silence 6.34 deprecation warnings for now We are currently discussing what the next ROOT release version number will be, and if we want to remove the deprecated methods now. To avoid the annoying warnings, change the check to 6.33.02; *if* we release a development release later this year, it would likely be called 6.33.01 or 6.33.02. Afterwards master would be bumped to 6.33.03 and we would again be reminded to remove the methods. 05 April 2024, 10:21:40 UTC
09f9a43 [gui] Do not reset FitPanel params when ADD on top of prefit function Fixes https://github.com/root-project/root/issues/11021 05 April 2024, 00:20:39 UTC
e32e317 [io] do not use single-file-merge shortcut if filters are specified Fixes https://github.com/root-project/root/issues/13359 05 April 2024, 00:16:21 UTC
0f5eb94 [math] Clarify meaning of TFoam::GetIntNorm parameters Fixes https://github.com/root-project/root/issues/14528 04 April 2024, 23:58:01 UTC
af0e1ab [core] only return core as shared lib for doxygen documentation purposes 04 April 2024, 20:54:39 UTC
1cda2a8 [core] add more detailed tests for GetClassSharedLibs [core] test also for TFile RIO 04 April 2024, 20:54:39 UTC
587ae6a [core] Do not skip libCore when finding what library the class belongs Fixes https://github.com/root-project/root/issues/11667 Bug introduced in commit from 2019 Jun 2nd 04 April 2024, 20:54:39 UTC
ff3a9cb [hist] Add test for TSpline precision when saved as macro. 04 April 2024, 20:23:55 UTC
ec5aeef [hist] Improve precision of TSpline SaveAs Fixes https://github.com/root-project/root/issues/12091 04 April 2024, 20:23:55 UTC
062bba9 [PyROOT] Disable automatic conversion of regular to smart pointers The automatic conversion of ordinary obejcts to smart pointers is disabled for PyROOT because it can cause trouble with overload resolution. If a function has overloads for both ordinary objects and smart pointers, then the implicit conversion to smart pointers can result in the smart pointer overload being hit, even though there would be an overload for the regular object. Since PyROOT didn't have this feature before 6.32 anyway, disabling it was the safest option. Closes #15117. 04 April 2024, 15:15:21 UTC
8dd71ea [hist] prevent nullptr access 04 April 2024, 09:57:28 UTC
89f9d95 [skip-ci] cross-reference markdown docu with link as well as human-readable as requested by pcanal 04 April 2024, 08:29:34 UTC
b9ba3da [skip-ci] [io] Collapse data format details of TFile class. Supersedes https://github.com/root-project/root/pull/9616 04 April 2024, 08:29:34 UTC
bf656cd [ci] Add scheduled builds for 6.32 04 April 2024, 08:03:58 UTC
0e8e845 Update ROOT version file 04 April 2024, 06:43:44 UTC
7784644 [hist] fix similar bug in TSpline5_saveas 03 April 2024, 20:07:33 UTC
05eec86 [hist] fix bug in TSpline3 save-as code Fixes https://github.com/root-project/root/issues/13441 03 April 2024, 20:07:33 UTC
71c812a Require only one template argument for usage Defaulting the rest to the first in case functions are used where argument types are not deduced, e.g. in RDataFrames 03 April 2024, 19:43:29 UTC
5c6f43a Replace static_asserts with gtest macros 03 April 2024, 19:43:29 UTC
2efaa3e Add basic tests for InvariantMass functionality 03 April 2024, 19:43:29 UTC
750d66a Add basic tests for DeltaR 03 April 2024, 19:43:29 UTC
8d9ae94 Add basic tests for DeltaPhi 03 April 2024, 19:43:29 UTC
5a744c3 Make inv mass calculations accept different floating point types 03 April 2024, 19:43:29 UTC
37c9476 Allow to use DeltaR with different floating point types 03 April 2024, 19:43:29 UTC
4200741 Make DeltaPhi work with different floating point types 03 April 2024, 19:43:29 UTC
0facd4a [CI][windows] Disable failing tests on Jenkins 03 April 2024, 15:30:43 UTC
3b8a908 [cmake][windows] Don't install system DLLs (#15114) * [cmake][windows] Don't install system DLLs Fix Jira issue ROOT-10926 https://its.cern.ch/jira/browse/ROOT-10926 * [skip-ci] Update cmake/modules/RootCPack.cmake Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com> --------- Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com> 03 April 2024, 14:59:02 UTC
6e67978 [skip-ci][ci] Skip matrix overrides in case of workflow_dispatch events, which is what is triggered when releasing. 03 April 2024, 10:00:33 UTC
8d2ce49 [minuit2] make letter case consistent 03 April 2024, 07:54:33 UTC
bea7e2d [PyROOT] Remove `PyzCppHelpers` Most of these helpers were single-use, so it's better to inline them in the implementations. 03 April 2024, 07:48:47 UTC
c85ae33 [PyROOT] Fix infinite loop in `TMemoryRegulator::ClearProxiedObjects()` There is an infinite loop in `PyROOT::TMemoryRegulator::ClearProxiedObjects()`: ```C++ while (!fObjectMap.empty()) { auto elem = fObjectMap.begin(); auto cppobj = elem->first; auto klassid = elem->second; auto pyclass = CreateScopeProxy(klassid); auto pyobj = (CPPInstance *)MemoryRegulator::RetrievePyObject(cppobj, pyclass); if (pyobj && (pyobj->fFlags & CPPInstance::kIsOwner)) { ... } else { // Non-owning proxy, just unregister to clean tables. // The proxy deletion by Python will have no effect on C++, so all good MemoryRegulator::UnregisterPyObject(pyobj, pyclass); } } ``` In the second code branch, the object is not removed from the `fObjMap`, if `UnregisterPyObject` doesn't call the unregister hook because it quits early. This can happen if there is not C++ object corresponding to the regulated python object, causing an infinite loop because `fObjectMap` never gets empty. Although this seems like an obvious logic error, this was only noticed after the cppyy upgrade. Probably the code path was not hit before. Addresses https://github.com/root-project/root/issues/15085#issuecomment-2031363812. 03 April 2024, 07:48:47 UTC
1c67cd3 [skip-ci,math] Specify that returned weight is not normalized Fixes https://github.com/root-project/root/issues/14765 03 April 2024, 05:07:57 UTC
845a003 implement missing IsInside() (#15074) * implement missing IsInside() * Add missing `<CR>`s * clang format * More clang format * Final adjustment 02 April 2024, 15:20:32 UTC
ef6b35e [ntuple] fix CyclicCollectionProxy inheritance (tests) Co-authored-by: Jonas Hahnfeld <hahnjo@hahnjo.de> 02 April 2024, 13:32:43 UTC
41701b1 [NFC][ntuple] fix typo in code comment Co-authored-by: Jonas Hahnfeld <hahnjo@hahnjo.de> 02 April 2024, 13:32:43 UTC
f102515 [ntuple] fix detection of cyclic collection proxies 02 April 2024, 13:32:43 UTC
9950a44 [llvm-project] Bump to tag ROOT-llvm16-20240402-01 02 April 2024, 11:11:39 UTC
07021ea [clang] Reuse ContextRAII for ContextAndScopeRAII 02 April 2024, 11:11:39 UTC
b702391 [clang] Correctly RAII reset two "new" Sema fields FunctionScopesStart and InventedParameterInfosStart were introduced by upstream commit https://github.com/llvm/llvm-project/commit/5c845c1c50ac89a6f12557d1571678f3d1432478 and are handled in ContextRAII, but not our ContextAndScopeRAII. 02 April 2024, 11:11:39 UTC
8227e95 [RF] Fixup work around deleted move constructor in `std::span` backport This is a followup to #15089, where I missed a second change. Closes #15087. 01 April 2024, 12:07:40 UTC
62a7ea3 [df] Correctly clone AsNumpyResult in distributed execution 28 March 2024, 23:06:59 UTC
1edca86 [df] Enable cloning of AsNumpyResult 28 March 2024, 23:06:59 UTC
dcebd46 [RF] Work around deleted move constructor in `std::span` backport Closes #15087. 28 March 2024, 16:51:10 UTC
a27e60a [RF] Improve parameter management in `RooEvaluatorWrapper` Only register actual observables as value servers in the `RooEvaluatorWrapper` this avoids that spurious variables appear in user code, which were only meant to be used internally by the new CPU evaluation backend. To make the management of the parameter easier, impose the new reasonable constraint that when resetting the data via `setData()`, the new dataset needs to have the same structure as the old one. It was confirmed with an ATLAS model provided by Will that this commit is fixing the problem of spurious variables. 28 March 2024, 16:49:58 UTC
f4f6467 [PyROOT] Replace `TDirectory.__getattr__` with `__getitem__` The new recommended way to get objects from a `TFile` or any `TDirectory` in general is now via `__getitem__`: ```python tree = my_file["my_tree"] # instead of my_file.my_tree ``` This is more consistent with other Python collections (like dictionaries), makes sure that member functions can't be confused with branch names, and easily allows you to use string variables as keys. The old pythonization with the `__getattr__` syntax still works, but emits a deprecation warning and will be removed from ROOT 6.34. 28 March 2024, 16:48:54 UTC
211d1e5 [tree] Add regression test for writing long strings 28 March 2024, 15:22:05 UTC
back to top