Revision - 7333b5a - KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp() - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

05 April 2024, 19:05:47 UTC

Revision 7333b5aca412d6ad02667b5a513485838a91b136 authored by Laurent Vivier on 12 December 2017, 17:23:56 UTC, committed by Michael Ellerman on 22 December 2017, 04:36:24 UTC

KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp()

When we migrate a VM from a POWER8 host (XICS) to a POWER9 host
(XICS-on-XIVE), we have an error:

qemu-kvm: Unable to restore KVM interrupt controller state \
          (0xff000000) for CPU 0: Invalid argument

This is because kvmppc_xics_set_icp() checks the new state
is internaly consistent, and especially:

...
   1129         if (xisr == 0) {
   1130                 if (pending_pri != 0xff)
   1131                         return -EINVAL;
...

On the other side, kvmppc_xive_get_icp() doesn't set
neither the pending_pri value, nor the xisr value (set to 0)
(and kvmppc_xive_set_icp() ignores the pending_pri value)

As xisr is 0, pending_pri must be set to 0xff.

Fixes: 5af50993850a ("KVM: PPC: Book3S HV: Native usage of the XIVE interrupt controller")
Cc: stable@vger.kernel.org # v4.12+
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

1 parent dc1c416

Files
Changes

Permalinks

Tip revision: 7333b5aca412d6ad02667b5a513485838a91b136 authored by Laurent Vivier on 12 December 2017, 17:23:56 UTC
KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp()

Tip revision: 7333b5a

File	Mode	Size
Documentation
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	31 bytes
.gitattributes	-rw-r--r--	30 bytes
.gitignore	-rw-r--r--	1.4 KB
.mailmap	-rw-r--r--	8.8 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	96.2 KB
Kbuild	-rw-r--r--	2.2 KB
Kconfig	-rw-r--r--	287 bytes
MAINTAINERS	-rw-r--r--	425.8 KB
Makefile	-rw-r--r--	58.3 KB
README	-rw-r--r--	722 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp()

README