Revision 73863ab028579ed98c4f1f36d016536b1b415344 authored by Anton Vorontsov on 31 May 2012, 23:26:23 UTC, committed by Linus Torvalds on 01 June 2012, 00:49:29 UTC
Current CPU hotplug code has some task->mm handling issues:

1. Working with task->mm w/o getting mm or grabing the task lock is
   dangerous as ->mm might disappear (exit_mm() assigns NULL under
   task_lock(), so tasklist lock is not enough).

   We can't use get_task_mm()/mmput() pair as mmput() might sleep,
   so we must take the task lock while handle its mm.

2. Checking for process->mm is not enough because process' main
   thread may exit or detach its mm via use_mm(), but other threads
   may still have a valid mm.

   To fix this we would need to use find_lock_task_mm(), which would
   walk up all threads and returns an appropriate task (with task
   lock held).

clear_tasks_mm_cpumask() has all the issues fixed, so let's use it.

Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 3eaa73b
History
File Mode Size
amcc
caam
nx
ux500
Kconfig -rw-r--r-- 9.5 KB
Makefile -rw-r--r-- 801 bytes
geode-aes.c -rw-r--r-- 14.0 KB
geode-aes.h -rw-r--r-- 1.6 KB
hifn_795x.c -rw-r--r-- 76.7 KB
ixp4xx_crypto.c -rw-r--r-- 36.8 KB
mv_cesa.c -rw-r--r-- 27.6 KB
mv_cesa.h -rw-r--r-- 3.8 KB
n2_asm.S -rw-r--r-- 1.7 KB
n2_core.c -rw-r--r-- 52.6 KB
n2_core.h -rw-r--r-- 6.1 KB
omap-aes.c -rw-r--r-- 22.5 KB
omap-sham.c -rw-r--r-- 31.1 KB
padlock-aes.c -rw-r--r-- 15.2 KB
padlock-sha.c -rw-r--r-- 15.9 KB
picoxcell_crypto.c -rw-r--r-- 53.1 KB
picoxcell_crypto_regs.h -rw-r--r-- 5.1 KB
s5p-sss.c -rw-r--r-- 17.7 KB
talitos.c -rw-r--r-- 79.0 KB
talitos.h -rw-r--r-- 10.2 KB
tegra-aes.c -rw-r--r-- 27.3 KB
tegra-aes.h -rw-r--r-- 4.2 KB

back to top