Revision 73863ab028579ed98c4f1f36d016536b1b415344 authored by Anton Vorontsov on 31 May 2012, 23:26:23 UTC, committed by Linus Torvalds on 01 June 2012, 00:49:29 UTC
Current CPU hotplug code has some task->mm handling issues:

1. Working with task->mm w/o getting mm or grabing the task lock is
   dangerous as ->mm might disappear (exit_mm() assigns NULL under
   task_lock(), so tasklist lock is not enough).

   We can't use get_task_mm()/mmput() pair as mmput() might sleep,
   so we must take the task lock while handle its mm.

2. Checking for process->mm is not enough because process' main
   thread may exit or detach its mm via use_mm(), but other threads
   may still have a valid mm.

   To fix this we would need to use find_lock_task_mm(), which would
   walk up all threads and returns an appropriate task (with task
   lock held).

clear_tasks_mm_cpumask() has all the issues fixed, so let's use it.

Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 3eaa73b
History
File Mode Size
i1480
Kconfig -rw-r--r-- 2.5 KB
Makefile -rw-r--r-- 448 bytes
address.c -rw-r--r-- 10.1 KB
allocator.c -rw-r--r-- 9.9 KB
beacon.c -rw-r--r-- 16.2 KB
driver.c -rw-r--r-- 3.8 KB
drp-avail.c -rw-r--r-- 8.6 KB
drp-ie.c -rw-r--r-- 9.5 KB
drp.c -rw-r--r-- 24.1 KB
est.c -rw-r--r-- 13.4 KB
hwa-rc.c -rw-r--r-- 27.7 KB
ie-rcv.c -rw-r--r-- 1.6 KB
ie.c -rw-r--r-- 9.6 KB
lc-dev.c -rw-r--r-- 12.8 KB
lc-rc.c -rw-r--r-- 10.9 KB
neh.c -rw-r--r-- 17.8 KB
pal.c -rw-r--r-- 2.3 KB
radio.c -rw-r--r-- 4.6 KB
reset.c -rw-r--r-- 11.0 KB
rsv.c -rw-r--r-- 26.9 KB
scan.c -rw-r--r-- 4.1 KB
umc-bus.c -rw-r--r-- 5.5 KB
umc-dev.c -rw-r--r-- 2.2 KB
umc-drv.c -rw-r--r-- 845 bytes
uwb-debug.c -rw-r--r-- 9.4 KB
uwb-internal.h -rw-r--r-- 11.1 KB
uwbd.c -rw-r--r-- 10.2 KB
whc-rc.c -rw-r--r-- 13.2 KB
whci.c -rw-r--r-- 6.5 KB

back to top