Revision 73863ab028579ed98c4f1f36d016536b1b415344 authored by Anton Vorontsov on 31 May 2012, 23:26:23 UTC, committed by Linus Torvalds on 01 June 2012, 00:49:29 UTC
Current CPU hotplug code has some task->mm handling issues:

1. Working with task->mm w/o getting mm or grabing the task lock is
   dangerous as ->mm might disappear (exit_mm() assigns NULL under
   task_lock(), so tasklist lock is not enough).

   We can't use get_task_mm()/mmput() pair as mmput() might sleep,
   so we must take the task lock while handle its mm.

2. Checking for process->mm is not enough because process' main
   thread may exit or detach its mm via use_mm(), but other threads
   may still have a valid mm.

   To fix this we would need to use find_lock_task_mm(), which would
   walk up all threads and returns an appropriate task (with task
   lock held).

clear_tasks_mm_cpumask() has all the issues fixed, so let's use it.

Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 3eaa73b
History
File Mode Size
libfdt
.gitignore -rw-r--r-- 55 bytes
Makefile -rw-r--r-- 922 bytes
Makefile.dtc -rw-r--r-- 340 bytes
checks.c -rw-r--r-- 17.8 KB
data.c -rw-r--r-- 5.8 KB
dtc-lexer.l -rw-r--r-- 4.0 KB
dtc-lexer.lex.c_shipped -rw-r--r-- 51.0 KB
dtc-parser.tab.c_shipped -rw-r--r-- 50.2 KB
dtc-parser.tab.h_shipped -rw-r--r-- 2.5 KB
dtc-parser.y -rw-r--r-- 5.8 KB
dtc.c -rw-r--r-- 6.8 KB
dtc.h -rw-r--r-- 6.6 KB
flattree.c -rw-r--r-- 21.8 KB
fstree.c -rw-r--r-- 2.2 KB
livetree.c -rw-r--r-- 11.9 KB
srcpos.c -rw-r--r-- 5.4 KB
srcpos.h -rw-r--r-- 2.8 KB
treesource.c -rw-r--r-- 5.9 KB
util.c -rw-r--r-- 1.4 KB
util.h -rw-r--r-- 1.4 KB
version_gen.h -rw-r--r-- 42 bytes

back to top