Revision - 73c6c64 - fix(core): handle multiple i18n attributes with expression [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

07 August 2024, 03:31:07 UTC

Revision 73c6c64f82d45c34203d4d18d759ad0c33a6b221 authored by Pete Bacon Darwin on 29 April 2021, 15:29:14 UTC, committed by Misko Hevery on 30 April 2021, 21:20:15 UTC

fix(core): handle multiple i18n attributes with expression bindings (#41882)

When there are multiple attributes that are marked for i18n translation,
which contain expression bindings, we were generating i18n update op-codes
that did not accurately map to the correct value to be bound in the lView.
Each attribute's bindings were relative to the start of the lView first
attributes values rather than to their own.

This fix passes the current binding index to `generateBindingUpdateOpCodes()`
when processing i18n attributes to account for this.

Fixes #41869

PR Close #41882

1 parent 36a0358

Files
Changes

Permalinks

Tip revision: 73c6c64f82d45c34203d4d18d759ad0c33a6b221 authored by Pete Bacon Darwin on 29 April 2021, 15:29:14 UTC
fix(core): handle multiple i18n attributes with expression bindings (#41882)

Tip revision: 73c6c64

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
aio
dev-infra
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	4.2 KB
.bazelrc	-rw-r--r--	6.4 KB
.bazelversion	-rw-r--r--	213 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	314 bytes
.gitignore	-rw-r--r--	843 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.pullapprove.yml	-rw-r--r--	47.2 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.0 KB
CHANGELOG.md	-rw-r--r--	869.7 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	15.5 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.7 KB
WORKSPACE	-rw-r--r--	1.9 KB
browser-providers.conf.js	-rw-r--r--	8.4 KB
gulpfile.js	-rw-r--r--	859 bytes
karma-js.conf.js	-rw-r--r--	8.0 KB
package.json	-rw-r--r--	8.5 KB
renovate.json	-rw-r--r--	2.7 KB
test-events.js	-rw-r--r--	259 bytes
test-main.js	-rw-r--r--	11.4 KB
tslint.json	-rw-r--r--	2.4 KB
yarn.lock	-rw-r--r--	609.3 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(core): handle multiple i18n attributes with expression bindings (#41882)

README.md