Revision 73d2c6678e6c3af7e7a42b1e78cd0211782ade32 authored by WANG Cong on 07 February 2017, 20:59:46 UTC, committed by David S. Miller on 08 February 2017, 18:58:21 UTC
Andrey reported a kernel crash:
general protection fault: 0000 [#1] SMP KASAN
Dumping ftrace buffer:
(ftrace buffer empty)
Modules linked in:
CPU: 2 PID: 3880 Comm: syz-executor1 Not tainted 4.10.0-rc6+ #124
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
task: ffff880060048040 task.stack: ffff880069be8000
RIP: 0010:ping_v4_push_pending_frames net/ipv4/ping.c:647 [inline]
RIP: 0010:ping_v4_sendmsg+0x1acd/0x23f0 net/ipv4/ping.c:837
RSP: 0018:ffff880069bef8b8 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff880069befb90 RCX: 0000000000000000
RDX: 0000000000000018 RSI: ffff880069befa30 RDI: 00000000000000c2
RBP: ffff880069befbb8 R08: 0000000000000008 R09: 0000000000000000
R10: 0000000000000002 R11: 0000000000000000 R12: ffff880069befab0
R13: ffff88006c624a80 R14: ffff880069befa70 R15: 0000000000000000
FS: 00007f6f7c716700(0000) GS:ffff88006de00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000004a6f28 CR3: 000000003a134000 CR4: 00000000000006e0
Call Trace:
inet_sendmsg+0x164/0x5b0 net/ipv4/af_inet.c:744
sock_sendmsg_nosec net/socket.c:635 [inline]
sock_sendmsg+0xca/0x110 net/socket.c:645
SYSC_sendto+0x660/0x810 net/socket.c:1687
SyS_sendto+0x40/0x50 net/socket.c:1655
entry_SYSCALL_64_fastpath+0x1f/0xc2
This is because we miss a check for NULL pointer for skb_peek() when
the queue is empty. Other places already have the same check.
Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 9538132
| File | Mode | Size |
|---|---|---|
| bridge | ||
| i2c | ||
| ttm | ||
| ati_pcigart.h | -rw-r--r-- | 692 bytes |
| drmP.h | -rw-r--r-- | 25.2 KB |
| drm_agpsupport.h | -rw-r--r-- | 3.8 KB |
| drm_atomic.h | -rw-r--r-- | 14.1 KB |
| drm_atomic_helper.h | -rw-r--r-- | 10.4 KB |
| drm_auth.h | -rw-r--r-- | 2.2 KB |
| drm_blend.h | -rw-r--r-- | 2.6 KB |
| drm_bridge.h | -rw-r--r-- | 7.8 KB |
| drm_cache.h | -rw-r--r-- | 1.7 KB |
| drm_color_mgmt.h | -rw-r--r-- | 2.1 KB |
| drm_connector.h | -rw-r--r-- | 28.3 KB |
| drm_crtc.h | -rw-r--r-- | 28.3 KB |
| drm_crtc_helper.h | -rw-r--r-- | 3.2 KB |
| drm_debugfs_crc.h | -rw-r--r-- | 2.6 KB |
| drm_displayid.h | -rw-r--r-- | 2.8 KB |
| drm_dp_dual_mode_helper.h | -rw-r--r-- | 4.4 KB |
| drm_dp_helper.h | -rw-r--r-- | 29.9 KB |
| drm_dp_mst_helper.h | -rw-r--r-- | 15.9 KB |
| drm_drv.h | -rw-r--r-- | 14.5 KB |
| drm_edid.h | -rw-r--r-- | 14.0 KB |
| drm_encoder.h | -rw-r--r-- | 8.0 KB |
| drm_encoder_slave.h | -rw-r--r-- | 6.4 KB |
| drm_fb_cma_helper.h | -rw-r--r-- | 1.9 KB |
| drm_fb_helper.h | -rw-r--r-- | 14.8 KB |
| drm_fixed.h | -rw-r--r-- | 4.7 KB |
| drm_flip_work.h | -rw-r--r-- | 3.0 KB |
| drm_fourcc.h | -rw-r--r-- | 2.7 KB |
| drm_framebuffer.h | -rw-r--r-- | 9.4 KB |
| drm_gem.h | -rw-r--r-- | 7.9 KB |
| drm_gem_cma_helper.h | -rw-r--r-- | 2.2 KB |
| drm_global.h | -rw-r--r-- | 2.0 KB |
| drm_hashtab.h | -rw-r--r-- | 3.1 KB |
| drm_irq.h | -rw-r--r-- | 6.2 KB |
| drm_legacy.h | -rw-r--r-- | 6.8 KB |
| drm_mem_util.h | -rw-r--r-- | 2.4 KB |
| drm_mipi_dsi.h | -rw-r--r-- | 10.1 KB |
| drm_mm.h | -rw-r--r-- | 11.2 KB |
| drm_mode_config.h | -rw-r--r-- | 23.2 KB |
| drm_mode_object.h | -rw-r--r-- | 4.8 KB |
| drm_modes.h | -rw-r--r-- | 16.7 KB |
| drm_modeset_helper.h | -rw-r--r-- | 1.5 KB |
| drm_modeset_helper_vtables.h | -rw-r--r-- | 40.2 KB |
| drm_modeset_lock.h | -rw-r--r-- | 4.1 KB |
| drm_of.h | -rw-r--r-- | 2.0 KB |
| drm_os_linux.h | -rw-r--r-- | 2.2 KB |
| drm_panel.h | -rw-r--r-- | 6.9 KB |
| drm_pciids.h | -rw-r--r-- | 66.4 KB |
| drm_plane.h | -rw-r--r-- | 19.0 KB |
| drm_plane_helper.h | -rw-r--r-- | 3.1 KB |
| drm_print.h | -rw-r--r-- | 3.2 KB |
| drm_property.h | -rw-r--r-- | 11.2 KB |
| drm_rect.h | -rw-r--r-- | 5.0 KB |
| drm_simple_kms_helper.h | -rw-r--r-- | 4.0 KB |
| drm_sysfs.h | -rw-r--r-- | 300 bytes |
| drm_vma_manager.h | -rw-r--r-- | 7.7 KB |
| gma_drm.h | -rw-r--r-- | 1.0 KB |
| i915_component.h | -rw-r--r-- | 4.1 KB |
| i915_drm.h | -rw-r--r-- | 3.5 KB |
| i915_pciids.h | -rw-r--r-- | 12.3 KB |
| intel-gtt.h | -rw-r--r-- | 941 bytes |
Computing file changes ...
