https://github.com/torvalds/linux
Revision 74030603dfd9f76c0f279f19f1dd1ee3028fee7a authored by WANG Cong on 13 June 2017, 20:36:24 UTC, committed by David S. Miller on 14 June 2017, 18:39:19 UTC
Laura reported a sleep-in-atomic kernel warning inside tcf_act_police_init() which calls gen_replace_estimator() with spinlock protection. It is not necessary in this case, we already have RTNL lock here so it is enough to protect concurrent writers. For the reader, i.e. tcf_act_police(), it needs to make decision based on this rate estimator, in the worst case we drop more/less packets than necessary while changing the rate in parallel, it is still acceptable. Reported-by: Laura Abbott <labbott@redhat.com> Reported-by: Nick Huber <nicholashuber@gmail.com> Cc: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 20a3d5b
Tip revision: 74030603dfd9f76c0f279f19f1dd1ee3028fee7a authored by WANG Cong on 13 June 2017, 20:36:24 UTC
net_sched: move tcf_lock down after gen_replace_estimator()
net_sched: move tcf_lock down after gen_replace_estimator()
Tip revision: 7403060
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| crypto | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efivarfs | ||
| efs | ||
| exofs | ||
| exportfs | ||
| ext2 | ||
| ext4 | ||
| f2fs | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| kernfs | ||
| lockd | ||
| minix | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| orangefs | ||
| overlayfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| tracefs | ||
| ubifs | ||
| udf | ||
| ufs | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 7.2 KB |
| Kconfig.binfmt | -rw-r--r-- | 7.2 KB |
| Makefile | -rw-r--r-- | 4.2 KB |
| aio.c | -rw-r--r-- | 45.9 KB |
| anon_inodes.c | -rw-r--r-- | 4.9 KB |
| attr.c | -rw-r--r-- | 9.2 KB |
| bad_inode.c | -rw-r--r-- | 5.3 KB |
| binfmt_aout.c | -rw-r--r-- | 10.8 KB |
| binfmt_elf.c | -rw-r--r-- | 61.3 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 47.0 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 27.9 KB |
| binfmt_misc.c | -rw-r--r-- | 18.3 KB |
| binfmt_script.c | -rw-r--r-- | 3.0 KB |
| block_dev.c | -rw-r--r-- | 52.9 KB |
| buffer.c | -rw-r--r-- | 91.1 KB |
| char_dev.c | -rw-r--r-- | 16.1 KB |
| compat.c | -rw-r--r-- | 5.1 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.4 KB |
| compat_ioctl.c | -rw-r--r-- | 45.8 KB |
| coredump.c | -rw-r--r-- | 21.3 KB |
| dax.c | -rw-r--r-- | 41.2 KB |
| dcache.c | -rw-r--r-- | 93.8 KB |
| dcookies.c | -rw-r--r-- | 6.9 KB |
| direct-io.c | -rw-r--r-- | 38.3 KB |
| drop_caches.c | -rw-r--r-- | 1.6 KB |
| eventfd.c | -rw-r--r-- | 12.9 KB |
| eventpoll.c | -rw-r--r-- | 62.1 KB |
| exec.c | -rw-r--r-- | 44.5 KB |
| fcntl.c | -rw-r--r-- | 20.6 KB |
| fhandle.c | -rw-r--r-- | 6.8 KB |
| file.c | -rw-r--r-- | 23.6 KB |
| file_table.c | -rw-r--r-- | 8.6 KB |
| filesystems.c | -rw-r--r-- | 6.4 KB |
| fs-writeback.c | -rw-r--r-- | 70.5 KB |
| fs_pin.c | -rw-r--r-- | 2.0 KB |
| fs_struct.c | -rw-r--r-- | 3.3 KB |
| inode.c | -rw-r--r-- | 54.9 KB |
| internal.h | -rw-r--r-- | 4.6 KB |
| ioctl.c | -rw-r--r-- | 17.3 KB |
| iomap.c | -rw-r--r-- | 22.7 KB |
| libfs.c | -rw-r--r-- | 30.5 KB |
| locks.c | -rw-r--r-- | 73.3 KB |
| mbcache.c | -rw-r--r-- | 11.9 KB |
| mount.h | -rw-r--r-- | 3.7 KB |
| mpage.c | -rw-r--r-- | 20.5 KB |
| namei.c | -rw-r--r-- | 120.9 KB |
| namespace.c | -rw-r--r-- | 85.3 KB |
| no-block.c | -rw-r--r-- | 688 bytes |
| nsfs.c | -rw-r--r-- | 5.6 KB |
| open.c | -rw-r--r-- | 28.2 KB |
| pipe.c | -rw-r--r-- | 27.3 KB |
| pnode.c | -rw-r--r-- | 12.1 KB |
| pnode.h | -rw-r--r-- | 1.9 KB |
| posix_acl.c | -rw-r--r-- | 21.4 KB |
| proc_namespace.c | -rw-r--r-- | 7.8 KB |
| read_write.c | -rw-r--r-- | 47.2 KB |
| readdir.c | -rw-r--r-- | 11.2 KB |
| select.c | -rw-r--r-- | 35.6 KB |
| seq_file.c | -rw-r--r-- | 22.7 KB |
| signalfd.c | -rw-r--r-- | 9.2 KB |
| splice.c | -rw-r--r-- | 40.0 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 19.1 KB |
| statfs.c | -rw-r--r-- | 9.7 KB |
| super.c | -rw-r--r-- | 38.9 KB |
| sync.c | -rw-r--r-- | 9.9 KB |
| timerfd.c | -rw-r--r-- | 13.4 KB |
| userfaultfd.c | -rw-r--r-- | 47.4 KB |
| utimes.c | -rw-r--r-- | 7.1 KB |
| xattr.c | -rw-r--r-- | 23.3 KB |
Computing file changes ...
