Revision - 7469be9 - xenbus: don't bail early from xenbus_dev_request_and_reply() - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

17 May 2024, 11:00:25 UTC

Revision 7469be95a487319514adce2304ad2af3553d2fc9 authored by Jan Beulich on 07 July 2016, 07:32:04 UTC, committed by David Vrabel on 08 July 2016, 10:14:26 UTC

xenbus: don't bail early from xenbus_dev_request_and_reply()

xenbus_dev_request_and_reply() needs to track whether a transaction is
open.  For XS_TRANSACTION_START messages it calls transaction_start()
and for XS_TRANSACTION_END messages it calls transaction_end().

If sending an XS_TRANSACTION_START message fails or responds with an
an error, the transaction is not open and transaction_end() must be
called.

If sending an XS_TRANSACTION_END message fails, the transaction is
still open, but if an error response is returned the transaction is
closed.

Commit 027bd7e89906 ("xen/xenbus: Avoid synchronous wait on XenBus
stalling shutdown/restart") introduced a regression where failed
XS_TRANSACTION_START messages were leaving the transaction open.  This
can cause problems with suspend (and migration) as all transactions
must be closed before suspending.

It appears that the problematic change was added accidentally, so just
remove it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>

1 parent 0beef63

Files
Changes

Permalinks

Tip revision: 7469be95a487319514adce2304ad2af3553d2fc9 authored by Jan Beulich on 07 July 2016, 07:32:04 UTC
xenbus: don't bail early from xenbus_dev_request_and_reply()

Tip revision: 7469be9

File	Mode	Size
Documentation
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.get_maintainer.ignore	-rw-r--r--	31 bytes
.gitignore	-rw-r--r--	1.2 KB
.mailmap	-rw-r--r--	6.1 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	95.5 KB
Kbuild	-rw-r--r--	2.8 KB
Kconfig	-rw-r--r--	252 bytes
MAINTAINERS	-rw-r--r--	353.7 KB
Makefile	-rw-r--r--	56.0 KB
README	-rw-r--r--	18.1 KB
REPORTING-BUGS	-rw-r--r--	7.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

xenbus: don't bail early from xenbus_dev_request_and_reply()

README