Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
74eed46 Zach Arend 14 April 2021, 21:23:38 UTC release: cut the v10.2.5 release 14 April 2021, 21:23:38 UTC
f630f33 Alex Rickabaugh 09 April 2021, 15:31:08 UTC fix(compiler-cli): show a more specific error for Ivy NgModules (#41534) (#41598) When an Ivy NgModule is imported into a View Engine build, it doesn't have metadata.json files that describe it as an NgModule, so it appears to VE builds as a plain, undecorated class. The error message shown in this situation generic and confusing, since it recommends adding an @NgModule annotation to a class from a library. This commit adds special detection into the View Engine compiler to give a more specific error message when an Ivy NgModule is imported. PR Close #41534 PR Close #41598 14 April 2021, 16:38:40 UTC
ba8da74 Misko Hevery 22 January 2021, 18:05:17 UTC fix(core): fix possible XSS attack in development through SSR (#40525) This is a follow up fix for https://github.com/angular/angular/pull/40136/commits/894286dd0c92b5af223364237e63798e18b14f58. It turns out that comments can be closed in several ways: - `<!-->` - `<!-- -->` - `<!-- --!>` All of the above are valid ways to close comment per: https://html.spec.whatwg.org/multipage/syntax.html#comments The new fix surrounds `<` and `>` with zero width space so that it renders in the same way, but it prevents the comment to be closed eagerly. PR Close #40525 18 March 2021, 17:06:02 UTC
4a11226 Joey Perrott 17 December 2020, 00:08:32 UTC release: cut the v10.2.4 release 17 December 2020, 00:08:57 UTC
90570c0 Alan Agius 15 December 2020, 10:04:47 UTC fix(core): set `ngDevMode` to `false` when calling `enableProdMode()` (#40160) The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`. https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case. PR Close #40160 16 December 2020, 22:30:41 UTC
0b8e3d5 Misko Hevery 15 December 2020, 21:00:29 UTC fix(core): fix possible XSS attack in development through SSR. (#40152) Escape the content of the strings so that it can be safely inserted into a comment node. The issue is that HTML does not specify any way to escape comment end text inside the comment. `<!-- The way you close a comment is with "-->". -->`. Above the `"-->"` is meant to be text not an end to the comment. This can be created programmatically through DOM APIs. ``` div.innerHTML = div.innerHTML ``` One would expect that the above code would be safe to do, but it turns out that because comment text is not escaped, the comment may contain text which will prematurely close the comment opening up the application for XSS attack. (In SSR we programmatically create comment nodes which may contain such text and expect them to be safe.) This function escapes the comment text by looking for the closing char sequence `-->` and replace it with `-_-_>` where the `_` is a zero width space `\u200B`. The result is that if a comment contains `-->` text it will render normally but it will not cause the HTML parser to close the comment. PR Close #40152 16 December 2020, 22:16:10 UTC
1806d6e Pete Bacon Darwin 18 November 2020, 19:41:26 UTC build: update to latest "yargs" package The 15.x versions of `yargs` relied upon a version of `y18n` that has a SNYK vulnerability. This commit updates the overall project, and therefore also the `localize` and `compiler-cli` packages to use the latest version of `yargs` that does not depend upon the vulnerable `y18n` version. The AIO project was already on the latest `yargs` version and so does not need upgrading. Fixes #39743 18 November 2020, 19:43:52 UTC
0786c59 Misko Hevery 09 November 2020, 20:46:39 UTC release: cut the v10.2.3 release 09 November 2020, 20:46:39 UTC
ae71b76 George Kalpakas 07 November 2020, 13:11:47 UTC ci: log commands output when deploying angular.io to Firebase (#39596) In #39470, the `deploy-to-firebase.sh` script (used to deploy AIO to Firebase when building an upstream branch), was replaced by an equivalent JS script. In this new `deploy-to-firebase.js` script, we were overly aggressive with suppressing command output, which made it hard to investigate failures ([example failing CI job][1]). This commit updates the `deploy-to-firebase.js` script to capture command output as usual in the CI job logs. This makes the output similar to the one generated by the old [deploy-to-firebase.sh][2] script ([example CI logs][3]). One concern with capturing command output is having the value of a secret environment variables leaked in the logs. This is not the case here, since: 1. The secret env vars are not printed from the commands that use them. 2. CircleCI will [mask the values of secret env vars][4] in the output. As an extra precaution (although not strictly necessary), we run `yarn` with the `--silent` option, which avoid echoing the executed yarn commands. [1]: https://circleci.com/gh/angular/angular/849310 [2]: https://github.com/angular/angular/blob/3b0b7d22109c79b4dceb/aio/scripts/deploy-to-firebase.sh [3]: https://circleci.com/gh/angular/angular/848109 [4]: https://circleci.com/docs/2.0/env-vars/#secrets-masking PR Close #39596 09 November 2020, 15:41:00 UTC
1357d84 George Kalpakas 05 November 2020, 16:26:14 UTC build(docs-infra): print the git commit when deploying to Firebase (#39596) The commit updates the AIO deployment script to also print the commit SHA. This makes it easier to check whether a version has been successfully deployed, by comparing the commit SHA from the CI job with the SHA in the version string in the footer of the AIO app. PR Close #39596 09 November 2020, 15:40:59 UTC
861e4fa Alex Rickabaugh 30 October 2020, 21:37:02 UTC fix(compiler-cli): avoid duplicate diagnostics about unknown pipes (#39517) TCB generation occasionally transforms binding expressions twice, which can result in a `BindingPipe` operation being `resolve()`'d multiple times. When the pipe does not exist, this caused multiple OOB diagnostics to be recorded about the missing pipe. This commit fixes the problem by making the OOB recorder track which pipe expressions have had diagnostics produced already, and only producing them once per expression. PR Close #39517 06 November 2020, 23:27:39 UTC
1c6cf8a Pete Bacon Darwin 05 November 2020, 11:01:45 UTC fix(compiler-cli): do not drop non-Angular decorators when downleveling (#39577) There is a compiler transform that downlevels Angular class decorators to static properties so that metadata is available for JIT compilation. The transform was supposed to ignore non-Angular decorators but it was actually completely dropping decorators that did not conform to a very specific syntactic shape (i.e. the decorator was a simple identifier, or a namespaced identifier). This commit ensures that all non-Angular decorators are kepts as-is even if they are built using a syntax that the Angular compiler does not understand. Fixes #39574 PR Close #39577 06 November 2020, 17:21:53 UTC
7bd0133 Athur Ming 06 November 2020, 06:57:34 UTC docs: typo fix for 'Intall' (#39585) 'Intall' should be 'Install' PR Close #39585 06 November 2020, 17:16:05 UTC
2b684b7 Pete Bacon Darwin 29 October 2020, 09:45:01 UTC fix(compiler): skipping leading whitespace should not break placeholder source-spans (#39589) Tokenized text node may have leading whitespace skipped from their source-span. But the source-span is used to compute where there are interpolated blocks, resulting in placeholder nodes whose source-spans are offset by the amount of skipped characters. This fix uses the `fullStart` location of text source-spans for computing the source-span of placeholders, so that they are accurate. Fixes #39195 PR Close #39589 06 November 2020, 17:09:48 UTC
ff31b43 Pete Bacon Darwin 28 October 2020, 21:37:24 UTC refactor(compiler): capture `fullStart` locations when tokenizing (#39589) This commit ensures that when leading whitespace is skipped by the tokenizer, the original start location (before skipping) is captured in the `fullStart` property of the token's source-span. PR Close #39589 06 November 2020, 17:09:48 UTC
1aee8b3 Pete Bacon Darwin 28 October 2020, 21:35:06 UTC refactor(compiler): store the `fullStart` location on `ParseSourceSpan`s (#39589) The lexer is able to skip leading trivia in the `start` location of tokens. This makes the source-span more friendly since things like elements appear to begin at the start of the opening tag, rather than at the start of any leading whitespace, which could include newlines. But some tooling requires the full source-span to be available, such as when tokenizing a text span into an Angular expression. This commit simply adds the `fullStart` location to the `ParseSourceSpan` class, and ensures that places where such spans are cloned, this property flows through too. PR Close #39589 06 November 2020, 17:09:48 UTC
e67a331 Pete Bacon Darwin 28 October 2020, 21:01:31 UTC fix(compiler): ensure that i18n message-parts have the correct source-span (#39589) In an i18n message, two placeholders next to each other must have an "empty" message-part to separate them. Previously, the source-span for this message-part was pointing to the wrong original location. This caused problems in the generated source-maps and lead to extracted i18n messages from being rendered incorrectly. PR Close #39589 06 November 2020, 17:09:48 UTC
08e077c George Vrettos 04 November 2020, 19:49:29 UTC docs: fix typo in the "Property Binding" guide (#39569) PR Close #39569 04 November 2020, 20:51:35 UTC
16bc0fc Joey Perrott 04 November 2020, 20:32:09 UTC release: cut the v10.2.2 release 04 November 2020, 20:32:09 UTC
8929355 Aristeidis Bampakos 04 November 2020, 11:24:25 UTC docs: fix typos in the "Attribute Binding" guide (#39562) PR Close #39562 04 November 2020, 19:42:45 UTC
7ed0f0f Joey Perrott 14 September 2020, 18:24:15 UTC fix(dev-infra): run caretaker checks asyncronously (#39086) Run each check in the caretaker check process asyncronously. PR Close #39086 04 November 2020, 00:33:00 UTC
a644aae GeopJr 23 October 2020, 13:10:10 UTC docs: fix Android 10 codename (#39399) Change Android 10's codename from "X" to "Q" PR Close #39399 04 November 2020, 00:10:57 UTC
250858a Joey Perrott 29 October 2020, 00:14:40 UTC feat(dev-infra): provide tooling to check what branches a pr targets (#39504) Create a command in the `ng-dev` toolset that allows user's to check what branches a PR will merge into based on its targeting. PR Close #39504 03 November 2020, 22:55:25 UTC
aa3bd27 Joey Perrott 03 November 2020, 17:17:51 UTC build: update dev dependency on @angular/cli to 10.2.0 (#39553) Updating the @angular/cli dependency to match the @angular-devkit/* versions. PR Close #39553 03 November 2020, 21:45:03 UTC
90b4be1 Joey Perrott 29 October 2020, 22:43:44 UTC fix(dev-infra): run fetches in the git client in quiet mode (#39503) When fetch is run in normal mode, the `git-fetch-pack` plumbing command outputs progress to stderr. Since this is unnecessary progress information for ng-dev usages, it should be suppressed instead. PR Close #39503 03 November 2020, 00:41:47 UTC
1ff68ab Joey Perrott 02 November 2020, 18:06:31 UTC ci: only check testing directories within packages/ for fw-testing (#39536) The fw-testing group should only match on testing directories within the framework packages, previously it was also matching in other areas of the codebase. PR Close #39536 03 November 2020, 00:39:45 UTC
5a21021 Pete Bacon Darwin 02 November 2020, 17:54:24 UTC build(docs-infra): ensure that deployment works on CI (#39535) The actual "main" part of the script that is executed was using an uninitialized variable. This is fixed and a test is added to check. PR Close #39535 02 November 2020, 20:24:35 UTC
f763859 Eduard Bondarenko 31 October 2020, 11:06:49 UTC docs: update forwardRef example (#39519) Replace the deprecated api ReflectiveInjector.resolveAndCreat with Injector.create PR Close #39519 02 November 2020, 19:40:17 UTC
4ca9ac0 George Kalpakas 28 October 2020, 19:51:17 UTC build(docs-infra): upgrade `firebase-tools` to v8.14.1 (#39470) This commit upgrades `firebase-tools` (used to deploy angular.io to Firebase hosting) to the latest version. This gives us access to the latest fixes/improvements and also new features, such as [version cloning][1]. [1]: https://firebase.google.com/docs/hosting/manage-hosting-resources#cli-commands-cloning PR Close #39470 02 November 2020, 15:57:53 UTC
4a2e1d6 George Kalpakas 28 October 2020, 18:51:08 UTC build(docs-infra): deploy angular.io to new Firebase sites (#39470) Previously, the documentation for each major Angular version was hosted on each own Firebase project. This required creating a new project for each major release and increased the administrative/maintenance cost. Now that Firebase supports hosting [multiple websites][1] as part of the same project, we are switching to deploying all major versions to sites created on `angular-io` project. This is part of the work needed to prepare angular.io for our [new versioning/branching process][2] (also tracked in #39366). [1]: https://firebase.google.com/docs/hosting/multisites [2]: https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU PR Close #39470 02 November 2020, 15:57:53 UTC
29ca517 George Kalpakas 28 October 2020, 10:23:58 UTC refactor(docs-infra): break up `deploy-to-firebase.js` script into functions (#39470) This commit breaks up the code in `deploy-to-firebase.js` script, that we use for deploying angular.io to production, to smaller functions (instead of a monolithic block). This makes the script easier to maintain and also makes testing individual operations easier. The commit also updates the `deploy-to-firebase.spec.js` spec file to take advantage of the standalone functions to speed up testing by calling the corresponding function instead of having to spawn a new process and run the `deploy-to-firebase.js` script with the `--dry-run` flag. NOTE: Before updating the tests, I verified that the updated `deploy-to-firebase.js` script passed the old tests. PR Close #39470 02 November 2020, 15:57:53 UTC
c601a08 George Kalpakas 28 October 2020, 10:23:57 UTC build(docs-infra): add support for RC deployments to deployment script (#39470) This commit updates the angular.io deployment script (`deploy-to-firebase.js`) to support deploying release-candidate versions. This is part of the work needed to prepare angular.io for our [new versioning/branching process][1] (also tracked in #39366). [1]: https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU PR Close #39470 02 November 2020, 15:57:53 UTC
20dd343 George Kalpakas 28 October 2020, 10:23:56 UTC build(docs-infra): add new angular.io build configuration for release-candidates (#39470) This commit adds a new build configuration/deployment mode (`rc`) for deploying release-candidate versions to angular.io. This is part of the work needed to prepare angular.io for our [new versioning/branching process][1] (also tracked in #39366). [1]: https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU PR Close #39470 02 November 2020, 15:57:52 UTC
019b631 George Kalpakas 28 October 2020, 14:17:50 UTC refactor(docs-infra): use Sass mixin to simplify the creation of deployment mode themes (#39470) Different deployment modes (such as `archive` and `next`) are identified by the different colors used in prominent elements of the page, such as the topbar and the footer. Previously, the necessary styles for creating such a deployment mode "theme" were duplicated for each mode. This commit simplifies the creation/modification of a deployment mode theme by introducing a Sass mixin that generates the necessary styles (when provided with necessary theme colors). PR Close #39470 02 November 2020, 15:57:52 UTC
e6deefd George Kalpakas 28 October 2020, 13:03:41 UTC test(docs-infra): ensure `deploy-to-firebase` tests pass locally (#39470) Previously, the `deploy-to-firebase.js` script and the accompanying `deploy-to-firebase.spec.js` spec file were using the `origin` remote alias in certain commands. This works fine on CI, where `origin` points to the `angular/angular` GitHub repo, but might not work locally. This commit ensures that the correct remote is used by explicitly specifying it by the URL, thus ensuring that the tests will behave identically on CI and locally. PR Close #39470 02 November 2020, 15:57:52 UTC
2d9b404 George Kalpakas 28 October 2020, 10:23:51 UTC build(docs-infra): switch `deploy-to-firebase.sh` script to JS (#39470) This commit switches the `deploy-to-firebase.sh` script, that we use for deploying angular.io to production, from Bash to JavaScript. This makes the script easier to maintain. For the same reasons, it also switches the `deploy-to-firebase.test.sh` script, that we use for testing the `deploy-to-firebase` script, from Bash to JavaScript (using jasmine as the test runner). Finally, this commit also updates ShellJS to the latest version to get better error messages (including the actual error) when `exec()` fails. NOTE: Before switching the test script to JS, I verified that the new `deploy-to-firebase.js` script passed the tests with the old `deploy-to-firebase.test.sh` script. PR Close #39470 02 November 2020, 15:57:52 UTC
812355c JoostK 30 October 2020, 19:31:47 UTC perf(core): do not recurse into modules that have already been registered (#39514) When registering an NgModule based on its id, all transitively imported NgModules are also registered. This commit introduces a visited set to avoid traversing into NgModules that are reachable from multiple import paths multiple times. Fixes #39487 PR Close #39514 02 November 2020, 15:51:19 UTC
71d0063 JoostK 17 October 2020, 18:27:24 UTC fix(compiler-cli): report missing pipes when `fullTemplateTypeCheck` is disabled (#39320) Even if `fullTemplateTypeCheck` is disabled should missing pipes still be reported, as was the case in View Engine. Fixes #38195 PR Close #39320 31 October 2020, 01:01:51 UTC
85d5242 Andrew Scott 27 October 2020, 03:38:28 UTC fix(router): Ensure all outlets are used when commands have a prefix (#39456) When there is a primary outlet present in the outlets map and the object is also prefixed with some other commands, the current logic only uses the primary outlet and ignores the others. This change ensures that all outlets are respected at the segment level when prefixed with other commands. PR Close #39456 30 October 2020, 23:23:04 UTC
8f36c21 Andrew Scott 27 October 2020, 02:10:16 UTC refactor(router): Small refactor of createUrlTree and extra tests (#39456) This commit has a small refactor of some methods in create_url_tree.ts and adds some test cases, including two that will fail at the moment but should pass. A follow-up commit will make use of the refactorings to fix the test with minimal changes. PR Close #39456 30 October 2020, 23:23:04 UTC
90acb91 Andrew Kushnir 29 October 2020, 20:00:32 UTC docs: tView.preOrderHooks and tView.preOrderCheckHooks docs update (#39497) This commit updates the docs for the `tView.preOrderHooks` and `tView.preOrderCheckHooks` TView fields. Current docs are not up-to-date as it was pointed out in #39439. Closes #39439. PR Close #39497 29 October 2020, 23:25:39 UTC
8c82106 JiaLiPassion 17 October 2020, 13:56:09 UTC fix(core): markDirty() should only mark flags when really scheduling tick. (#39316) Close #39296 Fix an issue that `markDirty()` will not trigger change detection. The case is for example we have the following component. ``` export class AppComponent implements OnInit { constructor(private router: Router) {} ngOnInit() { this.router.events .pipe(filter((e) => e instanceof NavigationEnd)) .subscribe(() => ɵmarkDirty(this)); } } export class CounterComponent implements OnInit, OnDestroy { ngOnInit() { this.countSubject.pipe(takeUntil(this.destroy)).subscribe((count) => { this.count = count; ɵmarkDirty(this); }); } ``` Then the app navigate from `AppComponent` to `CounterComponent`, so there are 2 `markDirty()` call at in a row. The `1st` call is from `AppComponent` when router changed, the `2nd` call is from `CounterComponent.ngOnInit()`. And the `markDirty()->scheduleTick()` code look like this ``` function scheduleTick(rootContext, flags) { const nothingScheduled = rootContext.flags === 0 /* Empty */; rootContext.flags |= flags; if (nothingScheduled && rootContext.clean == _CLEAN_PROMISE) { rootContext.schedule(() => { ... if (rootContext.flags & RootContextFlags.DetectChanges) rootContext.flags &= ~RootContextFlags.DetectChanges; tickContext(); rootContext.clean = _CLEAN_PROMISE; ... }); ``` So in this case, the `1st` markDirty() will 1. set rootContext.flags = 1 2. before `tickContext()`, reset rootContext.flags = 0 3. inside `tickContext()`, it will call `CounterComponent.ngOnint()`, so the `2nd` markDirty() is called. 4. and the `2nd` scheduleTick is called, `nothingScheduled` is true, but rootContext.clean is not `_CLEAN_PROMISE` yet, since the `1st` markDirty tick is still running. 5. So nowhere will reset the `rootContext.flags`. 6. then in the future, any other `markDirty()` call will not trigger the tick, since `nothingScheduled` is always false. So `nothingScheduled` means no tick is scheduled, `rootContext.clean === _CLEAN_PROMISE` means no tick is running. So we should set the flags to `rootContext` only when `no tick is scheudled or running`. PR Close #39316 29 October 2020, 23:07:10 UTC
fb96c3d Andrew Kushnir 29 October 2020, 18:21:39 UTC ci: update NgBot config to include more labels that indicate that ticket is triaged (#39494) This commit updates the config of NgBot to treat tickets that have "needs clarification" or "needs reproduction" labels on them as triaged. PR Close #39494 29 October 2020, 19:25:47 UTC
f9d3588 Michael Ziluck 29 October 2020, 16:59:58 UTC docs(forms): update ngModel documentation (#39481) This commit improves the ngModel docs, specifically: - clarifies purpose of the name attribute in ngModelOptions - clarifies on the interaction with a parent form or lack thereof - fix inconsistency with analogy for two-way binding - cleans up some typos and extra wordiness - clarifies language around common properties - adds missing preposition to commit message format origins PR Close #39481 29 October 2020, 18:18:55 UTC
cff61b2 Joey Perrott 28 October 2020, 17:47:22 UTC fix(dev-infra): update generated ng-dev compiled output (#39474) Update to the new ng-dev generated script. PR Close #39474 29 October 2020, 16:55:27 UTC
8dbe70f Joey Perrott 28 October 2020, 17:22:15 UTC fix(dev-infra): clean up output of `caretaker check` command (#39474) Suppress the logging of the git command executed during the caretaker check process. PR Close #39474 29 October 2020, 16:55:27 UTC
934196b Joey Perrott 28 October 2020, 17:07:48 UTC feat(dev-infra): allow suppression of `GitClient`s verbose logging (#39474) Some usages of the `GitClient` are better served by suppressing the logging of lines that express what commands are being run. Many usages of `GitClient` are contained within tools which are best served by keeping the output clean as mostly read actions are occurring. PR Close #39474 29 October 2020, 16:55:27 UTC
d48cbb0 Joey Perrott 28 October 2020, 17:20:15 UTC build: create yarn command for running local version of ng-dev (#39474) For better development experience of the dev-infra work, the `ng-dev:dev` command runs the transpiled version of `ng-dev` making iterative development easier. PR Close #39474 29 October 2020, 16:55:27 UTC
9205fce Joey Perrott 27 October 2020, 18:14:31 UTC build: bring .gitignore on patch in line with master and rc (#39457) Adds the two missing entries from .gitignore to the .gitignore file on the patch branch PR Close #39457 29 October 2020, 15:43:16 UTC
b8c71a4 Shadab Ansari 28 October 2020, 20:21:09 UTC docs: Match browser name with custom launcher name (#39480) The browser being launched needs to match the custom launcher name. Otherwise Karma would still trigger the original Chrome executable without the flags. PR Close #39480 29 October 2020, 15:39:14 UTC
6b3db15 Kapunahele Wong 21 June 2019, 19:31:19 UTC docs: move template ref vars doc to concepts section clarify, add scope section, and update headers (#31195) Fixes #31186. This commit adds more context about the behavior of template reference variables in nested templates and moves doc into concepts section. PR Close #31195 28 October 2020, 21:41:44 UTC
c918d2e David Shevitz 16 October 2020, 19:50:28 UTC docs: archive user-input topic (#39309) PR Close #39309 28 October 2020, 21:41:09 UTC
43edc1b Alex Rickabaugh 28 October 2020, 20:21:48 UTC release: cut the v10.2.1 release 28 October 2020, 20:21:48 UTC
1fbe217 Jessica Janiuk 28 October 2020, 17:05:57 UTC docs(core): add jessicajaniuk to pullapprove list (#39473) This just adds jessicajessica to the pullapprove.yml file PR Close #39473 28 October 2020, 18:14:50 UTC
d73d6df Thibaut ACKERMANN 28 October 2020, 13:35:59 UTC docs(router): Fix ActivationEnd link (#39469) ActivationEnd goes to ActivationEnd and not to ActivationStart section PR Close #39469 28 October 2020, 18:06:05 UTC
439b03c JiaLiPassion 27 October 2020, 01:29:01 UTC docs(zone.js): update release doc (#39442) In the current release doc, we are using some shortcut of `git` command such as `git ci` `git co`, so in this PR we are updating them to the normal command, so these commands will work event without these shortcuts. PR Close #39442 28 October 2020, 17:59:48 UTC
4fa12b1 Joey Perrott 26 October 2020, 16:51:29 UTC build: add PullApprove: disable as a caretaker note label (#39430) Add the label `PullApprove: disable` as a caretaker note label to prompt caretakers to confirm that the PullApprove disabling is intentional. PR Close #39430 28 October 2020, 17:59:10 UTC
c2b82cf Joey Perrott 26 October 2020, 16:47:49 UTC ci: allow for disabling PullApprove on a single PR via adding a label (#39430) Alowing for disabling PullApprove on a single PR via adding a label allows for an escape hatch if PullApprove is not acting as expected, or for cases where reviews can be stepped over in obvious situations, such as a revert. PR Close #39430 28 October 2020, 17:59:10 UTC
e3c362f Deborah Kurata 24 October 2020, 00:52:32 UTC docs: Correct a few typographical errors. (#39405) PR Close #39405 28 October 2020, 17:58:26 UTC
90e7444 Aristeidis Bampakos 23 October 2020, 13:27:29 UTC docs: update Learning Angular book edition (#39400) Update the resource Learning Angular book into the third edition PR Close #39400 28 October 2020, 17:57:42 UTC
695de31 Gustav Bylund 02 October 2020, 10:35:47 UTC docs: fix links to Material examples (#39093) Also uses fixed git hashes so the line numbers won't get outdated in the future PR Close #39093 28 October 2020, 17:53:17 UTC
02e5951 Carlos Caballero 09 October 2020, 14:50:24 UTC docs: add carlos caballero to GDE resources (#37976) PR Close #37976 28 October 2020, 17:52:34 UTC
055f7eb Joey Perrott 27 October 2020, 21:41:06 UTC ci: bust cache of stored node_modules on CircleCI (#39461) Update the cache keys used on CircleCI to bust the cache used in attempt to address issue with tests on aio that are not reproducable locally. Note: Going back to v1 as the cache version as caches are only held for 15 days so we can safely return back to `v1` as the prefix PR Close #39461 27 October 2020, 21:53:10 UTC
ea1baf9 Pete Bacon Darwin 23 October 2020, 12:32:36 UTC fix(localize): render placeholder types in extracted XLIFF files (#39459) The previous ViewEngine extraction tooling added `ctype` and `type` attributes to XLIFF 1.2 and 2.0 translation files, respectively. This commit adds this to the new $localize based extraction tooling. Since the new extraction tooling works from the compiled output rather than having direct access to the template content, the placeholder types must be inferred from the name of the placeholder. This is considered reasonable, since it already does this to compute opening and closing tag placeholders. Fixes #38791 PR Close #39459 27 October 2020, 21:32:11 UTC
ec30175 Nhan Nguyen 27 October 2020, 17:56:29 UTC docs: add install Firebase CLI step before using its commands (#39079) PR Close #39079 27 October 2020, 21:29:06 UTC
0b37249 JiaLiPassion 26 October 2020, 03:17:14 UTC docs(core): update a typo in the comment of ngZoneEventCoalescing (#39423) PR Close #39423 27 October 2020, 21:27:16 UTC
2be068d Pete Bacon Darwin 26 October 2020, 21:12:56 UTC Revert "perf(ngcc): allow immediately reporting a stale lock file (#37250)" (#39435) This reverts commit 561c0f81a0d62b84fa47a98226eeb85eda864ffd. The original commit provided a quick escape from an already terminal situation by killing the process if the PID in the lockfile was not found in the list of processes running on the current machine. But this broke use-cases where the node_modules was being shared between multiple machines (or more commonly Docker containers on the same actual machine). Fixes #38875 PR Close #39435 27 October 2020, 20:36:27 UTC
6f3f89c pmartijena 16 September 2020, 14:38:10 UTC docs: fix grammatical errors and typos (#38868) Fixed run on sentences, grammatical errors, and made "ivy" "Ivy" everywhere for consistency. PR Close #38868 27 October 2020, 20:18:02 UTC
8a084bf Alan Agius 27 October 2020, 13:22:31 UTC ci: add alan-agius4 to docs-cli in pullapprove configuration (#39448) Add alan-agius4 to `docs-cli` group in pullapprove configuration. PR Close #39448 27 October 2020, 17:49:08 UTC
b765d27 imkikus 27 October 2020, 04:23:37 UTC docs: fix more typos in component overview (#39445) PR Close #39445 27 October 2020, 17:47:35 UTC
3b779a1 AleksanderBodurri 27 October 2020, 00:18:06 UTC docs: fix typo in initializeInputAndOutputAliases docstring (#39438) PR Close #39438 27 October 2020, 17:46:37 UTC
fcebc83 JoostK 24 October 2020, 22:19:58 UTC fix(core): do not error when `ngDevMode` is undeclared (#39415) In production mode, the `ngDevMode` global may not have been declared. This is typically not a problem, as optimizers should have removed all usages of the `ngDevMode` variables. This does however require the bundler/optimizer to have been configured in a certain way, as to allow for `ngDevMode` guarded code to be removed. As an example, Terser can be configured to remove the `ngDevMode` guarded code using the following configuration: ```js const terserOptions = { // ... compress: { // ... global_defs: require('@angular/compiler-cli').GLOBAL_DEFS_FOR_TERSER, } } ``` (Taken from https://github.com/angular/angular/issues/31595#issuecomment-519129090) If this is not done, however, the bundle should still work (albeit with larger code size due to missed tree-shaking opportunities). This commit adds a check for whether `ngDevMode` has been declared, as it is a top-level statement that executes before `ngDevMode` has been initialized. Fixes #31595 PR Close #39415 27 October 2020, 17:45:19 UTC
b33956b AleksanderBodurri 30 September 2020, 08:42:01 UTC docs(forms): add section under Validators.pattern detailing use of global and sticky flags gotcha (#39055) Due to how the global and sticky flag make RegExp objects stateful, adds section detailing how it is not recommended to use these flags for control validations. PR Close #39055 27 October 2020, 17:38:49 UTC
5f205a7 Kapunahele Wong 18 September 2020, 20:43:40 UTC docs: edit event-binding doc copy and headers (#38903) PR Close #38903 27 October 2020, 17:37:30 UTC
895efe2 Jethro Lee 11 August 2020, 11:50:38 UTC docs: move placement of help note in tutorial (#38508) PR Close #38508 27 October 2020, 17:37:00 UTC
e3f8888 Joey Perrott 27 October 2020, 02:42:23 UTC fix(dev-infra): ensure hashbang is present in both published and local ng-devs (#39443) The node hash bang was incidentally removed in the published ng-dev, it should be included to allow for the command to be run without having to specify node. PR Close #39443 27 October 2020, 16:28:39 UTC
308b930 Kiran Kumaar Sathyanarayana 26 October 2020, 10:12:30 UTC docs: fix typo in component overview (#39425) Fixes #39424 PR Close #39425 26 October 2020, 17:53:06 UTC
db51de8 Pete Bacon Darwin 24 October 2020, 15:50:25 UTC fix(localize): serialize all the message locations to XLIFF (#39411) Previously only the first message, for each id, was serialized which meant that additional message location information was lost. Now all the message locations are included in the serialized messages. Fixes #39330 PR Close #39411 26 October 2020, 17:52:30 UTC
0fb50da George Kalpakas 24 October 2020, 11:07:46 UTC build(docs-infra): ignore `doc.basePath` when generating keywords for each document (#39409) The `generateKeywords` dgeni processor automatically generates keywords for each document by extracting words from each string property of a `doc` object. This commit adds `basePath` to the list of ignored properties, so that it is _not_ considered when generating keywords. `basePath` mostly contains the path to some root directory (such as `/home/circleci/ng/packages`) and as such it does not contain useful keywords. For example, searching for `circleci` will match all API docs, because it happens to be in the `basePath`: https://v10.angular.io/?search=circleci PR Close #39409 26 October 2020, 17:52:01 UTC
16bff79 Andrew Kushnir 23 October 2020, 20:09:11 UTC docs: improve DefaultValueAccessor directive docs (#39404) This commit improves the DefaultValueAccessor directive docs by: - adding the `ngDefaultControl` as a search keyword to the description - adding an example of the `ngDefaultControl` usage Closes #35375. PR Close #39404 26 October 2020, 17:50:42 UTC
c03585f Aristeidis Bampakos 20 October 2020, 16:52:01 UTC docs: use SimpleChanges in component interaction guide (#39342) Use the SimpleChanges interface in the example of component interaction guide PR Close #39342 26 October 2020, 17:47:32 UTC
c7a8352 George Kalpakas 23 October 2020, 09:32:30 UTC build(docs-infra): upgrade cli command docs sources to b5fa18881 (#39395) Updating [angular#10.2.x](https://github.com/angular/angular/tree/10.2.x) from [cli-builds#10.2.x](https://github.com/angular/cli-builds/tree/10.2.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/bfcad1d71...b5fa18881): **Modified** - help/build.json - help/generate.json - help/serve.json - help/test.json - help/update.json - help/xi18n.json ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/bfcad1d71...b5fa18881) since PR #39380: **Modified** - help/build.json - help/generate.json - help/serve.json - help/test.json - help/update.json - help/xi18n.json ## Closes #39380 PR Close #39395 23 October 2020, 22:18:43 UTC
ed88407 Joey Perrott 22 October 2020, 19:08:46 UTC fix(bazel): only providing stamping information if the --stamp flag is used (#39392) Previously the volatile status file was always provided to the ng_rollup action which prevented it from being cacheable remotely. This change to only provide this file as an input when the --stamp flag is used will allow for the action to be remotely cached and prevent needing to run the action on every CI run. PR Close #39392 23 October 2020, 22:18:15 UTC
09a4fe4 Pete Bacon Darwin 22 October 2020, 09:34:52 UTC refactor(compiler-cli): support namespaced references (#39346) The compiler uses a `Reference` abstraction to refer to TS nodes that it needs to refer to from other parts of the source. Such references keep track of any identifiers that represent the referenced node. Prior to this commit, the compiler (and specifically `ReferenceEmitter` classes) assumed that the reference identifiers are always free standing. In other words a reference identifier would be an expression like `FooDirective` in the expression `class FooDirective {}`. But in UMD/CommonJS source, a reference can actually refer to an "exports" declaration of the form `exports.FooDirective = ...`. In such cases the `FooDirective` identifier is not free-standing since it is part of a property access, so the `ReferenceEmitter` should take this into account when emitting an expression that refers to such a `Reference`. This commit changes the `LocalIdentifierStrategy` reference emitter so that if the `node` being referenced is not a declaration itself and is in the current file, then it should be used directly, rather than trying to use one of its identifiers. PR Close #39346 23 October 2020, 22:17:15 UTC
bdaa714 Pete Bacon Darwin 20 October 2020, 16:29:03 UTC fix(ngcc): capture UMD/CommonJS inner class implementation node correctly (#39346) Previously, UMD/CommonJS class inline declarations of the form: ```ts exports.Foo = (function() { function Foo(); return Foo; })(); ``` were capturing the whole IIFE as the implementation, rather than the inner class (i.e. `function Foo() {}` in this case). This caused the interpreter to break when it was trying to access such an export, since it would try to evaluate the IIFE rather than treating it as a class declaration. PR Close #39346 23 October 2020, 22:17:15 UTC
ca0c670 Krishnabisht07 22 October 2020, 12:31:08 UTC docs: template files should have `.html` extension (#39384) Fixes a typo in the component guide PR Close #39384 22 October 2020, 21:06:30 UTC
1078117 Kapunahele Wong 22 October 2020, 12:04:01 UTC docs: move hierarchical injectors to reference section (#39383) PR Close #39383 22 October 2020, 21:04:48 UTC
92368bc George Kalpakas 22 October 2020, 09:16:05 UTC build(docs-infra): upgrade cli command docs sources to bfcad1d71 (#39380) Updating [angular#10.2.x](https://github.com/angular/angular/tree/10.2.x) from [cli-builds#10.1.x](https://github.com/angular/cli-builds/tree/10.1.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/cba6d86ca...bfcad1d71): **Modified** - help/update.json PR Close #39380 22 October 2020, 20:48:56 UTC
eec5d2a AleksanderBodurri 20 October 2020, 03:50:06 UTC docs: update broken akita link in aio dev resources page (#39335) fixes #39331 PR Close #39335 22 October 2020, 20:43:55 UTC
cadb76c twerske 20 October 2020, 23:15:22 UTC refactor(core): group provider and circular errors (#39251) group together similar error messages as part of error code efforts ProviderNotFound & NodeInjector grouped into throwProviderNotFoundError Cyclic dependency errors grouped into throwCyclicDependencyError PR Close #39251 22 October 2020, 20:42:35 UTC
1146e47 ayazhafiz 05 October 2020, 04:31:22 UTC test(compiler): Demonstrate recoverable parsing of unterminated pipes (#39113) There is no actionable change in this commit other than to pretty-print EOF tokens. Actual parsing of unterminated pipes is already supported, this just adds a test for it. Part of #38596 PR Close #39113 22 October 2020, 20:41:52 UTC
38efd64 Joey Perrott 01 October 2020, 23:06:56 UTC refactor(dev-infra): create ng-dev executable locally in the repo (#39089) Rather than running ng-dev via ts-node, going forward ng-dev is generated and run locally via node. Additionally, the generated file is tested on each commit to ensure that the local generated version stays up to date. PR Close #39089 22 October 2020, 20:36:15 UTC
513ed49 Joey Perrott 20 October 2020, 21:47:13 UTC build: update bazelversion (#39351) Updates to the latest version of bazel PR Close #39351 21 October 2020, 18:59:42 UTC
61b1425 Andrew Kushnir 21 October 2020, 17:42:17 UTC release: cut the v10.2.0 release 21 October 2020, 17:42:17 UTC
71fb99f Keen Yee Liau 19 October 2020, 22:23:37 UTC fix(platform-server): Resolve absolute URL from baseUrl (#39334) This commit fixes a bug when `useAbsoluteUrl` is set to true and `ServerPlatformLocation` infers the base url from the supplied `url`. User should explicitly set the `baseUrl` when they turn on `useAbsoluteUrl`. Breaking change: If you use `useAbsoluteUrl` to setup `platform-server`, you now need to also specify `baseUrl`. We are intentionally making this a breaking change in a minor release, because if `useAbsoluteUrl` is set to `true` then the behavior of the application could be unpredictable, resulting in issues that are hard to discover but could be affecting production environments. PR Close #39334 (cherry picked from commit 7768aeb62fb6de5dd7777e713b0ceadb58366cd5) 21 October 2020, 16:46:22 UTC
7ca17a6 George Kalpakas 21 October 2020, 09:20:37 UTC build(docs-infra): upgrade cli command docs sources to cba6d86ca (#39360) Updating [angular#10.1.x](https://github.com/angular/angular/tree/10.1.x) from [cli-builds#10.1.x](https://github.com/angular/cli-builds/tree/10.1.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/ab97bc382...cba6d86ca): **Modified** - help/build.json - help/generate.json - help/test.json - help/xi18n.json PR Close #39360 21 October 2020, 15:27:13 UTC
3cce723 Arnaud Bernard 21 October 2020, 07:42:25 UTC docs: remove `style` commit type from CONTRIBUTING.md (#39357) Commit type Style is still present in Commiit Message Header while it shouldn't PR Close #39357 21 October 2020, 15:25:31 UTC
b7bf525 Kapunahele Wong 10 September 2020, 21:06:39 UTC docs: edit property binding doc (#38799) This commit edits the property binding doc copy and adds some docregions to clarify explanations. PR Close #38799 21 October 2020, 15:23:44 UTC
823200c Dave Shevitz 06 October 2020, 23:52:53 UTC docs: Add Component Overview topic to angular.io (#39186) PR Close #39186 20 October 2020, 17:47:45 UTC
cd8ec3d Jessica Janiuk 13 October 2020, 20:40:00 UTC docs: add Jessica Janiuk to contributors.json (#39253) PR Close #39253 19 October 2020, 23:25:18 UTC
back to top