Revision 757fed1d0898b893d7daa84183947c70f27632f3 authored by Wang Hai on 28 January 2021, 11:32:50 UTC, committed by Linus Torvalds on 28 January 2021, 17:05:44 UTC
This reverts commit dde3c6b72a16c2db826f54b2d49bdea26c3534a2. syzbot report a double-free bug. The following case can cause this bug. - mm/slab_common.c: create_cache(): if the __kmem_cache_create() fails, it does: out_free_cache: kmem_cache_free(kmem_cache, s); - but __kmem_cache_create() - at least for slub() - will have done sysfs_slab_add(s) -> sysfs_create_group() .. fails .. -> kobject_del(&s->kobj); .. which frees s ... We can't remove the kmem_cache_free() in create_cache(), because other error cases of __kmem_cache_create() do not free this. So, revert the commit dde3c6b72a16 ("mm/slub: fix a memory leak in sysfs_slab_add()") to fix this. Reported-by: syzbot+d0bd96b4696c1ef67991@syzkaller.appspotmail.com Fixes: dde3c6b72a16 ("mm/slub: fix a memory leak in sysfs_slab_add()") Acked-by: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Wang Hai <wanghai38@huawei.com> Cc: <stable@vger.kernel.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 76c057c
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 11.2 KB |
Makefile | -rw-r--r-- | 595 bytes |
autosleep.c | -rw-r--r-- | 2.6 KB |
console.c | -rw-r--r-- | 3.5 KB |
energy_model.c | -rw-r--r-- | 9.1 KB |
hibernate.c | -rw-r--r-- | 30.1 KB |
main.c | -rw-r--r-- | 22.5 KB |
power.h | -rw-r--r-- | 8.6 KB |
poweroff.c | -rw-r--r-- | 992 bytes |
process.c | -rw-r--r-- | 5.6 KB |
qos.c | -rw-r--r-- | 17.2 KB |
snapshot.c | -rw-r--r-- | 72.6 KB |
suspend.c | -rw-r--r-- | 15.3 KB |
suspend_test.c | -rw-r--r-- | 5.7 KB |
swap.c | -rw-r--r-- | 37.8 KB |
user.c | -rw-r--r-- | 9.4 KB |
wakelock.c | -rw-r--r-- | 5.9 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...