sort by:
Revision Author Date Message Commit Date
76b12e0 Revert removal of trigger flag from plperl function hash key. As noted by Jan Urbanski, this flag is in fact needed to ensure that the function's input/result conversion functions are set up as expected. Add a regression test to discourage anyone from making same mistake in future. 31 October 2010, 15:42:51 UTC
186cbbd Provide hashing support for arrays. The core of this patch is hash_array() and associated typcache infrastructure, which works just about exactly like the existing support for array comparison. In addition I did some work to ensure that the planner won't think that an array type is hashable unless its element type is hashable, and similarly for sorting. This includes adding a datatype parameter to op_hashjoinable and op_mergejoinable, and adding an explicit "hashable" flag to SortGroupClause. The lack of a cross-check on the element type was a pre-existing bug in mergejoin support --- but it didn't matter so much before, because if you couldn't sort the element type there wasn't any good alternative to failing anyhow. Now that we have the alternative of hashing the array type, there are cases where we can avoid a failure by being picky at the planner stage, so it's time to be picky. The issue of exactly how to combine the per-element hash values to produce an array hash is still open for discussion, but the rest of this is pretty solid, so I'll commit it as-is. 31 October 2010, 01:56:11 UTC
bd1ff97 Change version number in release notes to 9.1alpha2 30 October 2010, 20:37:36 UTC
7116568 Last-minute updates to 9.1alpha2 release notes 30 October 2010, 19:34:20 UTC
bfd3f37 Fix comparisons of pointers with zero to compare with NULL instead. Per C standard, these are semantically the same thing; but saying NULL when you mean NULL is good for readability. Marti Raudsepp, per results of INRIA's Coccinelle. 29 October 2010, 19:51:52 UTC
48a1fb2 Oops, missed one fix for EquivalenceClass rearrangement. Now that we're expecting a mergeclause's left_ec/right_ec to persist from the initial assignments, we can't just blithely zero these out when transforming such a clause in adjust_appendrel_attrs. But really it should be okay to keep the parent's values, since a child table's derived Var ought to be equivalent to the parent Var for all EquivalenceClass purposes. (Indeed, I'm wondering whether we couldn't find a way to dispense with add_child_rel_equivalences altogether. But this is wrong in any case.) 29 October 2010, 18:44:49 UTC
14231a4 Avoid creation of useless EquivalenceClasses during planning. Zoltan Boszormenyi exhibited a test case in which planning time was dominated by construction of EquivalenceClasses and PathKeys that had no actual relevance to the query (and in fact got discarded immediately). This happened because we generated PathKeys describing the sort ordering of every index on every table in the query, and only after that checked to see if the sort ordering was relevant. The EC/PK construction code is O(N^2) in the number of ECs, which is all right for the intended number of such objects, but it gets out of hand if there are ECs for lots of irrelevant indexes. To fix, twiddle the handling of mergeclauses a little bit to ensure that every interesting EC is created before we begin path generation. (This doesn't cost anything --- in fact I think it's a bit cheaper than before --- since we always eventually created those ECs anyway.) Then, if an index column can't be found in any pre-existing EC, we know that that sort ordering is irrelevant for the query. Instead of creating a useless EC, we can just not build a pathkey for the index column in the first place. The index will still be considered if it's useful for non-order-related reasons, but we will think of its output as unsorted. 29 October 2010, 15:52:50 UTC
f184de3 Give a more specific error message if you try to COMMIT, ROLLBACK or COPY FROM STDIN in PL/pgSQL. We alread did this for dynamic EXECUTE statements, ie. "EXECUTE 'COMMIT'", but not otherwise. 29 October 2010, 08:44:54 UTC
6c3c7b5 Allow generic record arguments to plperl functions 29 October 2010, 00:48:12 UTC
a3d40e9 Add tab completion for psql \dg and \z Josh Kupershmidt 28 October 2010, 20:05:28 UTC
299591d Make \? output of \dg and \du the same The previous wording might have suggested that \du only showed login roles and \dg only group roles, but that is no longer the case. proposed by Josh Kupershmidt 28 October 2010, 20:01:45 UTC
37e0a01 Save a few cycles in plpgsql simple-expression initialization. Instead of using ExecPrepareExpr, call ExecInitExpr. The net change here is that we don't apply expression_planner() to the expression tree. There is no need to do so, because that tree is extracted from a fully planned plancache entry, so all the needed work is already done. This reduces the setup costs by about a factor of 2 according to some simple tests. Oversight noted while fooling around with the simple-expression code for previous fix. 28 October 2010, 17:29:13 UTC
8ce22dd Fix plpgsql's handling of "simple" expression evaluation. In general, expression execution state trees aren't re-entrantly usable, since functions can store private state information in them. For efficiency reasons, plpgsql tries to cache and reuse state trees for "simple" expressions. It can get away with that most of the time, but it can fail if the state tree is dirty from a previous failed execution (as in an example from Alvaro) or is being used recursively (as noted by me). Fix by tracking whether a state tree is in use, and falling back to the "non-simple" code path if so. This results in a pretty considerable speed hit when the non-simple path is taken, but the available alternatives seem even more unpleasant because they add overhead in the simple path. Per idea from Heikki. Back-patch to all supported branches. 28 October 2010, 17:02:12 UTC
e9eb4f4 Release notes for 9.1alpha2 28 October 2010, 14:42:58 UTC
18d6437 Remove obsolete release-alpha.sgml This was only used while the final release notes for 9.0 were being prepared. The alpha release notes are now in release-9.1.sgml. 28 October 2010, 14:40:56 UTC
2999f4e Remove tabs from SGML 28 October 2010, 14:40:27 UTC
2cae0ae Revert "Correct WAL space calculation formula in docs." This reverts commit 915116bc62db2aaec7001bde6610128f4cbd29f9. Per discussion, the previous formula was in fact correct. http://archives.postgresql.org/pgsql-docs/2010-10/msg00038.php 28 October 2010, 01:24:02 UTC
0d5deeb Reorganize OS-specific details about write caching into a list. Along the way, clarify that sdparm can be used on Linux as well as FreeBSD. 28 October 2010, 01:20:58 UTC
e6721c6 Previous patch had no detectable virtue other than being a one-liner. Try to make the code look self-consistent again, so it doesn't confuse future developers. 27 October 2010, 19:26:24 UTC
869af50 Fix long-standing segfault when accept() or one of the calls made right after accepting a connection fails, and the server is compiled with GSSAPI support. Report and patch by Alexander V. Chernikov, bug #5731. 27 October 2010, 17:07:13 UTC
35d8940 Fix up some oversights in psql's Unicode-escape support. Original patch failed to include new exclusive states in a switch that needed to include them; and also was guilty of very fuzzy thinking about how to handle error cases. Per bug #5729 from Alan Choi. 27 October 2010, 02:25:19 UTC
5a12c80 Note that effective_io_concurrency only affects bitmap heap scans. Josh Kupershmidt 27 October 2010, 01:44:14 UTC
20709f8 Add a client authentication hook. KaiGai Kohei, with minor cleanup of the comments by me. 27 October 2010, 01:20:38 UTC
1fea0c0 Minor fixups for psql's process_file() function. - Avoid closing stdin, since we didn't open it. Previously multiple inclusions of stdin would be terminated with a single quit, now a separate quit is needed for each invocation. Previous behavior also accessed stdin after it was fclose()d, which is undefined behavior per ANSI C. - Properly restore pset.inputfile, since the caller expects to be able to free that memory. Marti Raudsepp 26 October 2010, 23:35:33 UTC
5c38782 Note explicitly that hash indexes are also not replicated because they're not WAL-logged. Make the notice about the lack of WAL-logging more visible by making it a <caution>. Also remove the false statement from hot standby caveats section that hash indexes are not used during hot standby. 26 October 2010, 19:53:41 UTC
3579a94 Fix dumb typo in SECURITY LABEL error message. Report by Peter Eisentraut. 26 October 2010, 18:55:18 UTC
0c6293d Before removing backup_label and irrevocably changing pg_control file, check that WAL file containing the checkpoint redo-location can be found. This avoids making the cluster irrecoverable if the redo location is in an earlie WAL file than the checkpoint record. Report, analysis and patch by Jeff Davis, with small changes by me. 26 October 2010, 18:43:52 UTC
a87d212 Add missing newlines at end of files 26 October 2010, 17:11:43 UTC
bf76ad0 Fix typos "are are". 26 October 2010, 08:15:17 UTC
07ca728 Add .gitignore for contrib/uuid-ossp. 26 October 2010, 03:25:34 UTC
3567034 Refactor typenameTypeId() Split the old typenameTypeId() into two functions: A new typenameTypeId() that returns only a type OID, and typenameTypeIdAndMod() that returns type OID and typmod. This isolates call sites better that actually care about the typmod. 25 October 2010, 18:44:49 UTC
c6873ea Fix overly-enthusiastic Assert in printing of Param reference expressions. A NestLoopParam's value can only be a Var or Aggref, but this isn't the case in general for SubPlan parameters, so print_parameter_expr had better be prepared to cope. Brain fade in my recent patch to print the referenced expression instead of just printing $N for PARAM_EXEC Params. Per report from Pavel Stehule. 25 October 2010, 18:25:10 UTC
ef55e29 Fix inline_set_returning_function() to preserve the invalItems list properly. This avoids a possible crash when inlining a SRF whose argument list contains a reference to an inline-able user function. The crash is quite reproducible with CLOBBER_FREED_MEMORY enabled, but would be less certain in a production build. Problem introduced in 9.0 by the named-arguments patch, which requires invoking eval_const_expressions() before we can try to inline a SRF. Per report from Brendan Jurd. 25 October 2010, 17:04:37 UTC
9350824 find -path is not portable, so use grep -v instead. Per previous failure of buildfarm member koi (which is no longer failing, alas). 25 October 2010, 13:04:00 UTC
4ba61a4 Work around rounding misbehavior exposed by buildfarm. 25 October 2010, 05:13:22 UTC
2d01ec0 Remove unnecessary use of trigger flag to hash plperl functions 25 October 2010, 03:53:44 UTC
84c123b Allow new values to be added to an existing enum type. After much expenditure of effort, we've got this to the point where the performance penalty is pretty minimal in typical cases. Andrew Dunstan, reviewed by Brendan Jurd, Dean Rasheed, and Tom Lane 25 October 2010, 03:05:41 UTC
24b29ca Support suffix matching of host names in pg_hba.conf A name starting with a dot can be used to match a suffix of the actual host name (e.g., .example.com matches foo.example.com). 24 October 2010, 12:54:00 UTC
dd15870 Correct a mistake in levenshtein_less_equal() multibyte character handling. Spotted by Alexander Korotkov. Along the way, remove a misleading comment line. 22 October 2010, 19:27:39 UTC
57b80b4 Add semicolon, missed in previous patch. And update the keyword list in the docs to reflect that OFF is now unreserved. Spotted by Tom Lane. 22 October 2010, 15:38:31 UTC
5c84fe4 Make OFF keyword unreserved. It's not hard to imagine wanting to use 'off' as a variable or column name, and it's not reserved in recent versions of the SQL spec either. This became particularly annoying in 9.0, before that PL/pgSQL replaced variable names in queries with parameter markers, so it was possible to use OFF and many other backend parser keywords as variable names. Because of that, backpatch to 9.0. 22 October 2010, 14:44:50 UTC
71be8db Mention limited usefulness of .pgpass database field. 21 October 2010, 22:00:11 UTC
529cb26 Improve handling of domains over arrays. This patch eliminates various bizarre behaviors caused by sloppy thinking about the difference between a domain type and its underlying array type. In particular, the operation of updating one element of such an array has to be considered as yielding a value of the underlying array type, *not* a value of the domain, because there's no assurance that the domain's CHECK constraints are still satisfied. If we're intending to store the result back into a domain column, we have to re-cast to the domain type so that constraints are re-checked. For similar reasons, such a domain can't be blindly matched to an ANYARRAY polymorphic parameter, because the polymorphic function is likely to apply array-ish operations that could invalidate the domain constraints. For the moment, we just forbid such matching. We might later wish to insert an automatic downcast to the underlying array type, but such a change should also change matching of domains to ANYELEMENT for consistency. To ensure that all such logic is rechecked, this patch removes the original hack of setting a domain's pg_type.typelem field to match its base type; the typelem will always be zero instead. In those places where it's really okay to look through the domain type with no other logic changes, use the newly added get_base_element_type function in place of get_element_type. catversion bumped due to change in pg_type contents. Per bug #5717 from Richard Huxton and subsequent discussion. 21 October 2010, 20:07:17 UTC
572ab1a Remove obsolete comment, per Josh Kupershmidt. 20 October 2010, 21:05:15 UTC
a52aa6c Clean up pg_upgrade cache lookup code; remove useless NULL pointer tests. 20 October 2010, 20:02:37 UTC
18e752f If pk is NULL, the backend would segfault when accessing ->algo and the following NULL check was never reached. This problem was found by Coccinelle (null_ref.cocci from coccicheck). Marti Raudsepp 20 October 2010, 19:24:04 UTC
def30e8 Don't try to fetch database name when SetTransactionIdLimit() is executed outside a transaction. This repairs brain fade in my patch of 2009-08-30: the reason we had been storing oldest-database name, not OID, in ShmemVariableCache was of course to avoid having to do a catalog lookup at times when it might be unsafe. This error explains why Aleksandr Dushein is having trouble getting out of an XID wraparound state in bug #5718, though not how he got into that state in the first place. I suspect pg_upgrade is at fault there. 20 October 2010, 16:48:51 UTC
17a1666 Remove AtStart_Cache() call in CommandCounterIncrement(). This call was present in the aboriginal code from Berkeley, and has never been touched; it may very well be that it was there to mask effects of bugs in other places and it may no longer be necessary. The removal has been foreseen in a code comment since 2007; this seems to be a good time to test this hypothesis. 20 October 2010, 14:33:57 UTC
c75e143 Fix ecpg test building process to not generate *.dSYM junk on Macs. The trick is to not try to build executables directly from .c files, but to always build the intermediate .o files. For obscure reasons, Darwin's version of gcc will leave debug cruft behind in the first case but not the second. Per complaint from Robert Haas. 20 October 2010, 04:54:58 UTC
4b6623a Add some caveats to the contrib/isn docs. 20 October 2010, 02:48:19 UTC
6d1af7b Updates to contrib/isn ISBN tables. Jan Otto, reviewed by Peter Geoghegan 20 October 2010, 02:48:19 UTC
691a67b Rename pg_upgrade 'log' to 'log_opts', to avoid platform naming conflict. 20 October 2010, 02:31:17 UTC
3325c9b Further speed up pg_upgrade lookups. 20 October 2010, 02:06:06 UTC
c33bfb8 Update storage.sgml to describe the 9.0 tablespace directory layout. 20 October 2010, 01:53:26 UTC
1c72614 Fix for new pg_upgrade cache code. 20 October 2010, 01:24:31 UTC
333b4a4 Cache most recent relfilenode lookups, for speed, after report of pg_upgrade slowness for 150k tables. 20 October 2010, 00:55:16 UTC
ad06db2 In pg_upgrade, use cached copy of directory listing, rather than calling scandir() with a pattern for every table. Optimization after report of pg_upgrade slowness with 150k tables. 20 October 2010, 00:33:19 UTC
07456b4 Pgindent run on pg_upgrade source after restructuring. 19 October 2010, 22:37:04 UTC
e13f7e9 Restructure the pg_upgrade code to use several global structures rather than packing everything into 'ctx' and passing that to every function. 19 October 2010, 21:38:34 UTC
6e74a91 Fix incorrect generation of whole-row variables in planner. A couple of places in the planner need to generate whole-row Vars, and were cutting corners by setting vartype = RECORDOID in the Vars, even in cases where there's an identifiable named composite type for the RTE being referenced. While we mostly got away with this, it failed when there was also a parser-generated whole-row reference to the same RTE, because the two Vars weren't equal() due to the difference in vartype. Fix by providing a subroutine the planner can call to generate whole-row Vars the same way the parser does. Per bug #5716 from Andrew Tipton. Back-patch to 9.0 where one of the bogus calls was introduced (the other one is new in HEAD). 19 October 2010, 19:09:23 UTC
722d5be In pg_upgrade, rename SHELL_EXT to SCRIPT_EXT, for clarity. 19 October 2010, 15:57:55 UTC
51eeccd Add removal of PG_VERSION to optional old cluster deletion script. Backpatch to 9.0.X. 19 October 2010, 15:52:43 UTC
f75d6a1 Add mention of using tools/fsync to test fsync methods. Restructure recent wal_sync_method doc paragraph to be clearer. 19 October 2010, 14:56:53 UTC
604ab08 Add levenshtein_less_equal, optimized version for small distances. Alexander Korotkov, heavily revised by me. 19 October 2010, 13:51:06 UTC
262c1a4 Unbreak comments on composite type attributes. Report and diagnosis by Peter Eisentraut. 19 October 2010, 11:21:58 UTC
9df96f9 In pg_upgrade, rename macro EXEC_EXT to SHELL_EXT for clarity. Backpatch to 9.0.X. 19 October 2010, 02:56:16 UTC
bc8624b Support key word 'all' in host column of pg_hba.conf 18 October 2010, 19:15:44 UTC
433c7a6 Document the tablespace directory "should" be empty, rather than "must" be empty. Because of binary migration usage, it might not be empty. 18 October 2010, 18:15:58 UTC
9c73e20 Change example pg_hba.conf in docs to match altered pg_hba.conf.sample Peter Eisentraut's recent patch to allow host names in pg_hba.conf changed the contents of pg_hba.conf.sample Fujii Masao 18 October 2010, 16:18:45 UTC
419d237 Fix a passel of inappropriately-named global functions in GIN. The GIN code has absolutely no business exporting GIN-specific functions with names as generic as compareItemPointers() or newScanKey(); that's just trouble waiting to happen. I got annoyed about this again just now and decided to fix it. This commit ensures that all global symbols defined in access/gin/ have names including "gin" or "Gin". There were a couple of cases, like names involving "PostingItem", where arguably the names were already sufficiently nongeneric; but I figured as long as I was risking creating merge problems for unapplied GIN patches I might as well impose a uniform policy. I didn't touch any static symbol names. There might be some places where it'd be appropriate to rename some static functions to match siblings that are exported, but I'll leave that for another time. 18 October 2010, 01:43:26 UTC
48c7d9f Improve GIN indexscan cost estimation. The better estimate requires more statistics than we previously stored: in particular, counts of "entry" versus "data" pages within the index, as well as knowledge of the number of distinct key values. We collect this information during initial index build and update it during VACUUM, storing the info in new fields on the index metapage. No initdb is required because these fields will read as zeroes in a pre-existing index, and the new gincostestimate code is coded to behave (reasonably) sanely if they are zeroes. Teodor Sigaev, reviewed by Jan Urbanski, Tom Lane, and Itagaki Takahiro. 18 October 2010, 00:52:32 UTC
cd0e825 Fix msvc build for localized versions of Visual C++ Look only at the non-localized part of the output from "vcbuild /?", which is used to determine the version of Visual Studio in use. Different languages seem to localize different amounts of the string, but we assume the part "Microsoft Visual C++" won't be modified. 17 October 2010, 14:36:54 UTC
9771125 Fix recent changes to not break non-IPV6-aware systems. 16 October 2010, 14:12:16 UTC
33ae03f Document that translate() removes characters in "from" that don't have a corresponding "to" character. Author: Josh Kupershmidt 16 October 2010, 04:15:10 UTC
07f1264 Allow WITH clauses to be attached to INSERT, UPDATE, DELETE statements. This is not the hoped-for facility of using INSERT/UPDATE/DELETE inside a WITH, but rather the other way around. It seems useful in its own right anyway. Note: catversion bumped because, although the contents of stored rules might look compatible, there's actually a subtle semantic change. A single Query containing a WITH and INSERT...VALUES now represents writing the WITH before the INSERT, not before the VALUES. While it's not clear that that matters to anyone, it seems like a good idea to have it cited in the git history for catversion.h. Original patch by Marko Tiikkaja, with updating and cleanup by Hitoshi Harada. 15 October 2010, 23:55:25 UTC
6ab42ae Support host names in pg_hba.conf Peter Eisentraut, reviewed by KaiGai Kohei and Tom Lane 15 October 2010, 19:56:18 UTC
3cde443 Change references to SQL/XML:2003 to :2008 and renumber sections accordingly 15 October 2010, 19:56:18 UTC
71d2446 Document the DISTINCT noise word in the UNION/INTERSECT/EXCEPT constructs. I also rearranged the order of the sections to match the logical order of processing steps: the distinct-elimination implied by SELECT DISTINCT happens before, not after, any UNION/INTERSECT/EXCEPT combination. Per a suggestion from Hitoshi Harada. 15 October 2010, 19:48:45 UTC
0c9b166 Allow pg_ctl to register the service in either AUTO or DEMAND start type Author: Quan Zongliang Documentation updates by David Fetter 15 October 2010, 17:30:03 UTC
0e7f707 Fix low-risk potential denial of service against RADIUS login. Corrupt RADIUS responses were treated as errors and not ignored (which the RFC2865 states they should be). This meant that a user with unfiltered access to the network of the PostgreSQL or RADIUS server could send a spoofed RADIUS response to the PostgreSQL server causing it to reject a valid login, provided the attacker could also guess (or brute-force) the correct port number. Fix is to simply retry the receive in a loop until the timeout has expired or a valid (signed by the correct RADIUS server) packet arrives. Reported by Alan DeKok in bug #5687. 15 October 2010, 14:59:10 UTC
915116b Correct WAL space calculation formula in docs. Error pointed out by Fujii Masao, though not his patch. 15 October 2010, 09:17:12 UTC
2317711 Improve comment about ignoring 128 error code on Windows: * Microsoft reports it is related to mutex failure: * http://archives.postgresql.org/pgsql-hackers/2010-09/msg00790.php 15 October 2010, 01:58:11 UTC
e468213 Add pg_user_mappings to the table of system views. 14 October 2010, 23:13:01 UTC
11cad29 Support MergeAppend plans, to allow sorted output from append relations. This patch eliminates the former need to sort the output of an Append scan when an ordered scan of an inheritance tree is wanted. This should be particularly useful for fast-start cases such as queries with LIMIT. Original patch by Greg Stark, with further hacking by Hans-Jurgen Schonig, Robert Haas, and Tom Lane. 14 October 2010, 20:57:57 UTC
30e749d Fix makefile logic to not break the build when xgettext is missing xgettext is only required when make init-po is run manually; it is not required for a build. The intent to handle that was already there, but the ifdef's were in the wrong place. 14 October 2010, 20:16:46 UTC
402e119 Remove reference.ced This is a parsed DocBook DTD for the PSGML Emacs mode, but it hasn't been updated since we switched to DocBook 4.2 about seven years ago. Also, PSGML has deprecated this method of DTD parsing. 14 October 2010, 20:16:46 UTC
9f2d7f6 Complete the documentation of the USAGE privilege for foreign servers The GRANT reference page failed to mention that the USAGE privilege allows modifying associated user mappings, although this was already documented on the CREATE/ALTER/DROP USER MAPPING pages. 14 October 2010, 20:16:46 UTC
80ada4c Document (compositeval).* field selection syntax 14 October 2010, 20:16:46 UTC
7085891 Improvements to docs about pg_archive_cleanup and use of archives Brendan Jurd 14 October 2010, 18:30:15 UTC
3bbcc5c Make startup process respond to signals to cancel waiting on latch. A tidy up for recently committed changes to startup latch. Fujii Masao 14 October 2010, 18:15:26 UTC
45cd919 Fix bug in comment of timeline history file. Fujii Masao 14 October 2010, 18:06:06 UTC
816b008 Applied patch by Itagaki Takahiro to fix incorrect status calculation in ecpglib. Instead of parsing the statement just as ask the database server. This patch removes the whole client side track keeping of the current transaction status. 14 October 2010, 15:55:07 UTC
1a996d6 Remove executable permission from files where it doesn't belong 13 October 2010, 19:30:25 UTC
e8a47b3 Add index entries for pg_stat* views 13 October 2010, 18:29:10 UTC
ceb5b78 Mention the default pg_ctl wait time in the -t option documentation 13 October 2010, 17:24:51 UTC
ef204db Make title capitalization consistent with surroundings 13 October 2010, 17:05:16 UTC
3bf7983 Put per-letter quicklinks at the top of the HTML bookindex page 13 October 2010, 16:46:05 UTC
d0f876c Accept 'public' as a pseudo-role name in has_table_privilege() and friends to see if a particular privilege has been granted to PUBLIC. The issue was reported by Jim Nasby. Patch by Alvaro Herrera, and reviewed by KaiGai Kohei. 13 October 2010, 05:37:23 UTC
f4d242e Remove some unnecessary tests of pgstat_track_counts. We may as well make pgstat_count_heap_scan() and related macros just count whenever rel->pgstat_info isn't null. Testing pgstat_track_counts buys nothing at all in the normal case where that flag is ON; and when it's OFF, the pgstat_info link will be null, so it's still a useless test. This change is unlikely to buy any noticeable performance improvement, but a cycle shaved is a cycle earned; and my investigations earlier today convinced me that we're down to the point where individual instructions in the inner execution loops are starting to matter. 12 October 2010, 18:44:25 UTC
82659e0 Fix typo 12 October 2010, 16:24:10 UTC
back to top