Revision 76e057dba29af1f322a19cb75b2921010dbe459c authored by Jeff King on 25 March 2015, 05:29:10 UTC, committed by Junio C Hamano on 25 March 2015, 17:24:13 UTC
When checking a list of file mtimes, we use a loop and break out early from the loop if any entry does not match. However, the exit code of a loop exited via break is always 0, meaning that the test will fail to notice we had a mismatch. Since the loop is inside a function, we can fix this by doing an early "return 1". Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 6636cf7
test-ctype.c
#include "cache.h"
static int rc;
static void report_error(const char *class, int ch)
{
printf("%s classifies char %d (0x%02x) wrongly\n", class, ch, ch);
rc = 1;
}
static int is_in(const char *s, int ch)
{
/* We can't find NUL using strchr. It's classless anyway. */
if (ch == '\0')
return 0;
return !!strchr(s, ch);
}
#define TEST_CLASS(t,s) { \
int i; \
for (i = 0; i < 256; i++) { \
if (is_in(s, i) != t(i)) \
report_error(#t, i); \
} \
}
#define DIGIT "0123456789"
#define LOWER "abcdefghijklmnopqrstuvwxyz"
#define UPPER "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
int main(int argc, char **argv)
{
TEST_CLASS(isdigit, DIGIT);
TEST_CLASS(isspace, " \n\r\t");
TEST_CLASS(isalpha, LOWER UPPER);
TEST_CLASS(isalnum, LOWER UPPER DIGIT);
TEST_CLASS(is_glob_special, "*?[\\");
TEST_CLASS(is_regex_special, "$()*+.?[\\^{|");
TEST_CLASS(is_pathspec_magic, "!\"#%&',-/:;<=>@_`~");
return rc;
}
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...