Revision - 76fc067 - Make sure all the relocations are filled in for partially cloned [...] - origin: https://github.com/JuliaLang/julia

visit type:

https://github.com/JuliaLang/julia

19 April 2024, 06:28:37 UTC

Revision 76fc067185ce7737247122b5a1781f079a8f0711 authored by Yichao Yu on 25 February 2022, 14:48:24 UTC, committed by GitHub on 25 February 2022, 14:48:24 UTC

Make sure all the relocations are filled in for partially cloned target (#44262)

We collect the relocations (i.e. the GOT slots that is used in the code) for each target
in `tgt.relocs`. Needing a relocation, however, does not imply that the function is cloned
for this target within the group (It does mean that at least one target
in the group has it cloned). The previous version would miss the relocation in this case.

This was triggerred with the following cloning situation

    caller: clone_1
    callee: clone_1, clone_1.clone_3

Since caller.clone_1 may call either callee.clone_1 or callee.clone_1.clone_3 a relocation
for callee will be used and is required to be initialized.
In addition to target 1, target 2 (and in fact target 3) within group 1
will also use caller.clone_1. However, since callee isn't cloned for target 2
the previous version wouldn't have saved this slot in the relocation array.

1 parent c9cb015

Files
Changes

Permalinks

Tip revision: 76fc067185ce7737247122b5a1781f079a8f0711 authored by Yichao Yu on 25 February 2022, 14:48:24 UTC
Make sure all the relocations are filled in for partially cloned target (#44262)

Tip revision: 76fc067

File	Mode	Size
.buildkite
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.clang-format	-rw-r--r--	3.3 KB
.codecov.yml	-rw-r--r--	52 bytes
.gitattributes	-rw-r--r--	65 bytes
.gitignore	-rw-r--r--	433 bytes
.mailmap	-rw-r--r--	12.1 KB
CITATION.bib	-rw-r--r--	513 bytes
CITATION.cff	-rw-r--r--	940 bytes
CONTRIBUTING.md	-rw-r--r--	22.5 KB
HISTORY.md	-rw-r--r--	349.3 KB
LICENSE.md	-rw-r--r--	1.3 KB
Make.inc	-rw-r--r--	49.8 KB
Makefile	-rw-r--r--	26.2 KB
NEWS.md	-rw-r--r--	1.4 KB
README.md	-rw-r--r--	7.4 KB
THIRDPARTY.md	-rw-r--r--	3.7 KB
VERSION	-rw-r--r--	10 bytes
julia.spdx.json	-rw-r--r--	35.8 KB
sysimage.mk	-rw-r--r--	4.1 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/JuliaLang/julia

Make sure all the relocations are filled in for partially cloned target (#44262)

README.md