Revision 7778cb3680787d482dec9c49ff812b96e5e34207 authored by George Kalpakas on 08 October 2021, 16:43:16 UTC, committed by Andrew Scott on 08 October 2021, 20:39:46 UTC
In 305d05545ad6037b3b8eccb8e53e09735836391e, we accidentally stopped instantiating the `SwUpdatesService` service, which meant that we were no longer subscribing to ServiceWorker update events and proactively checking for updates. We would still gets updates, because the ServiceWorker automatically checks on each navigation request and when a new ServiceWorker instance is created, but we would not proactively fetch updates and also miss `unrecoverable` errors. This commit fixes this by exposing an `enable()` method from `SwUpdatesService`, which has to be explicitly called for the service to be enabled, and ensures that the method is called when `AppComponent` is initialized. The commit also gets rid of the `SwUpdatesModule` (whose only purpose was to provide `SwUpdatesService`) in favor of using `providedIn`. Fixes #43695 PR Close #43766
1 parent af11d3b
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .devcontainer | ||
| .github | ||
| .husky | ||
| .ng-dev | ||
| .vscode | ||
| .yarn | ||
| aio | ||
| docs | ||
| goldens | ||
| integration | ||
| modules | ||
| packages | ||
| scripts | ||
| third_party | ||
| tools | ||
| .bazelignore | -rw-r--r-- | 4.2 KB |
| .bazelrc | -rw-r--r-- | 6.5 KB |
| .bazelversion | -rw-r--r-- | 6 bytes |
| .clang-format | -rw-r--r-- | 73 bytes |
| .editorconfig | -rw-r--r-- | 245 bytes |
| .gitattributes | -rw-r--r-- | 240 bytes |
| .gitignore | -rw-r--r-- | 797 bytes |
| .gitmessage | -rw-r--r-- | 7.2 KB |
| .mailmap | -rw-r--r-- | 51 bytes |
| .npmrc | -rw-r--r-- | 21 bytes |
| .nvmrc | -rw-r--r-- | 8 bytes |
| .prettierrc | -rw-r--r-- | 157 bytes |
| .pullapprove.yml | -rw-r--r-- | 46.9 KB |
| .yarnrc | -rw-r--r-- | 130 bytes |
| BUILD.bazel | -rw-r--r-- | 2.0 KB |
| CHANGELOG.md | -rw-r--r-- | 955.9 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 1.1 KB |
| CONTRIBUTING.md | -rw-r--r-- | 15.8 KB |
| LICENSE | -rw-r--r-- | 1.1 KB |
| README.md | -rw-r--r-- | 4.7 KB |
| WORKSPACE | -rw-r--r-- | 3.1 KB |
| browser-providers.conf.js | -rw-r--r-- | 8.0 KB |
| gulpfile.js | -rw-r--r-- | 631 bytes |
| karma-js.conf.js | -rw-r--r-- | 8.1 KB |
| package.json | -rw-r--r-- | 8.6 KB |
| renovate.json | -rw-r--r-- | 2.3 KB |
| test-events.js | -rw-r--r-- | 259 bytes |
| test-main.js | -rw-r--r-- | 9.4 KB |
| tsconfig-tslint.json | -rw-r--r-- | 149 bytes |
| tslint.json | -rw-r--r-- | 4.9 KB |
| yarn.lock | -rw-r--r-- | 594.1 KB |
| yarn.lock.readme.md | -rw-r--r-- | 1.3 KB |
Computing file changes ...
