Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 78d0f94902afce8ec2c7a60f600cc0e3729d7412 authored by Julian Ruess on 13 June 2023, 12:25:37 UTC, committed by David S. Miller on 15 June 2023, 07:48:45 UTC 
s390/ism: Fix trying to free already-freed IRQ by repeated ism_dev_exit()
 
This patch prevents the system from crashing when unloading the ISM module.

How to reproduce: Attach an ISM device and execute 'rmmod ism'.

Error-Log:
- Trying to free already-free IRQ 0
- WARNING: CPU: 1 PID: 966 at kernel/irq/manage.c:1890 free_irq+0x140/0x540

After calling ism_dev_exit() for each ISM device in the exit routine,
pci_unregister_driver() will execute ism_remove() for each ISM device.
Because ism_remove() also calls ism_dev_exit(),
free_irq(pci_irq_vector(pdev, 0), ism) is called twice for each ISM
device. This results in a crash with the error
'Trying to free already-free IRQ'.

In the exit routine, it is enough to call pci_unregister_driver()
because it ensures that ism_dev_exit() is called once per
ISM device.

Cc: <stable@vger.kernel.org> # 6.3+
Fixes: 89e7d2ba61b7 ("net/ism: Add new API for client registration")
Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
Signed-off-by: Julian Ruess <julianr@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 6ac7a27
History
Tip revision: 78d0f94902afce8ec2c7a60f600cc0e3729d7412 authored by Julian Ruess on 13 June 2023, 12:25:37 UTC
s390/ism: Fix trying to free already-freed IRQ by repeated ism_dev_exit()
Tip revision: 78d0f94
File Mode Size
.gitignore -rw-r--r-- 58 bytes
Kconfig -rw-r--r-- 62.5 KB
Makefile -rw-r--r-- 1.8 KB
build-version -rwxr-xr-x 177 bytes
calibrate.c -rw-r--r-- 8.6 KB
do_mounts.c -rw-r--r-- 15.5 KB
do_mounts.h -rw-r--r-- 908 bytes
do_mounts_initrd.c -rw-r--r-- 3.7 KB
do_mounts_rd.c -rw-r--r-- 7.7 KB
init_task.c -rw-r--r-- 6.1 KB
initramfs.c -rw-r--r-- 17.1 KB
main.c -rw-r--r-- 38.6 KB
noinitramfs.c -rw-r--r-- 862 bytes
version-timestamp.c -rw-r--r-- 762 bytes
version.c -rw-r--r-- 1.3 KB
back to top