swh:1:snp:634d2b8906a7a2f6511ccb358da84e19b290d2c9
Revision 78dc45e99e7a5b66d81d4294ee83773e49c74f1f authored by Valentin Lorentz on 20 February 2021, 23:18:01 UTC, committed by Valentin Lorentz on 20 February 2021, 23:18:03 UTC
Sometimes (very rarely), the test errors with:

```
======================================================================
FAIL: testHistsearch (Aka.test.AkaChannelTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/supybot/test.py", line 214, in runTest
    originalRunTest()
  File "/usr/lib/python3/dist-packages/supybot/plugins/Aka/test.py", line 67, in testHistsearch
    self.assertResponse('histsearch .*', '@echo foo')
  File "/usr/lib/python3/dist-packages/supybot/test.py", line 402, in assertResponse
    self.assertEqual(m.args[1], expectedResponse,
AssertionError: '@aka add histsearch "last --from [cif true[80 chars]"]]"' != '@echo foo'
- @aka add histsearch "last --from [cif true \"echo test\" \"echo test\"] --regexp [concat \"m/$1/\" [re s/g// \"@2\"]]"
+ @echo foo
 : '@echo foo' != '@aka add histsearch "last --from [cif true \\"echo test\\" \\"echo test\\"] --regexp [concat \\"m/$1/\\" [re s/g// \\"@2\\"]]"'
```

ie. histsearch returns the 'aka add' message instead of the 'echo foo'
one.

My guess is that if they happen too closely to each other, they get
added to the history in the wrong order (how? it's not threaded)

So this commit works around the issue by making the regexp unambiguous.
1 parent 85549bf
History
Tip revision: 35bf5998564eda288ca4ee86e0fa45b28c64d7ba authored by Valentin Lorentz on 20 September 2022, 05:51:46 UTC
utils/web: Add <br/> to the list of block elements
Tip revision: 35bf599
File Mode Size
locales
man
plugins
sandbox
scripts
src
test
.gitattributes -rw-r--r-- 42 bytes
.gitignore -rw-r--r-- 403 bytes
.mailmap -rw-r--r-- 1.8 KB
.travis.yml -rw-r--r-- 1.4 KB
CONTRIBUTING.md -rw-r--r-- 1.3 KB
ChangeLog -rw-r--r-- 69.0 KB
LICENSE.md -rw-r--r-- 1.6 KB
MANIFEST.in -rw-r--r-- 117 bytes
Makefile -rw-r--r-- 983 bytes
README.md -rw-r--r-- 2.1 KB
RELNOTES -rw-r--r-- 16.1 KB
pyproject.toml -rw-r--r-- 86 bytes
requirements.txt -rw-r--r-- 101 bytes
setup.py -rw-r--r-- 8.8 KB
supybot l--------- 3 bytes

README.md

back to top