https://github.com/torvalds/linux
Revision 7a26b53070f0099dfcfc9d499458de861c5c4859 authored by Catalin Marinas on 15 May 2013, 16:49:35 UTC, committed by Rafael J. Wysocki on 15 May 2013, 19:42:24 UTC
Following commit 6b772e8f9 (ACPI: Update PNPID match handling for notify), the acpi_scan_init_hotplug() calls acpi_set_pnp_ids() which allocates acpi_hardware_id and copies a few strings (kstrdup). If the devices does not have hardware_id set, the function exits without freeing the previously allocated ids (and kmemleak complains). This patch calls simply changes 'return' on error to a 'goto out' which calls acpi_free_pnp_ids(). Reported-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> Reviewed-by: Toshi Kani <toshi.kani@hp.com> Tested-by: Toshi Kani <toshi.kani@hp.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 0ab5bb6
Tip revision: 7a26b53070f0099dfcfc9d499458de861c5c4859 authored by Catalin Marinas on 15 May 2013, 16:49:35 UTC
ACPI / scan: Fix memory leak on acpi_scan_init_hotplug() error path
ACPI / scan: Fix memory leak on acpi_scan_init_hotplug() error path
Tip revision: 7a26b53
| File | Mode | Size |
|---|---|---|
| partitions | ||
| Kconfig | -rw-r--r-- | 3.2 KB |
| Kconfig.iosched | -rw-r--r-- | 1.6 KB |
| Makefile | -rw-r--r-- | 720 bytes |
| blk-cgroup.c | -rw-r--r-- | 29.8 KB |
| blk-cgroup.h | -rw-r--r-- | 15.1 KB |
| blk-core.c | -rw-r--r-- | 86.2 KB |
| blk-exec.c | -rw-r--r-- | 3.3 KB |
| blk-flush.c | -rw-r--r-- | 13.1 KB |
| blk-integrity.c | -rw-r--r-- | 11.6 KB |
| blk-ioc.c | -rw-r--r-- | 10.2 KB |
| blk-iopoll.c | -rw-r--r-- | 5.9 KB |
| blk-lib.c | -rw-r--r-- | 7.1 KB |
| blk-map.c | -rw-r--r-- | 8.2 KB |
| blk-merge.c | -rw-r--r-- | 12.7 KB |
| blk-settings.c | -rw-r--r-- | 26.3 KB |
| blk-softirq.c | -rw-r--r-- | 4.5 KB |
| blk-sysfs.c | -rw-r--r-- | 15.8 KB |
| blk-tag.c | -rw-r--r-- | 9.7 KB |
| blk-throttle.c | -rw-r--r-- | 30.8 KB |
| blk-timeout.c | -rw-r--r-- | 4.7 KB |
| blk.h | -rw-r--r-- | 7.1 KB |
| bsg-lib.c | -rw-r--r-- | 6.0 KB |
| bsg.c | -rw-r--r-- | 23.6 KB |
| cfq-iosched.c | -rw-r--r-- | 119.4 KB |
| compat_ioctl.c | -rw-r--r-- | 20.8 KB |
| deadline-iosched.c | -rw-r--r-- | 11.1 KB |
| elevator.c | -rw-r--r-- | 23.9 KB |
| genhd.c | -rw-r--r-- | 44.1 KB |
| ioctl.c | -rw-r--r-- | 10.7 KB |
| noop-iosched.c | -rw-r--r-- | 2.5 KB |
| partition-generic.c | -rw-r--r-- | 14.0 KB |
| scsi_ioctl.c | -rw-r--r-- | 19.6 KB |
Computing file changes ...
