Revision - 7a965b6 - Match the 'is rendered' definition from the spec in innerText. - origin: https://github.com/web-platform-tests/wpt

visit type:

https://github.com/web-platform-tests/wpt

26 December 2018, 22:31:15 UTC

Revision 7a965b6973d265809e848911c951b7cb370c3c28 authored by Emilio Cobos Álvarez on 22 August 2018, 09:08:02 UTC, committed by moz-wptsync-bot on 22 August 2018, 16:55:37 UTC

Match the 'is rendered' definition from the spec in innerText.

This matches other implementations and the spec for fallback content like:

  <canvas><div>abc

(calling div.innerText).

We're treating the <div> as 'rendered' because it's not in a display: none
subtree, but that's not ok, since it is in fact not rendered.

This was added in bug 1226293, and Boris suggested this change, but roc opposed
because it'd be hard to spec properly in comment 15. Looks like the HTML spec
ended up merging roc's innerText spec, and now it's spec'd in terms of 'being
rendered'.

I think IsOrHasAncestorWithDisplayNone just doesn't work in any reasonable way
for stuff out of the flat tree. Thus I think this change is the right thing.

The canvas test fails because of bug 1485076.

Differential Revision: https://phabricator.services.mozilla.com/D3887

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1484855
gecko-commit: db66903f54cc0b27224255efab79cef50ca16540
gecko-integration-branch: autoland
gecko-reviewers: smaug

1 parent 61aa8d0

Files
Changes

Permalinks

Tip revision: 7a965b6973d265809e848911c951b7cb370c3c28 authored by Emilio Cobos Álvarez on 22 August 2018, 09:08:02 UTC
Match the 'is rendered' definition from the spec in innerText.

Tip revision: 7a965b6

File	Mode	Size
.well-known
2dcontext
BackgroundSync
FileAPI
IndexedDB
WebCryptoAPI
WebIDL
accelerometer
accname
acid
ambient-light
animation-worklet
annotation-model
annotation-protocol
annotation-vocab
apng
appmanifest
async-local-storage
audio-output
background-fetch
battery-status
beacon
bluetooth
clear-site-data
client-hints
clipboard-apis
common
compat
conformance-checkers
console
content-security-policy
cookie-store
cookies
core-aam
cors
credential-management
css
custom-elements
device-memory
docs
dom
domparsing
domxpath
dpub-aam
dpub-aria
editing
encoding
encrypted-media
entries-api
eventsource
feature-policy
fetch
fonts
fullscreen
gamepad
generic-sensor
geolocation-API
geolocation-sensor
graphics-aam
gyroscope
hr-time
html
html-longdesc
html-media-capture
imagebitmap-renderingcontext
images
infrastructure
input-device-capabilities
input-events
interfaces
intersection-observer
js
keyboard-lock
keyboard-map
lifecycle
longtask-timing
magnetometer
mathml
media
media-capabilities
media-source
mediacapture-depth
mediacapture-fromelement
mediacapture-image
mediacapture-record
mediacapture-streams
mediasession
mimesniff
mixed-content
mst-content-hint
navigation-timing
netinfo
network-error-logging
notifications
offscreen-canvas
old-tests
orientation-event
orientation-sensor
origin-policy
page-visibility
paint-timing
payment-handler
payment-method-basic-card
payment-method-id
payment-request
performance-timeline
permissions
picture-in-picture
pointerevents
pointerlock
preload
presentation-api
priority-hints
proximity
push-api
quirks
referrer-policy
remote-playback
reporting
requestidlecallback
resize-observer
resource-timing
resources
screen-capture
screen-orientation
scroll-animations
secure-contexts
selection
server-timing
service-workers
shadow-dom
shape-detection
speech-api
storage
streams
subresource-integrity
svg
svg-aam
tools
touch-events
trusted-types
uievents
upgrade-insecure-requests
url
user-timing
vibration
visual-viewport
wai-aria
wake-lock
wasm
web-animations
web-locks
web-nfc
web-share
webaudio
webauthn
webdriver
webgl
webmessaging
webmidi
webrtc
webrtc-stats
websockets
webstorage
webusb
webvr
webvtt
webxr
workers
worklets
x-frame-options
xhr
.codecov.yml	-rw-r--r--	66 bytes
.gitignore	-rw-r--r--	340 bytes
.gitmodules	-rw-r--r--	138 bytes
.pyup.yml	-rw-r--r--	1.0 KB
.taskcluster.yml	-rw-r--r--	3.0 KB
.travis.yml	-rw-r--r--	2.8 KB
CODEOWNERS	-rw-r--r--	98 bytes
CONTRIBUTING.md	-rw-r--r--	1.6 KB
LICENSE.md	-rw-r--r--	5.1 KB
README.md	-rw-r--r--	17.2 KB
check_stability.ini	-rw-r--r--	463 bytes
lint.whitelist	-rw-r--r--	44.9 KB
serve.py	-rw-r--r--	263 bytes
server-side.md	-rw-r--r--	8.1 KB
testharness_runner.html	-rw-r--r--	95 bytes
update-built-tests.sh	-rwxr-xr-x	208 bytes
wpt	-rwxr-xr-x	95 bytes
wpt.py	-rw-r--r--	15 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/web-platform-tests/wpt

Match the 'is rendered' definition from the spec in innerText.

README.md